Parent Issue

Part of #143 — 4 Code review agents before PR is opened

Overview

Create a specialized pre-PR code review agent that analyzes branch diffs only for functional correctness issues. This agent identifies logic errors, missing edge cases, incorrect control flow, null handling gaps, error handling deficiencies, and behavioral bugs before the developer opens a pull request.

User Story

As a developer generating large volumes of code with HVE, I want a focused functional correctness review of my branch changes so that I catch logic and behavioral bugs early — before involving reviewers in a PR.

Requirements

Core Behavior

1. The agent MUST only analyze the branch diff (changed files and lines), not the entire codebase.
2. Issues are numbered and ordered by severity (Critical, High, Medium, Low).
3. Each issue includes the file path, line numbers, the original code snippet, and a proposed fix.

Review Focus Areas

• Logic errors and incorrect control flow
• Missing or incorrect edge case handling
• Null/undefined reference risks
• Error handling gaps (uncaught exceptions, swallowed errors)
• Off-by-one errors and boundary conditions
• Incorrect return values or missing return paths
• Race conditions and concurrency issues
• Contract violations (API misuse, incorrect parameter passing)

Output Format

For each issue identified, provide feedback in this format:

## Issue {number}: [Brief descriptive title]

**Priority**: Critical/High/Medium/Low
**Category**: Logic | Edge Cases | Error Handling | Concurrency | Contract
**File**: `path/to/file`
**Lines**: 45-52

### Problem
[Specific description of the functional issue]

### Current Code
[Exact code from the diff that has the issue]

### Suggested Fix
[Exact replacement code that fixes the issue]

Deliverables

• Agent definition file (.agent.md) for the functional code review agent
• Agent placed in the code-reviewer collection directory
• Agent follows HVE Core conventions and prompt-builder standards
• Output format matches the numbered, severity-ordered issue template above
• Agent scoped to branch diff only — does not review unchanged code

Acceptance Criteria

• Agent produces numbered, severity-ordered functional correctness findings
• Each finding includes file path, line numbers, original code, and proposed fix
• Agent operates exclusively on branch diff content
• Agent works in GitHub Copilot (.github/agents/)
• No breaking changes to existing agents or workflows

Related Issues

• feat(agents): 4 Code review agents before PR is opened #143 — Parent issue: 4 Code review agents before PR is opened
• feat(agents): Engineering Agents Integration #63 — Engineering Agents Integration epic
• feat(agents): Integrate Code Reviewer Agent for Security Validation During Development #93 — Code Reviewer Agent (closed, broader scope)
• feat: Reorganize agents, instructions, prompts, and skills into collection-based subdirectories #643 — Collection-based directory reorganization