Merged
Conversation
katiewasnothere
approved these changes
Mar 21, 2022
dcantah
approved these changes
Mar 21, 2022
Contributor
dcantah
left a comment
There was a problem hiding this comment.
Maybe it's worth having this be part of the default goal, can't think of why we wouldn't want to always build this as it's the default if it exists.
Contributor
|
Oop this needs a rebase after 51aee6b |
Contributor
Author
I think this line |
New makefile target to create rootfs.vhd from rootfs.tar using tar2ext4. Requires building cmd/tar2ext4 locally. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New makefile target to create rootfs.vhd from rootfs.tar using tar2ext4.
Requires building cmd/tar2ext4 locally.
Signed-off-by: Hamza El-Saawy hamzaelsaawy@microsoft.com