test: use T.TempDir to create temporary test directory#1308
Merged
dcantah merged 2 commits intomicrosoft:masterfrom Mar 1, 2022
Juneezee:test/t.TempDir
Merged
test: use T.TempDir to create temporary test directory#1308dcantah merged 2 commits intomicrosoft:masterfrom Juneezee:test/t.TempDir
T.TempDir to create temporary test directory#1308dcantah merged 2 commits intomicrosoft:masterfrom
Juneezee:test/t.TempDir
Conversation
The directory created by `T.TempDir` is automatically removed when the test and all its subtests complete. Reference: https://pkg.go.dev/testing#T.TempDir Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Contributor
|
Thanks for the PR! |
anmaxvl
approved these changes
Mar 1, 2022
dcantah
reviewed
Mar 1, 2022
dcantah
approved these changes
Mar 1, 2022
Contributor
dcantah
left a comment
There was a problem hiding this comment.
This is great, thanks! One comment
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
) * test: use `T.TempDir` to create temporary test directory The directory created by `T.TempDir` is automatically removed when the test and all its subtests complete. Reference: https://pkg.go.dev/testing#T.TempDir Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small testing enhancement.
We can use the
T.TempDirfunction from thetestingpackage to create temporary directory. The directory created byT.TempDiris automatically removed when the test and all its subtests complete.Reference: https://pkg.go.dev/testing#T.TempDir