Refactor code for security policy#1279
Merged
anmaxvl merged 1 commit intomicrosoft:masterfrom Jan 28, 2022
Merged
Conversation
Contributor
Author
|
@SeanTAllen FYI |
03dc145 to
45efb49
Compare
The current implementation exposes some internal structure, which is unnecessary as well as some structs are duplicated across security policy package and security policy tool. This PR refactors code to de-duplicate exported structures and hides internal implementation behind new factory methods. Signed-off-by: Maksim An <maksiman@microsoft.com>
45efb49 to
f094fd7
Compare
1 task
Contributor
|
All of this seems good to me and in line with discussions that Maksim and I have had. |
KenGordon
approved these changes
Jan 25, 2022
Collaborator
KenGordon
left a comment
There was a problem hiding this comment.
Looks fine to me, moved a few things about.
dcantah
reviewed
Jan 25, 2022
dcantah
reviewed
Jan 26, 2022
dcantah
approved these changes
Jan 26, 2022
Contributor
dcantah
left a comment
There was a problem hiding this comment.
lgtm, little question about a toml field name
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
The current implementation exposes some internal structure, which is unnecessary as well as some structs are duplicated across security policy package and security policy tool. This PR refactors code to de-duplicate exported structures and hides internal implementation behind new factory methods. Signed-off-by: Maksim An <maksiman@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation exposes some internal structure,
which is unnecessary as well as some structs are duplicated
across security policy package and security policy tool.
This PR refactors code to de-duplicate exported structures
and hides internal implementation behind new factory methods.
Signed-off-by: Maksim An maksiman@microsoft.com