Skip to content

Add new internal cmd package request struct to remove shimdiag package import#1153

Merged
katiewasnothere merged 1 commit intomicrosoft:masterfrom
katiewasnothere:internal_cmd_request_struct
Sep 10, 2021
Merged

Add new internal cmd package request struct to remove shimdiag package import#1153
katiewasnothere merged 1 commit intomicrosoft:masterfrom
katiewasnothere:internal_cmd_request_struct

Conversation

@katiewasnothere
Copy link

Something weird happened with this PR #1149, so moving here.

Signed-off-by: Kathryn Baldauf kabaldau@microsoft.com

…e import

Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
@katiewasnothere katiewasnothere requested a review from a team as a code owner September 9, 2021 00:07
@kevpar
Copy link
Member

kevpar commented Sep 9, 2021

We can't just re-open the old one?

@dcantah
Copy link
Contributor

dcantah commented Sep 9, 2021

Well hello again

@katiewasnothere
Copy link
Author

katiewasnothere commented Sep 9, 2021

We can't just re-open the old one?

@kevpar Nope, the PR was closed automatically and wouldn't let me reopen because it said that the PR shared no commit history with the main branch. It wouldn't let me update the PR after either, so I couldn't push new changes even though the PR was made on the same branch this one is. ¯_(ツ)_/¯

edit: shrug emote doesn't show up right :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants