Switch JSON policy schema from using arrays to maps#1154
Merged
anmaxvl merged 1 commit intomicrosoft:masterfrom Sep 10, 2021
SeanTAllen:maps-in-policy-3
Merged
Switch JSON policy schema from using arrays to maps#1154anmaxvl merged 1 commit intomicrosoft:masterfrom SeanTAllen:maps-in-policy-3
anmaxvl merged 1 commit intomicrosoft:masterfrom
SeanTAllen:maps-in-policy-3
Conversation
Contributor
Author
anmaxvl
approved these changes
Sep 9, 2021
Contributor
The existing array based policy doesn't work with managed HSMs query language, so, we have switched it up to using maps instead of arrays. Map keys correspond to the array index that an entry would have. This allows us to keep ordering. Signed-off-by: Sean T. Allen <seanallen@microsoft.com>
dcantah
approved these changes
Sep 10, 2021
Contributor
dcantah
left a comment
There was a problem hiding this comment.
lgtm. Let's make sure we circle back to the issues we opened for improvements here
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Nov 17, 2021
Related work items: microsoft#1062, microsoft#1087, microsoft#1089, microsoft#1095, microsoft#1104, microsoft#1112, microsoft#1117, microsoft#1118, microsoft#1125, microsoft#1137, microsoft#1139, microsoft#1140, microsoft#1141, microsoft#1142, microsoft#1143, microsoft#1145, microsoft#1146, microsoft#1150, microsoft#1151, microsoft#1153, microsoft#1154, microsoft#1155, microsoft#1156, microsoft#1157, microsoft#1158, microsoft#1159, microsoft#1161, microsoft#1162, microsoft#1163, microsoft#1164, microsoft#1165, microsoft#1166, microsoft#1167, microsoft#1168, microsoft#1169, microsoft#1171, microsoft#1172, microsoft#1173, microsoft#1174, microsoft#1178
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing array based policy doesn't work with managed HSMs query language, so, we have switched
it up to using maps instead of arrays. Map keys correspond to the array index that an entry would have.
This allows us to keep ordering.
Signed-off-by: Sean T. Allen seanallen@microsoft.com