Add new internal cmd package request struct to remove shimdiag package import#1149
Closed
katiewasnothere wants to merge 1 commit intomicrosoft:masterfrom
Closed
Add new internal cmd package request struct to remove shimdiag package import#1149katiewasnothere wants to merge 1 commit intomicrosoft:masterfrom
katiewasnothere wants to merge 1 commit intomicrosoft:masterfrom
Conversation
dcantah
reviewed
Sep 8, 2021
| "golang.org/x/sys/windows" | ||
| ) | ||
|
|
||
| type CmdProcessRequest struct { |
Contributor
There was a problem hiding this comment.
Comment here on the reason for this. Right now you can only supply it on some specialty methods that are tailored for running a process in a uvm or on the host.
anmaxvl
approved these changes
Sep 8, 2021
dcantah
reviewed
Sep 8, 2021
| // ExecInShimHost is a helper function used to execute commands specified in `req` in the shim's | ||
| // hosting system. | ||
| func ExecInShimHost(ctx context.Context, req *shimdiag.ExecProcessRequest) (int, error) { | ||
| func ExecInShimHost(ctx context.Context, req *CmdProcessRequest) (int, error) { |
Contributor
There was a problem hiding this comment.
I feel like I'm getting deja-vu on another discussion on this naming, but we should probably remove the Shim from this name, can be another PR. Don't think this package should have any mention of it.
…e import Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
e62da4f to
2fa9e07
Compare
Author
|
I have no idea how this got closed lol edit for more details: somehow working with my branch locally the branch was rebased? on what? who knows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was created to remove the shimdiag package import in internal/cmd. This allows us to use the internal/cmd package in more places without worry about import cycles or improper use of service types.
Signed-off-by: Kathryn Baldauf kabaldau@microsoft.com