chore: bump @types/node types to v20 and @tsconfig to v18#31510
Merged
Hotell merged 2 commits intomicrosoft:masterfrom Jul 2, 2024
Merged
chore: bump @types/node types to v20 and @tsconfig to v18#31510Hotell merged 2 commits intomicrosoft:masterfrom
Hotell merged 2 commits intomicrosoft:masterfrom
Conversation
fabricteam
reviewed
May 29, 2024
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 624 | 632 | 5000 | |
| Button | mount | 304 | 303 | 5000 | |
| Field | mount | 1149 | 1117 | 5000 | |
| FluentProvider | mount | 713 | 681 | 5000 | |
| FluentProviderWithTheme | mount | 81 | 76 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 31 | 37 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 76 | 77 | 10 | |
| MakeStyles | mount | 884 | 866 | 50000 | |
| Persona | mount | 1768 | 1714 | 5000 | |
| SpinButton | mount | 1417 | 1409 | 5000 | |
| SwatchPicker | mount | 1670 | 1681 | 5000 |
Collaborator
📊 Bundle size report✅ No changes found |
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AttachmentMinimalPerf.default | 92 | 79 | 1.16:1 |
| ButtonMinimalPerf.default | 99 | 89 | 1.11:1 |
| PortalMinimalPerf.default | 90 | 81 | 1.11:1 |
| DropdownManyItemsPerf.default | 413 | 380 | 1.09:1 |
| RefMinimalPerf.default | 118 | 108 | 1.09:1 |
| TableMinimalPerf.default | 249 | 231 | 1.08:1 |
| AvatarMinimalPerf.default | 111 | 104 | 1.07:1 |
| ListWith60ListItems.default | 385 | 361 | 1.07:1 |
| InputMinimalPerf.default | 566 | 533 | 1.06:1 |
| LoaderMinimalPerf.default | 193 | 182 | 1.06:1 |
| TreeWith60ListItems.default | 94 | 89 | 1.06:1 |
| FormMinimalPerf.default | 232 | 221 | 1.05:1 |
| RosterPerf.default | 1643 | 1559 | 1.05:1 |
| TextMinimalPerf.default | 202 | 193 | 1.05:1 |
| CardMinimalPerf.default | 313 | 301 | 1.04:1 |
| CarouselMinimalPerf.default | 264 | 255 | 1.04:1 |
| DividerMinimalPerf.default | 209 | 201 | 1.04:1 |
| DropdownMinimalPerf.default | 1475 | 1423 | 1.04:1 |
| ListMinimalPerf.default | 311 | 300 | 1.04:1 |
| SkeletonMinimalPerf.default | 202 | 194 | 1.04:1 |
| StatusMinimalPerf.default | 400 | 384 | 1.04:1 |
| ToolbarMinimalPerf.default | 558 | 538 | 1.04:1 |
| AnimationMinimalPerf.default | 305 | 295 | 1.03:1 |
| AttachmentSlotsPerf.default | 649 | 630 | 1.03:1 |
| CheckboxMinimalPerf.default | 1176 | 1137 | 1.03:1 |
| HeaderMinimalPerf.default | 218 | 211 | 1.03:1 |
| MenuMinimalPerf.default | 514 | 497 | 1.03:1 |
| ProviderMergeThemesPerf.default | 654 | 635 | 1.03:1 |
| ReactionMinimalPerf.default | 213 | 206 | 1.03:1 |
| SliderMinimalPerf.default | 762 | 740 | 1.03:1 |
| TextAreaMinimalPerf.default | 296 | 288 | 1.03:1 |
| VideoMinimalPerf.default | 456 | 441 | 1.03:1 |
| ButtonOverridesMissPerf.default | 647 | 637 | 1.02:1 |
| EmbedMinimalPerf.default | 1903 | 1873 | 1.02:1 |
| FlexMinimalPerf.default | 158 | 155 | 1.02:1 |
| ImageMinimalPerf.default | 227 | 222 | 1.02:1 |
| MenuButtonMinimalPerf.default | 968 | 950 | 1.02:1 |
| ProviderMinimalPerf.default | 201 | 197 | 1.02:1 |
| TableManyItemsPerf.default | 1099 | 1078 | 1.02:1 |
| GridMinimalPerf.default | 190 | 189 | 1.01:1 |
| ItemLayoutMinimalPerf.default | 718 | 711 | 1.01:1 |
| LayoutMinimalPerf.default | 200 | 198 | 1.01:1 |
| SplitButtonMinimalPerf.default | 2282 | 2267 | 1.01:1 |
| AlertMinimalPerf.default | 154 | 154 | 1:1 |
| ChatDuplicateMessagesPerf.default | 159 | 159 | 1:1 |
| ChatMinimalPerf.default | 443 | 442 | 1:1 |
| DatepickerMinimalPerf.default | 3603 | 3607 | 1:1 |
| HeaderSlotsPerf.default | 457 | 457 | 1:1 |
| PopupMinimalPerf.default | 343 | 344 | 1:1 |
| CustomToolbarPrototype.default | 1464 | 1470 | 1:1 |
| TooltipMinimalPerf.default | 1236 | 1232 | 1:1 |
| ButtonSlotsPerf.default | 298 | 301 | 0.99:1 |
| LabelMinimalPerf.default | 209 | 213 | 0.98:1 |
| ListCommonPerf.default | 381 | 390 | 0.98:1 |
| RadioGroupMinimalPerf.default | 260 | 265 | 0.98:1 |
| SegmentMinimalPerf.default | 189 | 193 | 0.98:1 |
| TreeMinimalPerf.default | 481 | 491 | 0.98:1 |
| DialogMinimalPerf.default | 432 | 445 | 0.97:1 |
| IconMinimalPerf.default | 366 | 379 | 0.97:1 |
| BoxMinimalPerf.default | 206 | 214 | 0.96:1 |
| ChatWithPopoverPerf.default | 192 | 204 | 0.94:1 |
| ListNestedPerf.default | 326 | 346 | 0.94:1 |
| AccordionMinimalPerf.default | 82 | 92 | 0.89:1 |
8e7000c to
1cf9f19
Compare
Collaborator
🕵 FluentUIV0 No visual regressions between this PR and main |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 603 | 619 | 5000 | |
| Breadcrumb | mount | 1698 | 1696 | 1000 | |
| Checkbox | mount | 1688 | 1686 | 5000 | |
| CheckboxBase | mount | 1499 | 1487 | 5000 | |
| ChoiceGroup | mount | 2970 | 3015 | 5000 | |
| ComboBox | mount | 697 | 690 | 1000 | |
| CommandBar | mount | 6575 | 6540 | 1000 | |
| ContextualMenu | mount | 13799 | 13614 | 1000 | |
| DefaultButton | mount | 801 | 781 | 5000 | |
| DetailsRow | mount | 2233 | 2186 | 5000 | |
| DetailsRowFast | mount | 2230 | 2205 | 5000 | |
| DetailsRowNoStyles | mount | 2019 | 2041 | 5000 | |
| Dialog | mount | 2671 | 2656 | 1000 | |
| DocumentCardTitle | mount | 229 | 231 | 1000 | |
| Dropdown | mount | 2025 | 2023 | 5000 | |
| FocusTrapZone | mount | 1151 | 1188 | 5000 | |
| FocusZone | mount | 1094 | 1100 | 5000 | |
| GroupedList | mount | 37958 | 42214 | 2 | |
| GroupedList | virtual-rerender | 18179 | 20318 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 51156 | 50911 | 2 | |
| GroupedListV2 | mount | 226 | 225 | 2 | |
| GroupedListV2 | virtual-rerender | 220 | 202 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 231 | 229 | 2 | |
| IconButton | mount | 1145 | 1146 | 5000 | |
| Label | mount | 339 | 332 | 5000 | |
| Layer | mount | 2746 | 2770 | 5000 | |
| Link | mount | 394 | 376 | 5000 | |
| MenuButton | mount | 994 | 994 | 5000 | |
| MessageBar | mount | 21335 | 21261 | 5000 | |
| Nav | mount | 2021 | 2052 | 1000 | |
| OverflowSet | mount | 794 | 798 | 5000 | |
| Panel | mount | 1822 | 1794 | 1000 | |
| Persona | mount | 759 | 746 | 1000 | |
| Pivot | mount | 901 | 899 | 1000 | |
| PrimaryButton | mount | 930 | 954 | 5000 | |
| Rating | mount | 4714 | 4691 | 5000 | |
| SearchBox | mount | 914 | 915 | 5000 | |
| Shimmer | mount | 1925 | 1913 | 5000 | |
| Slider | mount | 1311 | 1301 | 5000 | |
| SpinButton | mount | 2956 | 2939 | 5000 | |
| Spinner | mount | 394 | 389 | 5000 | |
| SplitButton | mount | 1864 | 1869 | 5000 | |
| Stack | mount | 421 | 424 | 5000 | |
| StackWithIntrinsicChildren | mount | 883 | 867 | 5000 | |
| StackWithTextChildren | mount | 2810 | 2805 | 5000 | |
| SwatchColorPicker | mount | 6541 | 6530 | 5000 | |
| TagPicker | mount | 1442 | 1467 | 5000 | |
| Text | mount | 389 | 374 | 5000 | |
| TextField | mount | 966 | 946 | 5000 | |
| ThemeProvider | mount | 864 | 860 | 5000 | |
| ThemeProvider | virtual-rerender | 583 | 582 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1314 | 1366 | 5000 | |
| Toggle | mount | 619 | 624 | 5000 | |
| buttonNative | mount | 195 | 193 | 5000 |
1cf9f19 to
9ab4e91
Compare
fabricteam
reviewed
May 29, 2024
9ab4e91 to
6b0994d
Compare
cad8bdf to
3d98468
Compare
fabricteam
reviewed
May 30, 2024
3d98468 to
0e53df4
Compare
0e53df4 to
e9ad53b
Compare
dmytrokirpa
approved these changes
Jul 2, 2024
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jul 3, 2024
* master: (45 commits) Added unit testcases for sparkline chart. (microsoft#31843) release: applying package updates - react v8 release: applying package updates - web-components fix(web-components): fix enterkey interaction on menu (microsoft#31894) chore(web-components): expose field to package exports (microsoft#31904) fix(web-components): slotted elements within fluent-text-input can't be focused (microsoft#31903) fix(web-components): fix menu positioning in firefox (microsoft#31895) chore: bump @types/node types to v20 and @tsconfig to v18 (microsoft#31510) chore: migrate to nx 19.2.3 (microsoft#31828) chore: fix install verdacio command (microsoft#31897) fix(scripts-prettier): escape file names that are being passed to prettier bin via shell (microsoft#31889) release: applying package updates - react-components feat:(docs) Adds pattern doc on Basic Recomposition (microsoft#31861) chore:(docs) Archive the wiki 🎉 (microsoft#31202) feat:(react-nav-preview) Adds NavDivider implementation (microsoft#31848) ci(.github): resolve due_on UTC time creation issues (microsoft#31890) release: applying package updates - web-components fix: update internal usage of useModalAttributes to use legacyTrapFocus by default (microsoft#31801) chore: make utils a package export (microsoft#31865) fix: add live region around scroll index update (microsoft#31863) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-requirements
Previous Behavior
New Behavior
apps and scripts tsconfig.json are bumped only to
@tsconfig/node18which is the last setting that sets module resolution toNodeandlibto2022@tsconfig/node20is blocked by typescript as those configs setlibto2023which is supported starting TS v5.0Related Issue(s)