fix(web-components): fix enterkey interaction on menu#31894
Merged
davatron5000 merged 4 commits intomicrosoft:masterfrom Jul 2, 2024
Merged
Conversation
Collaborator
📊 Bundle size report✅ No changes found |
fabricteam
reviewed
Jul 1, 2024
change/@fluentui-web-components-e417861e-ef1b-4b4f-8c25-fef57cda85d9.json
Show resolved
Hide resolved
mlijanto
reviewed
Jul 1, 2024
Member
There was a problem hiding this comment.
Thanks for fixing this issue and adding the tests @davatron5000! Looks good to me 👍🏼. Only left a couple of small comments.
mlijanto
approved these changes
Jul 2, 2024
eljefe223
approved these changes
Jul 2, 2024
marchbox
approved these changes
Jul 2, 2024
Contributor
marchbox
left a comment
There was a problem hiding this comment.
LGTM other than a small thing.
radium-v
approved these changes
Jul 2, 2024
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jul 3, 2024
* master: (45 commits) Added unit testcases for sparkline chart. (microsoft#31843) release: applying package updates - react v8 release: applying package updates - web-components fix(web-components): fix enterkey interaction on menu (microsoft#31894) chore(web-components): expose field to package exports (microsoft#31904) fix(web-components): slotted elements within fluent-text-input can't be focused (microsoft#31903) fix(web-components): fix menu positioning in firefox (microsoft#31895) chore: bump @types/node types to v20 and @tsconfig to v18 (microsoft#31510) chore: migrate to nx 19.2.3 (microsoft#31828) chore: fix install verdacio command (microsoft#31897) fix(scripts-prettier): escape file names that are being passed to prettier bin via shell (microsoft#31889) release: applying package updates - react-components feat:(docs) Adds pattern doc on Basic Recomposition (microsoft#31861) chore:(docs) Archive the wiki 🎉 (microsoft#31202) feat:(react-nav-preview) Adds NavDivider implementation (microsoft#31848) ci(.github): resolve due_on UTC time creation issues (microsoft#31890) release: applying package updates - web-components fix: update internal usage of useModalAttributes to use legacyTrapFocus by default (microsoft#31801) chore: make utils a package export (microsoft#31865) fix: add live region around scroll index update (microsoft#31863) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Opening the menu component and selecting a
menuitemwithenterkeyshould trigger the menu to close unless it's amenuitemradioormenuitemcheckbox.New Behavior
Menulisten for thechangeevent emitted by menu-item.ts#L220Related Issue(s)
Adding @mlijanto as a reviewer to verify fix for upstream usage.