Skip to content

ci: migrate to node 20#31495

Merged
Hotell merged 1 commit intomicrosoft:masterfrom
Hotell:deps/migrate-to-node-v20
May 29, 2024
Merged

ci: migrate to node 20#31495
Hotell merged 1 commit intomicrosoft:masterfrom
Hotell:deps/migrate-to-node-v20

Conversation

@Hotell
Copy link
Contributor

@Hotell Hotell commented May 28, 2024 •
edited
Loading

Previous Behavior

New Behavior

Important

  • once this PR is merged you won't be able to install packages etc if you use older node that v20.
  • you can temporarily mitigate this by running yarn install --ignore-engines, but you should migrate to node v20

Related Issue(s)

  • Fixes #

@github-actions github-actions bot added this to the April Project Cycle Q1 2024 milestone May 28, 2024
fabricteam
fabricteam reviewed May 28, 2024
View reviewed changes
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 28, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@fabricteam
Copy link
Collaborator

fabricteam commented May 28, 2024

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 628 658 5000
Button mount 302 294 5000
Field mount 1128 1152 5000
FluentProvider mount 719 723 5000
FluentProviderWithTheme mount 88 86 10
FluentProviderWithTheme virtual-rerender 34 39 10
FluentProviderWithTheme virtual-rerender-with-unmount 85 80 10
MakeStyles mount 872 874 50000
Persona mount 1816 1758 5000
SpinButton mount 1360 1385 5000
SwatchPicker mount 1589 1538 5000

@fabricteam
Copy link
Collaborator

fabricteam commented May 28, 2024

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AttachmentMinimalPerf.default 88 76 1.16:1
ImageMinimalPerf.default 234 207 1.13:1
ButtonMinimalPerf.default 92 83 1.11:1
ChatDuplicateMessagesPerf.default 163 150 1.09:1
GridMinimalPerf.default 201 184 1.09:1
PortalMinimalPerf.default 93 85 1.09:1
SliderMinimalPerf.default 780 714 1.09:1
RefMinimalPerf.default 112 104 1.08:1
DividerMinimalPerf.default 210 196 1.07:1
DropdownManyItemsPerf.default 390 365 1.07:1
LabelMinimalPerf.default 230 217 1.06:1
ButtonSlotsPerf.default 324 310 1.05:1
CarouselMinimalPerf.default 257 244 1.05:1
HeaderMinimalPerf.default 205 195 1.05:1
TextAreaMinimalPerf.default 297 282 1.05:1
SkeletonMinimalPerf.default 197 189 1.04:1
TableMinimalPerf.default 240 231 1.04:1
TooltipMinimalPerf.default 1321 1269 1.04:1
BoxMinimalPerf.default 192 187 1.03:1
ChatMinimalPerf.default 440 426 1.03:1
RadioGroupMinimalPerf.default 260 253 1.03:1
AccordionMinimalPerf.default 90 88 1.02:1
AttachmentSlotsPerf.default 629 619 1.02:1
DropdownMinimalPerf.default 1422 1393 1.02:1
LayoutMinimalPerf.default 201 198 1.02:1
ListWith60ListItems.default 366 358 1.02:1
PopupMinimalPerf.default 350 343 1.02:1
ToolbarMinimalPerf.default 536 523 1.02:1
ButtonOverridesMissPerf.default 652 643 1.01:1
InputMinimalPerf.default 537 531 1.01:1
ItemLayoutMinimalPerf.default 713 703 1.01:1
ListNestedPerf.default 321 319 1.01:1
MenuMinimalPerf.default 499 496 1.01:1
MenuButtonMinimalPerf.default 959 950 1.01:1
ProviderMergeThemesPerf.default 644 635 1.01:1
SplitButtonMinimalPerf.default 2257 2226 1.01:1
TableManyItemsPerf.default 1089 1078 1.01:1
CustomToolbarPrototype.default 1489 1472 1.01:1
TreeWith60ListItems.default 87 86 1.01:1
VideoMinimalPerf.default 427 422 1.01:1
CheckboxMinimalPerf.default 1129 1128 1:1
DatepickerMinimalPerf.default 3547 3551 1:1
EmbedMinimalPerf.default 1855 1857 1:1
HeaderSlotsPerf.default 458 457 1:1
ListCommonPerf.default 376 375 1:1
RosterPerf.default 1544 1540 1:1
ReactionMinimalPerf.default 208 209 1:1
DialogMinimalPerf.default 436 440 0.99:1
FormMinimalPerf.default 223 225 0.99:1
SegmentMinimalPerf.default 197 199 0.99:1
AnimationMinimalPerf.default 287 294 0.98:1
ChatWithPopoverPerf.default 193 197 0.98:1
FlexMinimalPerf.default 146 149 0.98:1
ListMinimalPerf.default 300 305 0.98:1
ProviderMinimalPerf.default 197 201 0.98:1
StatusMinimalPerf.default 379 387 0.98:1
AlertMinimalPerf.default 155 159 0.97:1
CardMinimalPerf.default 300 310 0.97:1
IconMinimalPerf.default 399 410 0.97:1
TextMinimalPerf.default 190 196 0.97:1
TreeMinimalPerf.default 470 487 0.97:1
LoaderMinimalPerf.default 182 192 0.95:1
AvatarMinimalPerf.default 105 113 0.93:1

fabricteam
fabricteam reviewed May 28, 2024
View reviewed changes
@fabricteam
Copy link
Collaborator

fabricteam commented May 28, 2024

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented May 28, 2024

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

fabricteam commented May 28, 2024

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 623 623 5000
Breadcrumb mount 1663 1665 1000
Checkbox mount 1672 1696 5000
CheckboxBase mount 1465 1491 5000
ChoiceGroup mount 2941 2936 5000
ComboBox mount 693 695 1000
CommandBar mount 6425 6470 1000
ContextualMenu mount 11875 11945 1000
DefaultButton mount 799 775 5000
DetailsRow mount 2321 2273 5000
DetailsRowFast mount 2354 2235 5000
DetailsRowNoStyles mount 2053 2053 5000
Dialog mount 2619 2654 1000
DocumentCardTitle mount 225 233 1000
Dropdown mount 2012 2031 5000
FocusTrapZone mount 1160 1133 5000
FocusZone mount 1080 1105 5000
GroupedList mount 41714 42587 2
GroupedList virtual-rerender 20019 20058 2
GroupedList virtual-rerender-with-unmount 51032 51447 2
GroupedListV2 mount 221 231 2
GroupedListV2 virtual-rerender 221 217 2
GroupedListV2 virtual-rerender-with-unmount 237 219 2
IconButton mount 1137 1132 5000
Label mount 354 344 5000
Layer mount 2753 2679 5000
Link mount 404 393 5000
MenuButton mount 958 984 5000
MessageBar mount 21389 21382 5000
Nav mount 2022 1995 1000
OverflowSet mount 786 806 5000
Panel mount 1831 1802 1000
Persona mount 741 761 1000
Pivot mount 892 919 1000
PrimaryButton mount 927 922 5000
Rating mount 4740 4652 5000
SearchBox mount 937 923 5000
Shimmer mount 1887 1909 5000
Slider mount 1342 1291 5000
SpinButton mount 2946 2976 5000
Spinner mount 378 380 5000
SplitButton mount 1929 1902 5000
Stack mount 419 400 5000
StackWithIntrinsicChildren mount 842 870 5000
StackWithTextChildren mount 2641 2725 5000
SwatchColorPicker mount 6432 6364 5000
TagPicker mount 1458 1438 5000
Text mount 384 385 5000
TextField mount 952 934 5000
ThemeProvider mount 844 853 5000
ThemeProvider virtual-rerender 585 578 5000
ThemeProvider virtual-rerender-with-unmount 1293 1292 5000
Toggle mount 613 606 5000
buttonNative mount 197 182 5000

fabricteam
fabricteam reviewed May 28, 2024
View reviewed changes
@Hotell Hotell marked this pull request as ready for review May 28, 2024 16:28
@Hotell Hotell requested a review from a team as a code owner May 28, 2024 16:28
@Hotell Hotell merged commit 07d1911 into microsoft:master May 29, 2024
@Hotell Hotell deleted the deps/migrate-to-node-v20 branch May 29, 2024 11:50
@Hotell Hotell mentioned this pull request May 29, 2024
Merged
1 task
miroslavstastny pushed a commit to miroslavstastny/fluentui that referenced this pull request Jun 14, 2024
@Hotell @miroslavstastny
ci: migrate to node 20 (microsoft#31495)
77705c6
@Hotell Hotell mentioned this pull request Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabricteam fabricteam fabricteam left review comments

+1 more reviewer

@ling1726 ling1726 ling1726 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area: Build System CI

Projects

None yet

Milestone

April Project Cycle Q1 2024

Development

Successfully merging this pull request may close these issues.

3 participants

@Hotell @fabricteam @ling1726