refactor(scripts): more domain boundaries encapsulation by Hotell · Pull Request #25851 · microsoft/fluentui

Hotell · 2022-11-30T22:19:47Z

New Behavior

remove usage of scripts/tsconfig.json within package tsconfigs
rename tsconfig.scripts.json -> tsconfig.json to follow our ts solution pattern
rename scripts/tsconfig.json -> scripts/tsconfig.lib.json ( it handles now only /tasks and scripts/index.ts )
move merge from tasks/ to utils/
move eslintConstants from tasks/ to monorepo
introduce barrel files for /prettier and /puppeteer

Related Issue(s)

Fixes partially feat: make backbone of our tooling compliant with package standards (packaging /scripts) #24349

…o index

…me it to index

…nd rename it to index

fabricteam · 2022-11-30T22:28:55Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`533 B` `341 B`
`global-context` createContextSelector	`554 B` `348 B`
`priority-overflow` createOverflowManager	`3.153 kB` `1.299 kB`
`react-accordion` Accordion (including children components)	`79.294 kB` `24.443 kB`
`react-alert` Alert	`82.967 kB` `21.022 kB`
`react-avatar` Avatar	`51.076 kB` `14.285 kB`
`react-avatar` AvatarGroup	`15.006 kB` `6.009 kB`
`react-avatar` AvatarGroupItem	`67.306 kB` `18.581 kB`
`react-badge` Badge	`23.357 kB` `7.361 kB`
`react-badge` CounterBadge	`24.247 kB` `7.643 kB`
`react-badge` PresenceBadge	`24.001 kB` `7.049 kB`
`react-button` Button	`32.923 kB` `8.61 kB`
`react-button` CompoundButton	`39.953 kB` `9.933 kB`
`react-button` MenuButton	`37.611 kB` `9.942 kB`
`react-button` SplitButton	`45.057 kB` `11.323 kB`
`react-button` ToggleButton	`48.753 kB` `10.715 kB`
`react-card` Card - All	`71.873 kB` `20.936 kB`
`react-card` Card	`67.651 kB` `19.892 kB`
`react-card` CardFooter	`8.617 kB` `3.62 kB`
`react-card` CardHeader	`9.792 kB` `3.995 kB`
`react-card` CardPreview	`8.718 kB` `3.674 kB`
`react-combobox` Combobox (including child components)	`78.244 kB` `25.015 kB`
`react-combobox` Dropdown (including child components)	`77.531 kB` `24.927 kB`
`react-components` react-components: Button, FluentProvider & webLightTheme	`59.018 kB` `16.371 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`186.456 kB` `52.327 kB`
`react-components` react-components: FluentProvider & webLightTheme	`33.48 kB` `11.037 kB`
`react-dialog` Dialog (including children components)	`83.036 kB` `24.754 kB`
`react-divider` Divider	`16.515 kB` `5.921 kB`
`react-image` Image	`10.836 kB` `4.283 kB`
`react-infobutton` InfoButton	`117.922 kB` `35.391 kB`
`react-input` Input	`24.194 kB` `7.89 kB`
`react-label` Label	`9.394 kB` `3.88 kB`
`react-link` Link	`11.862 kB` `4.885 kB`
`react-menu` Menu (including children components)	`117.61 kB` `36.287 kB`
`react-menu` Menu (including selectable components)	`120.679 kB` `36.82 kB`
`react-overflow` hooks only	`11.004 kB` `4.188 kB`
`react-persona` Persona	`57.131 kB` `15.951 kB`
`react-popover` Popover	`103.666 kB` `31.858 kB`
`react-portal` Portal	`10.495 kB` `3.851 kB`
`react-portal-compat` PortalCompatProvider	`5.857 kB` `1.978 kB`
`react-positioning` usePositioning	`19.826 kB` `7.417 kB`
`react-progress` Progress	`13.536 kB` `5.107 kB`
`react-provider` FluentProvider	`15.817 kB` `5.905 kB`
`react-radio` Radio	`36.446 kB` `12.123 kB`
`react-radio` RadioGroup	`14.304 kB` `5.72 kB`
`react-select` Select	`23.474 kB` `8.017 kB`
`react-slider` Slider	`32.118 kB` `10.192 kB`
`react-spinbutton` SpinButton	`44.502 kB` `12.812 kB`
`react-spinner` Spinner	`20.013 kB` `6.446 kB`
`react-switch` Switch	`33.453 kB` `10.581 kB`
`react-text` Text - Default	`11.838 kB` `4.625 kB`
`react-text` Text - Wrappers	`15.148 kB` `5.06 kB`
`react-textarea` Textarea	`25.733 kB` `8.328 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`29.722 kB` `6.462 kB`
`react-theme` Teams: Light theme	`17.51 kB` `5.075 kB`
`react-tooltip` Tooltip	`42.032 kB` `14.739 kB`
`react-utilities` SSRProvider	`180 B` `159 B`

_{🤖 This report was generated against 5079ab52943dded035d7bf7348d1c2762271ae9d}

codesandbox-ci · 2022-11-30T22:43:56Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3173ee4:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

fabricteam · 2022-11-30T22:44:43Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	1582	1587	5000
Button	mount	1165	1112	5000
FluentProvider	mount	1914	1933	5000
FluentProviderWithTheme	mount	759	749	10
FluentProviderWithTheme	virtual-rerender	705	700	10
FluentProviderWithTheme	virtual-rerender-with-unmount	746	745	10
MakeStyles	mount	2362	2353	50000
SpinButton	mount	3050	3119	5000

fabricteam · 2022-11-30T22:46:32Z

🕵 fluentuiv8 No visual regressions between this PR and main

…tasks and rename it to index

fabricteam · 2022-11-30T22:50:35Z

Perf Analysis (`@fluentui/react-northstar`)

⚠️ No perf measurements available

fabricteam · 2022-11-30T23:01:26Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	1213	1188	5000
Breadcrumb	mount	2903	2928	1000
Checkbox	mount	2671	2648	5000
CheckboxBase	mount	2370	2383	5000
ChoiceGroup	mount	4451	4533	5000
ComboBox	mount	1235	1255	1000
CommandBar	mount	9595	9652	1000
ContextualMenu	mount	11302	11271	1000
DefaultButton	mount	1377	1399	5000
DetailsRow	mount	3644	3685	5000
DetailsRowFast	mount	3669	3636	5000
DetailsRowNoStyles	mount	3522	3509	5000
Dialog	mount	3126	3111	1000
DocumentCardTitle	mount	591	589	1000
Dropdown	mount	3257	3446	5000
FocusTrapZone	mount	1994	1991	5000
FocusZone	mount	1974	1965	5000
GroupedList	mount	1908	2151	2
GroupedList	virtual-rerender	1158	1121	2
GroupedList	virtual-rerender-with-unmount	1676	1702	2
GroupedListV2	mount	566	568	2
GroupedListV2	virtual-rerender	565	550	2
GroupedListV2	virtual-rerender-with-unmount	560	568	2
IconButton	mount	1941	1933	5000
Label	mount	725	730	5000
Layer	mount	4433	4379	5000
Link	mount	842	853	5000
MenuButton	mount	1703	1692	5000
MessageBar	mount	2317	2272	5000
Nav	mount	3305	3333	1000
OverflowSet	mount	1379	1373	5000
Panel	mount	2564	2594	1000
Persona	mount	1286	1321	1000
Pivot	mount	1662	1637	1000
PrimaryButton	mount	1534	1532	5000
Rating	mount	7073	7110	5000
SearchBox	mount	1506	1517	5000
Shimmer	mount	2900	2881	5000
Slider	mount	2091	2087	5000
SpinButton	mount	4704	4768	5000
Spinner	mount	795	802	5000
SplitButton	mount	3127	3123	5000
Stack	mount	820	824	5000
StackWithIntrinsicChildren	mount	2482	2439	5000
StackWithTextChildren	mount	4923	4928	5000
SwatchColorPicker	mount	10573	10667	5000
TagPicker	mount	2646	2834	5000
TeachingBubble	mount	88635	88875	5000
Text	mount	796	788	5000
TextField	mount	1600	1616	5000
ThemeProvider	mount	1536	1537	5000
ThemeProvider	virtual-rerender	1090	1093	5000
ThemeProvider	virtual-rerender-with-unmount	2151	2176	5000
Toggle	mount	1124	1120	5000
buttonNative	mount	547	556	5000

fabricteam · 2022-11-30T23:13:02Z

🕵 fluentuiv9 Open the Visual Regressions report to inspect the 1 screenshots

✅ There was 0 screenshots added, 0 screenshots removed, 1753 screenshots unchanged, 0 screenshots with different dimensions and 1 screenshots with visible difference.

unknown 1 screenshots

Image Name	Diff(in Pixels)	Image Type
Avatar Converged.size+active+ring-shadow.normal.chromium.png	1	Changed

…rt of /tasks and rename it to index

size-auditor · 2022-11-30T23:47:23Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 5079ab52943dded035d7bf7348d1c2762271ae9d (build)

* master: fix: Pressed and Hover states for toolbar buttons (microsoft#25835) feat: add large size for toolbar (microsoft#25830) applying package updates adding perf test for Persona (microsoft#25863) fix: Fixing Slider's programmatic focus (microsoft#25869) chore(v0 docs): Add storybook stories that reference docsite examples for 1JS VR tool migration (microsoft#25663) fix: Respecting user-provided ids in ComboBox options (microsoft#25867) refactor(scripts): more domain boundaries encapsulation (microsoft#25851) docs: add documentation about how to migrate V0 createSvgIcon (microsoft#25828) support cross story linking and create example in Menu story (microsoft#25850)

) * refactor(scripts): move merge to /utils * refactor(scripts): introduce barrel file to /puppeteer * refactor(scripts): move eslint-constants to /monorepo * refactor(scripts): introduce barrel file to /prettier * refactor(scripts): make just.config.ts part of /tasks and rename it to index * fixup! refactor(scripts): make just.config.ts part of /tasks and rename it to index * generate changefiles

Hotell added 7 commits November 30, 2022 22:47

refactor(scripts): move merge to /utils

6673da6

refactor(scripts): introduce barrel file to /puppeteer

b24dcea

refactor(scripts): move eslint-constants to /monorepo

b98a780

refactor(scripts): introduce barrel file to /prettier

81e0646

refactor(scripts): make just.config.ts part of /tasks and rename it t…

871ef83

…o index

fixup! refactor(scripts): make just.config.ts part of /tasks and rena…

1c4c32e

…me it to index

generate changefiles

a02a581

msft-fluent-ui-bot assigned khmakoto Nov 30, 2022

Hotell unassigned khmakoto Nov 30, 2022

github-actions bot added this to the October Project Cycle Q4 2022 milestone Nov 30, 2022

Hotell changed the title ~~Hotell/build/scripts/ts solution config v6~~ refactor(scripts): more domain boundaries encapsulation Nov 30, 2022

Hotell mentioned this pull request Nov 30, 2022

chore: enable proper type checking within all just.config.ts and its dependents #25852

Merged

1 task

fixup! fixup! refactor(scripts): make just.config.ts part of /tasks a…

e711d82

…nd rename it to index

fixup! fixup! fixup! refactor(scripts): make just.config.ts part of /…

dec5f5c

…tasks and rename it to index

fixup! fixup! fixup! fixup! refactor(scripts): make just.config.ts pa…

3173ee4

…rt of /tasks and rename it to index

Hotell marked this pull request as ready for review December 1, 2022 09:46

Hotell requested a review from a team as a code owner December 1, 2022 09:46

Hotell removed this from the October Project Cycle Q4 2022 milestone Dec 1, 2022

tudorpopams self-requested a review December 1, 2022 13:15

Hotell enabled auto-merge (squash) December 1, 2022 17:34

TristanWatanabe approved these changes Dec 1, 2022

View reviewed changes

Hotell merged commit 6213380 into microsoft:master Dec 1, 2022

Hotell mentioned this pull request Dec 23, 2022

feat: make backbone of our tooling compliant with package standards (packaging /scripts) #24349

Closed

18 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(scripts): more domain boundaries encapsulation#25851

refactor(scripts): more domain boundaries encapsulation#25851
Hotell merged 10 commits intomicrosoft:masterfrom
Hotell:hotell/build/scripts/ts-solution-config-v6

Hotell commented Nov 30, 2022 •

edited

Loading

Uh oh!

fabricteam commented Nov 30, 2022 •

edited

Loading

Uh oh!

codesandbox-ci bot commented Nov 30, 2022 •

edited

Loading

Uh oh!

fabricteam commented Nov 30, 2022 •

edited

Loading

Uh oh!

fabricteam commented Nov 30, 2022 •

edited

Loading

Uh oh!

fabricteam commented Nov 30, 2022

Uh oh!

fabricteam commented Nov 30, 2022 •

edited

Loading

Uh oh!

fabricteam commented Nov 30, 2022 •

edited

Loading

Uh oh!

size-auditor bot commented Nov 30, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Hotell commented Nov 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

New Behavior

Related Issue(s)

Uh oh!

fabricteam commented Nov 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

codesandbox-ci bot commented Nov 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fabricteam commented Nov 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-components)

Uh oh!

fabricteam commented Nov 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 fluentuiv8 No visual regressions between this PR and main

Uh oh!

fabricteam commented Nov 30, 2022

Perf Analysis (@fluentui/react-northstar)

Uh oh!

fabricteam commented Nov 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react)

Uh oh!

fabricteam commented Nov 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 fluentuiv9 Open the Visual Regressions report to inspect the 1 screenshots

Uh oh!

size-auditor bot commented Nov 30, 2022

Asset size changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Hotell commented Nov 30, 2022 •

edited

Loading

fabricteam commented Nov 30, 2022 •

edited

Loading

codesandbox-ci bot commented Nov 30, 2022 •

edited

Loading

fabricteam commented Nov 30, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

fabricteam commented Nov 30, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-northstar`)

fabricteam commented Nov 30, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react`)

fabricteam commented Nov 30, 2022 •

edited

Loading