support cross story linking and create example in Menu story#25850
Merged
micahgodbolt merged 2 commits intomicrosoft:masterfrom Dec 1, 2022
Merged
support cross story linking and create example in Menu story#25850micahgodbolt merged 2 commits intomicrosoft:masterfrom
micahgodbolt merged 2 commits intomicrosoft:masterfrom
Conversation
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 5079ab52943dded035d7bf7348d1c2762271ae9d (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 592abf5:
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1492 | 1533 | 5000 | |
| Button | mount | 1103 | 1059 | 5000 | |
| FluentProvider | mount | 1781 | 1835 | 5000 | |
| FluentProviderWithTheme | mount | 732 | 715 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 691 | 681 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 732 | 730 | 10 | |
| MakeStyles | mount | 2227 | 2193 | 50000 | |
| SpinButton | mount | 2987 | 2896 | 5000 |
Collaborator
Perf Analysis (
|
Collaborator
🕵 fluentuiv8 Open the Visual Regressions report to inspect the 2 screenshots✅ There was 2 screenshots added, 0 screenshots removed, 1037 screenshots unchanged, 0 screenshots with different dimensions and 0 screenshots with visible difference. unknown 2 screenshots
|
Collaborator
📊 Bundle size reportUnchanged fixtures
|
smhigley
reviewed
Nov 30, 2022
| A menu displays a list of actions. The Menu component handles the | ||
| state management of the passed in list of actions. | ||
|
|
||
| See also <a href="#" data-sb-kind="components-button-menubutton--default">MenuButton</a> |
Contributor
There was a problem hiding this comment.
This approach still breaks copying link URLs to share or open somewhere else, and also opening links in a new tab. That's not much worse than what we currently have (only worse in the sense that at least the current approach lets you copy the ?path=etc params), but it'd be nice to use something that supports actual link functionality.
Contributor
There was a problem hiding this comment.
Other than that, I like this better than our current approach 😊
Collaborator
🕵 fluentuiv9 Open the Visual Regressions report to inspect the 1 screenshots✅ There was 0 screenshots added, 0 screenshots removed, 1753 screenshots unchanged, 0 screenshots with different dimensions and 1 screenshots with visible difference. unknown 1 screenshots
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 1210 | 1149 | 5000 | |
| Breadcrumb | mount | 2983 | 2954 | 1000 | |
| Checkbox | mount | 2571 | 2533 | 5000 | |
| CheckboxBase | mount | 2378 | 2287 | 5000 | |
| ChoiceGroup | mount | 4529 | 4518 | 5000 | |
| ComboBox | mount | 1162 | 1288 | 1000 | |
| CommandBar | mount | 9494 | 9290 | 1000 | |
| ContextualMenu | mount | 11556 | 11495 | 1000 | |
| DefaultButton | mount | 1328 | 1393 | 5000 | |
| DetailsRow | mount | 3549 | 3555 | 5000 | |
| DetailsRowFast | mount | 3600 | 3573 | 5000 | |
| DetailsRowNoStyles | mount | 3459 | 3495 | 5000 | |
| Dialog | mount | 3193 | 3231 | 1000 | |
| DocumentCardTitle | mount | 581 | 599 | 1000 | |
| Dropdown | mount | 3165 | 3212 | 5000 | |
| FocusTrapZone | mount | 2053 | 2063 | 5000 | |
| FocusZone | mount | 1888 | 1770 | 5000 | |
| GroupedList | mount | 1823 | 2066 | 2 | |
| GroupedList | virtual-rerender | 1158 | 1142 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 1686 | 1710 | 2 | |
| GroupedListV2 | mount | 586 | 565 | 2 | |
| GroupedListV2 | virtual-rerender | 536 | 565 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 556 | 555 | 2 | |
| IconButton | mount | 1971 | 1906 | 5000 | |
| Label | mount | 732 | 739 | 5000 | |
| Layer | mount | 4190 | 4304 | 5000 | |
| Link | mount | 850 | 837 | 5000 | |
| MenuButton | mount | 1743 | 1709 | 5000 | |
| MessageBar | mount | 2333 | 2322 | 5000 | |
| Nav | mount | 3260 | 3286 | 1000 | |
| OverflowSet | mount | 1392 | 1399 | 5000 | |
| Panel | mount | 2520 | 2516 | 1000 | |
| Persona | mount | 1274 | 1305 | 1000 | |
| Pivot | mount | 1638 | 1643 | 1000 | |
| PrimaryButton | mount | 1496 | 1515 | 5000 | |
| Rating | mount | 6977 | 6726 | 5000 | |
| SearchBox | mount | 1327 | 1421 | 5000 | |
| Shimmer | mount | 2742 | 2658 | 5000 | |
| Slider | mount | 2076 | 2062 | 5000 | |
| SpinButton | mount | 4512 | 4626 | 5000 | |
| Spinner | mount | 778 | 791 | 5000 | |
| SplitButton | mount | 2915 | 2862 | 5000 | |
| Stack | mount | 829 | 871 | 5000 | |
| StackWithIntrinsicChildren | mount | 2505 | 2444 | 5000 | |
| StackWithTextChildren | mount | 4979 | 4798 | 5000 | |
| SwatchColorPicker | mount | 10051 | 10552 | 5000 | |
| TagPicker | mount | 2541 | 2647 | 5000 | |
| TeachingBubble | mount | 89401 | 89998 | 5000 | |
| Text | mount | 771 | 706 | 5000 | |
| TextField | mount | 1460 | 1634 | 5000 | |
| ThemeProvider | mount | 1568 | 1465 | 5000 | |
| ThemeProvider | virtual-rerender | 1021 | 1045 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 2143 | 2161 | 5000 | |
| Toggle | mount | 1068 | 1141 | 5000 | |
| buttonNative | mount | 542 | 569 | 5000 |
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Dec 2, 2022
* master: fix: Pressed and Hover states for toolbar buttons (microsoft#25835) feat: add large size for toolbar (microsoft#25830) applying package updates adding perf test for Persona (microsoft#25863) fix: Fixing Slider's programmatic focus (microsoft#25869) chore(v0 docs): Add storybook stories that reference docsite examples for 1JS VR tool migration (microsoft#25663) fix: Respecting user-provided ids in ComboBox options (microsoft#25867) refactor(scripts): more domain boundaries encapsulation (microsoft#25851) docs: add documentation about how to migrate V0 createSvgIcon (microsoft#25828) support cross story linking and create example in Menu story (microsoft#25850)
Hotell
pushed a commit
to Hotell/fluentui
that referenced
this pull request
Feb 9, 2023
…ft#25850) * support cross story linking and create example in Menu story * change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since URLs are hosted inside of an iframe, any anchor tag is going to be relative to that iframe...just doesn't work.
with addon-links, and the decorator, we can use link in markdown, or in examples via buttons or anchor tags.
https://storybook.js.org/addons/@storybook/addon-links