feat: add large size for toolbar#25830
Conversation
…eat/support-large-size
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: a847f4059f4863a8d707f253b4a82f75855a3a89 (build) |
📊 Bundle size reportUnchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b820278:
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Persona | mount | 512 | 2807 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1292 | 1283 | 5000 | |
| Button | mount | 935 | 906 | 5000 | |
| FluentProvider | mount | 1487 | 1479 | 5000 | |
| FluentProviderWithTheme | mount | 574 | 588 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 543 | 543 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 571 | 581 | 10 | |
| MakeStyles | mount | 1996 | 1960 | 50000 | |
| Persona | mount | 512 | 2807 | 5000 | Possible regression |
| SpinButton | mount | 2374 | 2384 | 5000 |
|
Let's update the VR test too to include it |
🕵 fluentuiv9 Open the Visual Regressions report to inspect the 3 screenshots✅ There was 3 screenshots added, 0 screenshots removed, 1745 screenshots unchanged, 6 screenshots with different dimensions and 0 screenshots with visible difference. unknown 3 screenshots
|
ling1726
left a comment
There was a problem hiding this comment.
Something is wrong here, according to the figma spec the size should only influence the container
However, I see that the button size is changing in this PR https://fluentuipr.z22.web.core.windows.net/pull/25830/public-docsite-v9/storybook/index.html?path=/docs/preview-components-toolbar--default#medium
|
There are still funny things happening with
Also might be useful to set a background colour on the toolbar in the stories so you can see that the size of the container changes |
|
@ling1726 Fixed |
* master: fix: Pressed and Hover states for toolbar buttons (microsoft#25835) feat: add large size for toolbar (microsoft#25830) applying package updates adding perf test for Persona (microsoft#25863) fix: Fixing Slider's programmatic focus (microsoft#25869) chore(v0 docs): Add storybook stories that reference docsite examples for 1JS VR tool migration (microsoft#25663) fix: Respecting user-provided ids in ComboBox options (microsoft#25867) refactor(scripts): more domain boundaries encapsulation (microsoft#25851) docs: add documentation about how to migrate V0 createSvgIcon (microsoft#25828) support cross story linking and create example in Menu story (microsoft#25850)
* feat: add large size for toolbar * chore: add change * chore: add api update * chore: add large to vr tests * fix: remove size being passed to Button * fix: align for flex toolbar container * chore: add borders to toolbar sizing stories * chore: fix height when vertical
Overview
Fixes: #25800
Fixes: #25801
Add support for
Largein the toolbar, add the example for it and also adding explicit example forMedium.