chore(react-field): migrate to new package structure by TristanWatanabe · Pull Request #25817 · microsoft/fluentui

TristanWatanabe · 2022-11-28T21:28:35Z

Changes:

Runs migrate-converged-pkg which reflects updates made in chore(migrate-converged): add functionality to execute various v9 package file restructuring tasks #24458.
- Moves stories to stories/ folder in the root of the package.
- Collocates any e2e tests with the component implementation and jest tests.
- removes common/ folder and moves contents to new testing/ folder
- adds docs/ folder to package root.

Issue:

Part of Defined standard for v9 package file organization #24129

TristanWatanabe · 2022-11-28T21:29:32Z

packages/react-components/react-field/.storybook/main.js

-  stories: [
-    ...rootMain.stories,
-    '../src/**/*.stories.mdx',
-    '../src/stories/Field/index.stories.@(ts|tsx)',


This line is no longer necessary since all other Field component stories are no longer part of this package - https://github.com/microsoft/fluentui/pull/24426/files#r962066436

size-auditor · 2022-11-28T21:41:58Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 5b183163c77ca9cdba1c67185139479530f7a5b6 (build)

fabricteam · 2022-11-28T21:43:20Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`react-combobox` Combobox (including child components)	`78.244 kB` `25.015 kB`
`react-combobox` Dropdown (including child components)	`77.531 kB` `24.927 kB`
`react-components` react-components: Button, FluentProvider & webLightTheme	`62.975 kB` `17.687 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`190.411 kB` `53.077 kB`
`react-components` react-components: FluentProvider & webLightTheme	`33.48 kB` `11.037 kB`
`react-input` Input	`24.194 kB` `7.89 kB`
`react-portal-compat` PortalCompatProvider	`5.857 kB` `1.978 kB`
`react-progress` Progress	`13.536 kB` `5.107 kB`
`react-radio` Radio	`36.446 kB` `12.123 kB`
`react-radio` RadioGroup	`14.304 kB` `5.72 kB`
`react-select` Select	`23.474 kB` `8.017 kB`
`react-slider` Slider	`32.118 kB` `10.192 kB`
`react-spinbutton` SpinButton	`44.502 kB` `12.812 kB`
`react-switch` Switch	`33.453 kB` `10.581 kB`
`react-textarea` Textarea	`25.733 kB` `8.328 kB`

_{🤖 This report was generated against a002e76a91b5c53844ea69d7b7eb63be5ad48f82}

codesandbox-ci · 2022-11-28T21:43:41Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 57ad0ee:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

fabricteam · 2022-11-28T21:44:41Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	1591	1588	5000
Button	mount	1132	1117	5000
FluentProvider	mount	1915	1926	5000
FluentProviderWithTheme	mount	783	753	10
FluentProviderWithTheme	virtual-rerender	718	717	10
FluentProviderWithTheme	virtual-rerender-with-unmount	780	743	10
MakeStyles	mount	2311	2279	50000
SpinButton	mount	3098	3063	5000

fabricteam · 2022-11-28T21:54:38Z

🕵 fluentuiv9 Open the Visual Regressions report to inspect the 2 screenshots

✅ There was 0 screenshots added, 0 screenshots removed, 1749 screenshots unchanged, 0 screenshots with different dimensions and 2 screenshots with visible difference.

unknown 2 screenshots

Image Name	Diff(in Pixels)	Image Type
Avatar Converged.size+active+badge.normal.chromium.png	6	Changed
Avatar Converged.size+active+ring-shadow.normal.chromium.png	8	Changed

* master: (34 commits) chore(react-tooltip): migrate to new package structure (microsoft#25818) chore(react-field): migrate to new package structure (microsoft#25817) Update vr screenshotdiff lib to accept vr host url as param (microsoft#25772) feat(scripts): enable strict checking for additional sub-folders(packages) v4 (microsoft#25710) fix(tools): bump norhtstar packages v9 deps on dep mismatch resolution (microsoft#25806) feat: remove react-storybook and replace its functionality via standard react-storybook-addon package (microsoft#25786) applying package updates chore(react-spinbutton): migrate to new package structure (microsoft#25813) chore(react-spinner): migrate to new package structure (microsoft#25814) chore(react-provider): migrate to new package structure (microsoft#25809) chore(react-radio, shared-contexts): migrate to new package structure (microsoft#25810) chore(react-theme): migrate to new package structure (microsoft#25812) docs: add Fluent UI Insights EP04 to README (microsoft#25775) chore(react-migration-v8-v9): use same build process/setup as v9/ts-solution packages (microsoft#25679) docs: Improves `Table` documentation (microsoft#25787) feat: improve react-18 tests (microsoft#25758) docs: Add examples for DataGrid (microsoft#25783) chore(react-tree): scaffold TreeItemLayout (microsoft#25781) perf: make ts-minbar test compilation faster and asset preparation simpler (microsoft#25754) chore: creates TreeItem and basic Tree (microsoft#25742) ...

…ft#25817)" This reverts commit 0d473c1.

* chore(react-field): migrate to new package structure (#25817) * fixed alert styling * yarn change * Revert "chore(react-field): migrate to new package structure (#25817)" This reverts commit 0d473c1. * ui fixes * update tokens * using px instead of rem * Update packages/react-components/react-alert/src/components/Alert/useAlertStyles.ts Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update change/@fluentui-react-alert-8a5ecb73-4cf7-422d-9df6-e2c5d0cacffd.json Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * tabster * update changelog to follow changelog guidelines Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>

* chore(react-field): migrate to new package structure (microsoft#25817) * fixed alert styling * yarn change * Revert "chore(react-field): migrate to new package structure (microsoft#25817)" This reverts commit 0d473c1. * ui fixes * update tokens * using px instead of rem * Update packages/react-components/react-alert/src/components/Alert/useAlertStyles.ts Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update change/@fluentui-react-alert-8a5ecb73-4cf7-422d-9df6-e2c5d0cacffd.json Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * tabster * update changelog to follow changelog guidelines Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>

TristanWatanabe added 2 commits November 20, 2022 09:53

chore: run migration generator

aad73c9

Change File

57ad0ee

TristanWatanabe requested a review from a team as a code owner November 28, 2022 21:28

TristanWatanabe self-assigned this Nov 28, 2022

TristanWatanabe requested a review from behowell as a code owner November 28, 2022 21:28

github-actions bot added this to the October Project Cycle Q4 2022 milestone Nov 28, 2022

TristanWatanabe commented Nov 28, 2022

View reviewed changes

TristanWatanabe mentioned this pull request Nov 28, 2022

Defined standard for v9 package file organization #24129

Closed

59 tasks

khmakoto approved these changes Nov 28, 2022

View reviewed changes

TristanWatanabe merged commit 8869076 into microsoft:master Nov 29, 2022

marigome-msft added a commit to marigome-msft/fluentui that referenced this pull request Nov 30, 2022

chore(react-field): migrate to new package structure (microsoft#25817)

0d473c1

marigome-msft added a commit to marigome-msft/fluentui that referenced this pull request Dec 1, 2022

Revert "chore(react-field): migrate to new package structure (microso…

0d67b51

…ft#25817)" This reverts commit 0d473c1.

marigome-msft added a commit to marigome-msft/fluentui that referenced this pull request Dec 8, 2022

chore(react-field): migrate to new package structure (microsoft#25817)

aa5a739

marigome-msft added a commit to marigome-msft/fluentui that referenced this pull request Dec 8, 2022

Revert "chore(react-field): migrate to new package structure (microso…

5c2729d

…ft#25817)" This reverts commit 0d473c1.

Hotell pushed a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023

chore(react-field): migrate to new package structure (microsoft#25817)

b2c6822

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(react-field): migrate to new package structure#25817

chore(react-field): migrate to new package structure#25817
TristanWatanabe merged 2 commits intomicrosoft:masterfrom
TristanWatanabe:migrate-field

TristanWatanabe commented Nov 28, 2022

Uh oh!

TristanWatanabe Nov 28, 2022 •

edited

Loading

Uh oh!

size-auditor bot commented Nov 28, 2022

Uh oh!

fabricteam commented Nov 28, 2022

Uh oh!

codesandbox-ci bot commented Nov 28, 2022

Uh oh!

fabricteam commented Nov 28, 2022

Uh oh!

fabricteam commented Nov 28, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

TristanWatanabe commented Nov 28, 2022

Changes:

Issue:

Uh oh!

TristanWatanabe Nov 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

size-auditor bot commented Nov 28, 2022

Asset size changes

Uh oh!

fabricteam commented Nov 28, 2022

📊 Bundle size report

Uh oh!

codesandbox-ci bot commented Nov 28, 2022

Uh oh!

fabricteam commented Nov 28, 2022

Perf Analysis (@fluentui/react-components)

Uh oh!

fabricteam commented Nov 28, 2022

🕵 fluentuiv9 Open the Visual Regressions report to inspect the 2 screenshots

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

TristanWatanabe Nov 28, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)