feat(scripts): enable strict checking for additional sub-folders(packages) v4 by Hotell · Pull Request #25710 · microsoft/fluentui

Hotell · 2022-11-18T12:23:31Z

Description

obsolete code deleted
strict type checking enabled
new sub-packages created and files moved accordingly
- /package-manager
- /generators
- /executors
- /utils

Related Issue(s)

Fixes partially feat: make backbone of our tooling compliant with package standards (packaging /scripts) #24349

…e under generator/ boundary

…those under package-manager/ boundary

fabricteam · 2022-11-18T12:29:25Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`533 B` `341 B`
`global-context` createContextSelector	`554 B` `348 B`
`priority-overflow` createOverflowManager	`3.153 kB` `1.299 kB`
`react-accordion` Accordion (including children components)	`79.294 kB` `24.443 kB`
`react-alert` Alert	`86.891 kB` `21.708 kB`
`react-avatar` Avatar	`51.076 kB` `14.285 kB`
`react-avatar` AvatarGroup	`15.006 kB` `6.009 kB`
`react-avatar` AvatarGroupItem	`65.654 kB` `18.382 kB`
`react-badge` Badge	`23.357 kB` `7.361 kB`
`react-badge` CounterBadge	`24.247 kB` `7.643 kB`
`react-badge` PresenceBadge	`24.001 kB` `7.049 kB`
`react-button` Button	`36.86 kB` `9.913 kB`
`react-button` CompoundButton	`43.885 kB` `11.131 kB`
`react-button` MenuButton	`41.537 kB` `11.187 kB`
`react-button` SplitButton	`48.983 kB` `12.588 kB`
`react-button` ToggleButton	`52.685 kB` `11.415 kB`
`react-card` Card - All	`71.873 kB` `20.936 kB`
`react-card` Card	`67.651 kB` `19.892 kB`
`react-card` CardFooter	`8.617 kB` `3.62 kB`
`react-card` CardHeader	`9.792 kB` `3.995 kB`
`react-card` CardPreview	`8.718 kB` `3.674 kB`
`react-combobox` Combobox (including child components)	`78.086 kB` `24.988 kB`
`react-combobox` Dropdown (including child components)	`77.373 kB` `24.891 kB`
`react-components` react-components: Button, FluentProvider & webLightTheme	`62.975 kB` `17.687 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`190.427 kB` `53.087 kB`
`react-components` react-components: FluentProvider & webLightTheme	`33.48 kB` `11.037 kB`
`react-dialog` Dialog (including children components)	`83.036 kB` `24.754 kB`
`react-divider` Divider	`16.515 kB` `5.921 kB`
`react-image` Image	`10.836 kB` `4.283 kB`
`react-infobutton` InfoButton	`117.938 kB` `35.399 kB`
`react-input` Input	`24.122 kB` `7.889 kB`
`react-label` Label	`9.394 kB` `3.88 kB`
`react-link` Link	`11.862 kB` `4.885 kB`
`react-menu` Menu (including children components)	`117.61 kB` `36.287 kB`
`react-menu` Menu (including selectable components)	`120.679 kB` `36.82 kB`
`react-overflow` hooks only	`11.004 kB` `4.188 kB`
`react-persona` Persona	`57.131 kB` `15.951 kB`
`react-popover` Popover	`103.682 kB` `31.867 kB`
`react-portal` Portal	`10.495 kB` `3.851 kB`
`react-portal-compat` PortalCompatProvider	`5.857 kB` `1.978 kB`
`react-positioning` usePositioning	`19.826 kB` `7.417 kB`
`react-progress` Progress	`13.536 kB` `5.107 kB`
`react-provider` FluentProvider	`15.817 kB` `5.905 kB`
`react-radio` Radio	`36.446 kB` `12.123 kB`
`react-radio` RadioGroup	`14.304 kB` `5.72 kB`
`react-select` Select	`23.438 kB` `8.018 kB`
`react-slider` Slider	`32.118 kB` `10.192 kB`
`react-spinbutton` SpinButton	`44.43 kB` `12.812 kB`
`react-spinner` Spinner	`20.013 kB` `6.446 kB`
`react-switch` Switch	`33.453 kB` `10.581 kB`
`react-text` Text - Default	`11.838 kB` `4.625 kB`
`react-text` Text - Wrappers	`15.148 kB` `5.06 kB`
`react-textarea` Textarea	`25.697 kB` `8.328 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`29.722 kB` `6.462 kB`
`react-theme` Teams: Light theme	`17.51 kB` `5.075 kB`
`react-tooltip` Tooltip	`42.032 kB` `14.739 kB`
`react-utilities` SSRProvider	`180 B` `159 B`

_{🤖 This report was generated against 13271460c38e2e38244c9b5a4cb713159570874d}

Hotell · 2022-11-18T12:27:53Z

scripts/generators/create-package/index.ts

 import { spawnSync } from 'child_process';
 import { WorkspaceJsonConfiguration } from '@nrwl/devkit';
-import { findGitRoot, PackageJson } from '../monorepo/index';
+


fixed type errors and normalized name to follow our nx generarators -> index.ts as root

Hotell · 2022-11-18T12:28:09Z

scripts/generators/create-component/index.ts

@@ -6,10 +6,11 @@ import * as fs from 'fs-extra';
 import * as os from 'os';
 import * as path from 'path';
 import { execSync } from 'child_process';
-import { findGitRoot, getAllPackageInfo, isConvergedPackage } from '../monorepo/index';


fixed type errors and normalized name to follow our nx generarators -> index.ts as root

Hotell · 2022-11-18T12:29:27Z

scripts/executors/invalidate-just-cache.js

@@ -0,0 +1,9 @@
+const fs = require('fs');


removed fs-extra as fs is enables same behaviours

this was moved rather than created. whats wrong with you git ? :D

Hotell · 2022-11-18T12:30:00Z

scripts/config/jest/flamegrillReporter.js

@@ -1,65 +0,0 @@
-const chokidar = require('chokidar');


removed - unused

Hotell · 2022-11-18T12:30:07Z

scripts/convert-change-files.js

@@ -1,74 +0,0 @@
-const fs = require('fs-extra');


removed - unused

fabricteam · 2022-11-18T12:49:15Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	1336	1251	5000
Button	mount	905	921	5000
FluentProvider	mount	1483	1423	5000
FluentProviderWithTheme	mount	599	637	10
FluentProviderWithTheme	virtual-rerender	539	520	10
FluentProviderWithTheme	virtual-rerender-with-unmount	555	559	10
MakeStyles	mount	1739	1778	50000
SpinButton	mount	2305	2395	5000

codesandbox-ci · 2022-11-18T12:50:50Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 13bba00:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

fabricteam · 2022-11-18T12:54:20Z

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
LayoutMinimalPerf.default	324	310	1.05:1
IconMinimalPerf.default	565	538	1.05:1
DividerMinimalPerf.default	315	303	1.04:1
RefMinimalPerf.default	187	179	1.04:1
TextAreaMinimalPerf.default	407	391	1.04:1
AvatarMinimalPerf.default	162	157	1.03:1
CarouselMinimalPerf.default	357	348	1.03:1
FlexMinimalPerf.default	255	247	1.03:1
ListNestedPerf.default	483	471	1.03:1
SegmentMinimalPerf.default	307	299	1.03:1
AnimationMinimalPerf.default	468	459	1.02:1
AttachmentMinimalPerf.default	123	121	1.02:1
ChatDuplicateMessagesPerf.default	216	212	1.02:1
LoaderMinimalPerf.default	266	262	1.02:1
ProviderMinimalPerf.default	322	317	1.02:1
ReactionMinimalPerf.default	332	326	1.02:1
StatusMinimalPerf.default	604	595	1.02:1
TooltipMinimalPerf.default	1881	1850	1.02:1
AttachmentSlotsPerf.default	892	879	1.01:1
BoxMinimalPerf.default	291	289	1.01:1
ButtonOverridesMissPerf.default	1025	1014	1.01:1
ButtonSlotsPerf.default	423	418	1.01:1
CardMinimalPerf.default	468	462	1.01:1
ChatMinimalPerf.default	639	633	1.01:1
DropdownManyItemsPerf.default	537	534	1.01:1
DropdownMinimalPerf.default	2164	2144	1.01:1
GridMinimalPerf.default	293	290	1.01:1
ItemLayoutMinimalPerf.default	977	966	1.01:1
ListWith60ListItems.default	495	489	1.01:1
MenuMinimalPerf.default	729	723	1.01:1
MenuButtonMinimalPerf.default	1364	1344	1.01:1
RosterPerf.default	1705	1695	1.01:1
PopupMinimalPerf.default	555	549	1.01:1
PortalMinimalPerf.default	138	136	1.01:1
SkeletonMinimalPerf.default	299	295	1.01:1
SplitButtonMinimalPerf.default	3297	3265	1.01:1
TableMinimalPerf.default	356	354	1.01:1
CustomToolbarPrototype.default	2170	2150	1.01:1
ToolbarMinimalPerf.default	801	795	1.01:1
AlertMinimalPerf.default	224	225	1:1
DatepickerMinimalPerf.default	4633	4620	1:1
EmbedMinimalPerf.default	2635	2646	1:1
HeaderMinimalPerf.default	319	318	1:1
HeaderSlotsPerf.default	682	681	1:1
ImageMinimalPerf.default	341	340	1:1
LabelMinimalPerf.default	340	340	1:1
ListCommonPerf.default	511	512	1:1
SliderMinimalPerf.default	1227	1223	1:1
TableManyItemsPerf.default	1573	1566	1:1
TreeMinimalPerf.default	699	699	1:1
CheckboxMinimalPerf.default	1513	1525	0.99:1
DialogMinimalPerf.default	682	687	0.99:1
FormMinimalPerf.default	324	327	0.99:1
InputMinimalPerf.default	850	856	0.99:1
ListMinimalPerf.default	450	455	0.99:1
ProviderMergeThemesPerf.default	986	991	0.99:1
RadioGroupMinimalPerf.default	384	386	0.99:1
TextMinimalPerf.default	295	300	0.98:1
ChatWithPopoverPerf.default	284	292	0.97:1
VideoMinimalPerf.default	609	626	0.97:1
ButtonMinimalPerf.default	131	136	0.96:1
AccordionMinimalPerf.default	115	123	0.93:1
TreeWith60ListItems.default	121	132	0.92:1

fabricteam · 2022-11-18T12:56:13Z

🕵 fluentuiv8 Open the Visual Regressions report to inspect the 2 screenshots

✅ There was 2 screenshots added, 0 screenshots removed, 1037 screenshots unchanged, 0 screenshots with different dimensions and 0 screenshots with visible difference.

unknown 2 screenshots

Image Name	Diff(in Pixels)	Image Type
Pivot - Overflow.Root.Narrow - Last tab selected.chromium.png	0	Added
Pivot - Overflow.Root.Narrow - Overflow menu.chromium.png	0	Added

fabricteam · 2022-11-18T12:58:39Z

🕵 fluentuiv9 Open the Visual Regressions report to inspect the 2 screenshots

✅ There was 0 screenshots added, 0 screenshots removed, 1749 screenshots unchanged, 0 screenshots with different dimensions and 2 screenshots with visible difference.

unknown 2 screenshots

Image Name	Diff(in Pixels)	Image Type
Avatar Converged.size+active+badge.normal.chromium.png	11	Changed
Avatar Converged.size+active+ring-shadow.normal.chromium.png	9	Changed

fabricteam · 2022-11-18T13:05:48Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	1205	1198	5000
Breadcrumb	mount	2810	2773	1000
Checkbox	mount	2611	2619	5000
CheckboxBase	mount	2369	2384	5000
ChoiceGroup	mount	4250	4285	5000
ComboBox	mount	1174	1148	1000
CommandBar	mount	9258	9225	1000
ContextualMenu	mount	10175	10099	1000
DefaultButton	mount	1372	1370	5000
DetailsRow	mount	3377	3332	5000
DetailsRowFast	mount	3382	3381	5000
DetailsRowNoStyles	mount	3224	3239	5000
Dialog	mount	2992	2984	1000
DocumentCardTitle	mount	586	585	1000
Dropdown	mount	3175	3148	5000
FocusTrapZone	mount	1970	1953	5000
FocusZone	mount	1933	1963	5000
GroupedList	mount	1848	2058	2
GroupedList	virtual-rerender	1102	1089	2
GroupedList	virtual-rerender-with-unmount	1603	1618	2
GroupedListV2	mount	575	553	2
GroupedListV2	virtual-rerender	547	553	2
GroupedListV2	virtual-rerender-with-unmount	559	568	2
IconButton	mount	1778	1815	5000
Label	mount	751	756	5000
Layer	mount	4199	4206	5000
Link	mount	858	844	5000
MenuButton	mount	1614	1623	5000
MessageBar	mount	2311	2379	5000
Nav	mount	3037	3057	1000
OverflowSet	mount	1419	1401	5000
Panel	mount	2490	2494	1000
Persona	mount	1253	1257	1000
Pivot	mount	1525	1518	1000
PrimaryButton	mount	1482	1497	5000
Rating	mount	6906	6930	5000
SearchBox	mount	1532	1512	5000
Shimmer	mount	2949	2915	5000
Slider	mount	2124	2118	5000
SpinButton	mount	4263	4275	5000
Spinner	mount	831	880	5000
SplitButton	mount	2801	2845	5000
Stack	mount	865	871	5000
StackWithIntrinsicChildren	mount	2357	2332	5000
StackWithTextChildren	mount	5010	5040	5000
SwatchColorPicker	mount	10355	9506	5000
TagPicker	mount	2338	2337	5000
TeachingBubble	mount	75786	76250	5000
Text	mount	814	818	5000
TextField	mount	1566	1538	5000
ThemeProvider	mount	1448	1430	5000
ThemeProvider	virtual-rerender	1156	1149	5000
ThemeProvider	virtual-rerender-with-unmount	1998	2022	5000
Toggle	mount	1132	1156	5000
buttonNative	mount	556	540	5000

size-auditor · 2022-11-18T13:35:05Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 13271460c38e2e38244c9b5a4cb713159570874d (build)

* master: (34 commits) chore(react-tooltip): migrate to new package structure (microsoft#25818) chore(react-field): migrate to new package structure (microsoft#25817) Update vr screenshotdiff lib to accept vr host url as param (microsoft#25772) feat(scripts): enable strict checking for additional sub-folders(packages) v4 (microsoft#25710) fix(tools): bump norhtstar packages v9 deps on dep mismatch resolution (microsoft#25806) feat: remove react-storybook and replace its functionality via standard react-storybook-addon package (microsoft#25786) applying package updates chore(react-spinbutton): migrate to new package structure (microsoft#25813) chore(react-spinner): migrate to new package structure (microsoft#25814) chore(react-provider): migrate to new package structure (microsoft#25809) chore(react-radio, shared-contexts): migrate to new package structure (microsoft#25810) chore(react-theme): migrate to new package structure (microsoft#25812) docs: add Fluent UI Insights EP04 to README (microsoft#25775) chore(react-migration-v8-v9): use same build process/setup as v9/ts-solution packages (microsoft#25679) docs: Improves `Table` documentation (microsoft#25787) feat: improve react-18 tests (microsoft#25758) docs: Add examples for DataGrid (microsoft#25783) chore(react-tree): scaffold TreeItemLayout (microsoft#25781) perf: make ts-minbar test compilation faster and asset preparation simpler (microsoft#25754) chore: creates TreeItem and basic Tree (microsoft#25742) ...

…ages) v4 (microsoft#25710) * feat(scripts): enable strict checking for create-* and normalize those under generator/ boundary * feat(scripts): enable strict checking for install hoos and normalize those under package-manager/ boundary * feat(scripts): remove unused config/ folder * feat(scripts): create utils/ subpackage with strict type checking * feat(scripts): move generators related modules under generators/ * chore(scripts): remove obsolete functionality/modules * feat(scripts): move execution related modules under executors/ * generate changefiles

Hotell added 3 commits November 18, 2022 13:22

feat(scripts): enable strict checking for create-* and normalize thos…

218cbe9

…e under generator/ boundary

feat(scripts): enable strict checking for install hoos and normalize …

1672b3b

…those under package-manager/ boundary

feat(scripts): remove unused config/ folder

5c97a75

msft-fluent-ui-bot assigned ling1726 Nov 18, 2022

github-actions bot added this to the October Project Cycle Q4 2022 milestone Nov 18, 2022

Hotell changed the title ~~feat(scripts): enable strict checking for additional sub-folders(packages) v3~~ feat(scripts): enable strict checking for additional sub-folders(packages) v4 Nov 18, 2022

Hotell commented Nov 18, 2022

View reviewed changes

Hotell mentioned this pull request Nov 18, 2022

feat: make backbone of our tooling compliant with package standards (packaging /scripts) #24349

Closed

18 tasks

Hotell removed this from the October Project Cycle Q4 2022 milestone Nov 18, 2022

Hotell unassigned ling1726 Nov 18, 2022

Hotell added the Area: Build System label Nov 18, 2022

github-actions bot added this to the October Project Cycle Q4 2022 milestone Nov 18, 2022

feat(scripts): create utils/ subpackage with strict type checking

cd6f816

Hotell force-pushed the hotell/build/scripts/ts-solution-config-v4 branch from b1e1dff to 51a9967 Compare November 18, 2022 13:07

Hotell marked this pull request as ready for review November 18, 2022 14:13

Hotell requested review from a team as code owners November 18, 2022 14:13

Hotell removed this from the October Project Cycle Q4 2022 milestone Nov 21, 2022

Hotell added 2 commits November 21, 2022 15:55

feat(scripts): move generators related modules under generators/

bd1f714

chore(scripts): remove obsolete functionality/modules

55460d0

Hotell added 2 commits November 21, 2022 15:55

feat(scripts): move execution related modules under executors/

0dbdde3

generate changefiles

13bba00

Hotell force-pushed the hotell/build/scripts/ts-solution-config-v4 branch from 7d41cd7 to 13bba00 Compare November 21, 2022 14:55

github-actions bot added this to the October Project Cycle Q4 2022 milestone Nov 21, 2022

Hotell mentioned this pull request Nov 21, 2022

refactor(scripts): encapsulate v0 and v8 tooling within its domain boundaries #25738

Merged

1 task

layershifter approved these changes Nov 22, 2022

View reviewed changes

ling1726 approved these changes Nov 22, 2022

View reviewed changes

Hotell removed this from the October Project Cycle Q4 2022 milestone Nov 28, 2022

spmonahan approved these changes Nov 28, 2022

View reviewed changes

TristanWatanabe approved these changes Nov 28, 2022

View reviewed changes

Hotell merged commit a1ed5fe into microsoft:master Nov 29, 2022

Hotell deleted the hotell/build/scripts/ts-solution-config-v4 branch November 29, 2022 11:08

Conversation

Hotell commented Nov 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue(s)

Uh oh!

fabricteam commented Nov 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fabricteam commented Nov 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codesandbox-ci bot commented Nov 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fabricteam commented Nov 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-northstar)

Uh oh!

fabricteam commented Nov 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fabricteam commented Nov 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fabricteam commented Nov 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

size-auditor bot commented Nov 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Asset size changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Hotell commented Nov 18, 2022 •

edited

Loading

fabricteam commented Nov 18, 2022 •

edited

Loading

fabricteam commented Nov 18, 2022 •

edited

Loading

codesandbox-ci bot commented Nov 18, 2022 •

edited

Loading

fabricteam commented Nov 18, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-northstar`)

fabricteam commented Nov 18, 2022 •

edited

Loading

fabricteam commented Nov 18, 2022 •

edited

Loading

fabricteam commented Nov 18, 2022 •

edited

Loading

size-auditor bot commented Nov 18, 2022 •

edited

Loading