perf: make ts-minbar test compilation faster and asset preparation simpler#25754
Merged
Hotell merged 3 commits intomicrosoft:masterfrom Nov 24, 2022
Merged
perf: make ts-minbar test compilation faster and asset preparation simpler#25754Hotell merged 3 commits intomicrosoft:masterfrom
Hotell merged 3 commits intomicrosoft:masterfrom
Conversation
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1593 | 1523 | 5000 | |
| Button | mount | 1130 | 1111 | 5000 | |
| FluentProvider | mount | 1880 | 1881 | 5000 | |
| FluentProviderWithTheme | mount | 750 | 753 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 702 | 721 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 751 | 752 | 10 | |
| MakeStyles | mount | 2277 | 2275 | 50000 | |
| SpinButton | mount | 2982 | 3007 | 5000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 8fcefaeacac2e2cc2cd7ca5b76c1ca5e7e547682 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 48c7d69:
|
Collaborator
🕵 fluentuiv8 Open the Visual Regressions report to inspect the 2 screenshots✅ There was 2 screenshots added, 0 screenshots removed, 1037 screenshots unchanged, 0 screenshots with different dimensions and 0 screenshots with visible difference. unknown 2 screenshots
|
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AttachmentMinimalPerf.default | 164 | 143 | 1.15:1 |
| AnimationMinimalPerf.default | 585 | 531 | 1.1:1 |
| CarouselMinimalPerf.default | 513 | 473 | 1.08:1 |
| ListNestedPerf.default | 598 | 556 | 1.08:1 |
| BoxMinimalPerf.default | 352 | 328 | 1.07:1 |
| ChatDuplicateMessagesPerf.default | 300 | 281 | 1.07:1 |
| ListWith60ListItems.default | 673 | 630 | 1.07:1 |
| AccordionMinimalPerf.default | 153 | 145 | 1.06:1 |
| FormMinimalPerf.default | 392 | 371 | 1.06:1 |
| LoaderMinimalPerf.default | 345 | 326 | 1.06:1 |
| MenuMinimalPerf.default | 900 | 849 | 1.06:1 |
| TextAreaMinimalPerf.default | 496 | 470 | 1.06:1 |
| RefMinimalPerf.default | 223 | 212 | 1.05:1 |
| FlexMinimalPerf.default | 294 | 284 | 1.04:1 |
| LayoutMinimalPerf.default | 377 | 361 | 1.04:1 |
| ProviderMinimalPerf.default | 440 | 424 | 1.04:1 |
| RadioGroupMinimalPerf.default | 467 | 451 | 1.04:1 |
| StatusMinimalPerf.default | 708 | 681 | 1.04:1 |
| AttachmentSlotsPerf.default | 1146 | 1109 | 1.03:1 |
| HeaderMinimalPerf.default | 364 | 355 | 1.03:1 |
| PopupMinimalPerf.default | 664 | 643 | 1.03:1 |
| ReactionMinimalPerf.default | 380 | 370 | 1.03:1 |
| TableMinimalPerf.default | 425 | 411 | 1.03:1 |
| AlertMinimalPerf.default | 279 | 273 | 1.02:1 |
| ButtonMinimalPerf.default | 165 | 161 | 1.02:1 |
| ListCommonPerf.default | 648 | 634 | 1.02:1 |
| ListMinimalPerf.default | 525 | 514 | 1.02:1 |
| IconMinimalPerf.default | 698 | 684 | 1.02:1 |
| CustomToolbarPrototype.default | 2815 | 2761 | 1.02:1 |
| VideoMinimalPerf.default | 746 | 729 | 1.02:1 |
| ButtonOverridesMissPerf.default | 1379 | 1362 | 1.01:1 |
| CheckboxMinimalPerf.default | 2216 | 2185 | 1.01:1 |
| ImageMinimalPerf.default | 390 | 385 | 1.01:1 |
| MenuButtonMinimalPerf.default | 1776 | 1753 | 1.01:1 |
| ProviderMergeThemesPerf.default | 1348 | 1339 | 1.01:1 |
| SegmentMinimalPerf.default | 348 | 344 | 1.01:1 |
| SkeletonMinimalPerf.default | 346 | 344 | 1.01:1 |
| SliderMinimalPerf.default | 1674 | 1654 | 1.01:1 |
| TreeWith60ListItems.default | 161 | 160 | 1.01:1 |
| DatepickerMinimalPerf.default | 6029 | 6036 | 1:1 |
| DialogMinimalPerf.default | 810 | 806 | 1:1 |
| DropdownMinimalPerf.default | 2826 | 2814 | 1:1 |
| EmbedMinimalPerf.default | 3878 | 3895 | 1:1 |
| InputMinimalPerf.default | 1194 | 1196 | 1:1 |
| ItemLayoutMinimalPerf.default | 1238 | 1241 | 1:1 |
| RosterPerf.default | 2205 | 2216 | 1:1 |
| TableManyItemsPerf.default | 1888 | 1891 | 1:1 |
| TreeMinimalPerf.default | 849 | 845 | 1:1 |
| AvatarMinimalPerf.default | 195 | 197 | 0.99:1 |
| ChatMinimalPerf.default | 742 | 753 | 0.99:1 |
| DropdownManyItemsPerf.default | 697 | 701 | 0.99:1 |
| GridMinimalPerf.default | 336 | 339 | 0.99:1 |
| HeaderSlotsPerf.default | 789 | 797 | 0.99:1 |
| LabelMinimalPerf.default | 383 | 386 | 0.99:1 |
| SplitButtonMinimalPerf.default | 4513 | 4552 | 0.99:1 |
| TextMinimalPerf.default | 357 | 360 | 0.99:1 |
| TooltipMinimalPerf.default | 2462 | 2479 | 0.99:1 |
| ChatWithPopoverPerf.default | 379 | 386 | 0.98:1 |
| CardMinimalPerf.default | 544 | 564 | 0.96:1 |
| PortalMinimalPerf.default | 172 | 179 | 0.96:1 |
| ToolbarMinimalPerf.default | 915 | 976 | 0.94:1 |
| ButtonSlotsPerf.default | 546 | 587 | 0.93:1 |
| DividerMinimalPerf.default | 340 | 365 | 0.93:1 |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| GroupedList | mount | 2253 | 2824 | 2 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 1407 | 1387 | 5000 | |
| Breadcrumb | mount | 3481 | 3485 | 1000 | |
| Checkbox | mount | 3177 | 3188 | 5000 | |
| CheckboxBase | mount | 2777 | 2795 | 5000 | |
| ChoiceGroup | mount | 5288 | 5469 | 5000 | |
| ComboBox | mount | 1485 | 1465 | 1000 | |
| CommandBar | mount | 11425 | 11440 | 1000 | |
| ContextualMenu | mount | 12810 | 12864 | 1000 | |
| DefaultButton | mount | 1656 | 1622 | 5000 | |
| DetailsRow | mount | 4269 | 4229 | 5000 | |
| DetailsRowFast | mount | 4304 | 4264 | 5000 | |
| DetailsRowNoStyles | mount | 4101 | 4096 | 5000 | |
| Dialog | mount | 3649 | 3732 | 1000 | |
| DocumentCardTitle | mount | 678 | 681 | 1000 | |
| Dropdown | mount | 3844 | 3899 | 5000 | |
| FocusTrapZone | mount | 2408 | 2429 | 5000 | |
| FocusZone | mount | 2337 | 2327 | 5000 | |
| GroupedList | mount | 2253 | 2824 | 2 | Possible regression |
| GroupedList | virtual-rerender | 1382 | 1378 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 2070 | 2005 | 2 | |
| GroupedListV2 | mount | 683 | 694 | 2 | |
| GroupedListV2 | virtual-rerender | 656 | 655 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 661 | 700 | 2 | |
| IconButton | mount | 2299 | 2260 | 5000 | |
| Label | mount | 874 | 868 | 5000 | |
| Layer | mount | 5250 | 5184 | 5000 | |
| Link | mount | 998 | 980 | 5000 | |
| MenuButton | mount | 1958 | 2036 | 5000 | |
| MessageBar | mount | 2759 | 2758 | 5000 | |
| Nav | mount | 3891 | 3954 | 1000 | |
| OverflowSet | mount | 1623 | 1615 | 5000 | |
| Panel | mount | 3061 | 3092 | 1000 | |
| Persona | mount | 1519 | 1589 | 1000 | |
| Pivot | mount | 2026 | 2075 | 1000 | |
| PrimaryButton | mount | 1791 | 1826 | 5000 | |
| Rating | mount | 8368 | 8323 | 5000 | |
| SearchBox | mount | 1817 | 1846 | 5000 | |
| Shimmer | mount | 3303 | 3324 | 5000 | |
| Slider | mount | 2542 | 2436 | 5000 | |
| SpinButton | mount | 5595 | 5577 | 5000 | |
| Spinner | mount | 942 | 971 | 5000 | |
| SplitButton | mount | 3846 | 3647 | 5000 | |
| Stack | mount | 966 | 986 | 5000 | |
| StackWithIntrinsicChildren | mount | 2901 | 2942 | 5000 | |
| StackWithTextChildren | mount | 5869 | 5838 | 5000 | |
| SwatchColorPicker | mount | 12492 | 12677 | 5000 | |
| TagPicker | mount | 3290 | 3128 | 5000 | |
| TeachingBubble | mount | 98740 | 98461 | 5000 | |
| Text | mount | 972 | 968 | 5000 | |
| TextField | mount | 1978 | 1913 | 5000 | |
| ThemeProvider | mount | 1835 | 1810 | 5000 | |
| ThemeProvider | virtual-rerender | 1297 | 1310 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 2564 | 2613 | 5000 | |
| Toggle | mount | 1317 | 1339 | 5000 | |
| buttonNative | mount | 671 | 636 | 5000 |
Collaborator
🕵 fluentuiv9 Open the Visual Regressions report to inspect the 2 screenshots✅ There was 0 screenshots added, 0 screenshots removed, 1749 screenshots unchanged, 0 screenshots with different dimensions and 2 screenshots with visible difference. unknown 2 screenshots
|
tudorpopams
approved these changes
Nov 23, 2022
layershifter
approved these changes
Nov 23, 2022
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Nov 29, 2022
* master: (34 commits) chore(react-tooltip): migrate to new package structure (microsoft#25818) chore(react-field): migrate to new package structure (microsoft#25817) Update vr screenshotdiff lib to accept vr host url as param (microsoft#25772) feat(scripts): enable strict checking for additional sub-folders(packages) v4 (microsoft#25710) fix(tools): bump norhtstar packages v9 deps on dep mismatch resolution (microsoft#25806) feat: remove react-storybook and replace its functionality via standard react-storybook-addon package (microsoft#25786) applying package updates chore(react-spinbutton): migrate to new package structure (microsoft#25813) chore(react-spinner): migrate to new package structure (microsoft#25814) chore(react-provider): migrate to new package structure (microsoft#25809) chore(react-radio, shared-contexts): migrate to new package structure (microsoft#25810) chore(react-theme): migrate to new package structure (microsoft#25812) docs: add Fluent UI Insights EP04 to README (microsoft#25775) chore(react-migration-v8-v9): use same build process/setup as v9/ts-solution packages (microsoft#25679) docs: Improves `Table` documentation (microsoft#25787) feat: improve react-18 tests (microsoft#25758) docs: Add examples for DataGrid (microsoft#25783) chore(react-tree): scaffold TreeItemLayout (microsoft#25781) perf: make ts-minbar test compilation faster and asset preparation simpler (microsoft#25754) chore: creates TreeItem and basic Tree (microsoft#25742) ...
Hotell
added a commit
to Hotell/fluentui
that referenced
this pull request
Feb 9, 2023
…mpler (microsoft#25754) * feat(scripts): add generateFiles helper * perf: make ts-minbar test compilation faster and asset preparation simpler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
generateFilesthat is aligned with nx helper (alsoassets/has been renamed tofiles/to align with nx practices - not in v0 as more scaffolds are present there )type-checkandtest)Related Issue(s)