stress test: add "build-fixture" command#24928
Merged
spmonahan merged 1 commit intomicrosoft:masterfrom Sep 26, 2022
Merged
Conversation
Adds a command to build test fixtures, allowing for easy fixture generation should we want alternates to the defaults. Provides default fixture generation with two variants for t-shirt sizes xs, s, m, l, and xl. Default fixtures are generated when running commands that may rely on fixtures existing. This commit also reworks the `ts-node` implementation a bit. Now the CLI app is a pure ESM application. This is supported by Node 16 but required some changes. In particular: 1. No more `require()` calls. 2. Script imports must have an extension. This is why there are `import foo from 'foo.js'` imports now. This is required because `random-seedable`, the node module we use for randomness, is a pure ESM module and since we do not transpile node_modules the simplest thing to do was go all-in on ESM for the CLI.
Collaborator
📊 Bundle size report🤖 This report was generated against 53f71701af6d88abf66d0cb0a73543f97bd4da51 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 53f71701af6d88abf66d0cb0a73543f97bd4da51 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 586c358:
|
Merged
micahgodbolt
approved these changes
Sep 26, 2022
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Sep 28, 2022
* master: (21 commits) chore: Migrate react-avatar to use new build (microsoft#24969) applying package updates chore(react-input, react-textarea): Deprecating filled with shadow appearance variants (microsoft#24900) fix: v8 Dropdown no longer sets incorrect and unnecessary aria-activedescendant (microsoft#24593) feat: v0 Tooltip migration from v9 (microsoft#24908) chore: bump devDeps to fix critical security vulnerability (microsoft#24891) Fixing Tree chart issues (microsoft#24752) init: new package react-avatar-context (microsoft#24968) ci(.github): add issues write permisions to triage-bot worflow (microsoft#24963) applying package updates fix(Toolbar): close previous submenu when opening another submenu (microsoft#24836) fix: update non-focus-trap Popover role to be group (microsoft#24897) feat: Avatar's aria label includes 'active' or 'inactive' when using the active prop (microsoft#24901) feat(scripts): implement triage-bot module (microsoft#24911) chore: bump @octokit/rest to v18 (microsoft#24919) stress test: add "build-fixture" command (microsoft#24928) BREAKING-CHANGE: new ChatMessageContent for style caching (microsoft#24691) bugfix: fix changefile to properly update version of react-components with a patch (microsoft#24949) feat(scripts): enable strict checking for additional sub-folders(packages) (microsoft#24526) chore: exports DialogContent as unstable (microsoft#24943) ...
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
Adds a command to build test fixtures, allowing for easy fixture generation should we want alternates to the defaults. Provides default fixture generation with two variants for t-shirt sizes xs, s, m, l, and xl. Default fixtures are generated when running commands that may rely on fixtures existing. This commit also reworks the `ts-node` implementation a bit. Now the CLI app is a pure ESM application. This is supported by Node 16 but required some changes. In particular: 1. No more `require()` calls. 2. Script imports must have an extension. This is why there are `import foo from 'foo.js'` imports now. This is required because `random-seedable`, the node module we use for randomness, is a pure ESM module and since we do not transpile node_modules the simplest thing to do was go all-in on ESM for the CLI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
There is no convenient way to generate test fixtures.
New Behavior
Adds a command to build test fixtures, allowing for easy fixture generation should we want alternates to the defaults.
Provides default fixture generation with two variants for t-shirt sizes xs, s, m, l, and xl (i.e., "xs_1", "xs_2"). Default fixtures are generated when running commands that may rely on fixtures existing.
This commit also reworks the
ts-nodeimplementation a bit. Now the CLI app is a pure ESM application. This is supported by Node 16 but required some changes. In particular:require()calls.import foo from 'foo.js'imports now.This is required because
random-seedable, the node module we use for randomness, is a pure ESM module and since we do not transpile node_modules the simplest thing to do was go all-in on ESM for the CLI.