feat(scripts): implement triage-bot module by Hotell · Pull Request #24911 · microsoft/fluentui

Hotell · 2022-09-22T18:01:22Z

Current Behavior

we use existing github action which doesn't work and have very limited use case coverage

New Behavior

we have foundation for fully customized triage-bot functionalities
configuration provides best possible DX by leveraging json schema
~~bump to @octokit/rest v18 ( introduces lot of changes in type space - we can remove that part from this PR )~~ chore: bump @octokit/rest to v18 #24919

Learn more 💡

Related Issue(s)

Follows #24788
Implements #24817 (1. project label assignment)

codesandbox-ci · 2022-09-22T18:16:33Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a16631d:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

size-auditor · 2022-09-22T18:21:09Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: b415287e740508fbd3c64597bacc5efc6592c910 (build)

fabricteam · 2022-09-22T18:22:48Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	1175	1167	5000
Button	mount	935	924	5000
FluentProvider	mount	1496	1539	5000
FluentProviderWithTheme	mount	621	559	10
FluentProviderWithTheme	virtual-rerender	523	511	10
FluentProviderWithTheme	virtual-rerender-with-unmount	559	620	10
MakeStyles	mount	1717	1668	50000
SpinButton	mount	2245	2284	5000

fabricteam · 2022-09-22T18:25:10Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`533 B` `341 B`
`global-context` createContextSelector	`554 B` `348 B`
`priority-overflow` createOverflowManager	`2.936 kB` `1.212 kB`
`react-accordion` Accordion (including children components)	`78.914 kB` `24.06 kB`
`react-alert` Alert	`83.511 kB` `20.921 kB`
`react-avatar` Avatar	`48.381 kB` `13.696 kB`
`react-avatar` AvatarGroup	`14.95 kB` `5.989 kB`
`react-avatar` AvatarGroupItem	`68.349 kB` `19.039 kB`
`react-badge` Badge	`22.6 kB` `7.205 kB`
`react-badge` CounterBadge	`23.503 kB` `7.497 kB`
`react-badge` PresenceBadge	`24.05 kB` `7.067 kB`
`react-button` Button	`36.119 kB` `9.647 kB`
`react-button` CompoundButton	`43.144 kB` `10.86 kB`
`react-button` MenuButton	`38.813 kB` `10.551 kB`
`react-button` SplitButton	`46.228 kB` `11.933 kB`
`react-button` ToggleButton	`51.888 kB` `11.127 kB`
`react-card` Card - All	`67.002 kB` `19.261 kB`
`react-card` Card	`62.684 kB` `18.177 kB`
`react-card` CardFooter	`8.561 kB` `3.601 kB`
`react-card` CardHeader	`9.604 kB` `3.94 kB`
`react-card` CardPreview	`8.662 kB` `3.656 kB`
`react-combobox` Combobox (including child components)	`74.636 kB` `24.186 kB`
`react-combobox` Dropdown (including child components)	`74.236 kB` `24.086 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`188.689 kB` `52.37 kB`
`react-components` react-components: FluentProvider & webLightTheme	`33.394 kB` `11.007 kB`
`react-dialog` Dialog (including children components)	`82.755 kB` `24.581 kB`
`react-divider` Divider	`16.459 kB` `5.902 kB`
`react-image` Image	`10.78 kB` `4.264 kB`
`react-input` Input	`23.757 kB` `7.704 kB`
`react-label` Label	`9.338 kB` `3.86 kB`
`react-link` Link	`11.784 kB` `4.867 kB`
`react-menu` Menu (including children components)	`116.589 kB` `35.777 kB`
`react-menu` Menu (including selectable components)	`119.658 kB` `36.296 kB`
`react-overflow` hooks only	`10.685 kB` `4.104 kB`
`react-popover` Popover	`102.963 kB` `31.553 kB`
`react-portal` Portal	`10.576 kB` `3.875 kB`
`react-portal-compat` PortalCompatProvider	`5.851 kB` `1.964 kB`
`react-positioning` usePositioning	`19.7 kB` `7.404 kB`
`react-provider` FluentProvider	`15.755 kB` `5.883 kB`
`react-radio` Radio	`35.56 kB` `11.929 kB`
`react-radio` RadioGroup	`14.248 kB` `5.7 kB`
`react-select` Select	`20.846 kB` `7.346 kB`
`react-slider` Slider	`31.526 kB` `10.046 kB`
`react-spinbutton` SpinButton	`44.102 kB` `12.425 kB`
`react-spinner` Spinner	`19.977 kB` `6.438 kB`
`react-switch` Switch	`32.097 kB` `10.27 kB`
`react-text` Text - Default	`11.782 kB` `4.605 kB`
`react-text` Text - Wrappers	`15.092 kB` `5.044 kB`
`react-textarea` Textarea	`25.013 kB` `8.133 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`29.65 kB` `6.444 kB`
`react-theme` Teams: Light theme	`17.486 kB` `5.057 kB`
`react-tooltip` Tooltip	`41.535 kB` `14.639 kB`
`react-utilities` SSRProvider	`180 B` `159 B`

_{🤖 This report was generated against b415287e740508fbd3c64597bacc5efc6592c910}

fabricteam · 2022-09-22T18:27:36Z

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
ButtonMinimalPerf.default	145	128	1.13:1
TextAreaMinimalPerf.default	392	368	1.07:1
GridMinimalPerf.default	280	266	1.05:1
LabelMinimalPerf.default	314	303	1.04:1
ListNestedPerf.default	458	442	1.04:1
PortalMinimalPerf.default	140	134	1.04:1
TooltipMinimalPerf.default	1957	1884	1.04:1
TreeWith60ListItems.default	131	126	1.04:1
CardMinimalPerf.default	438	427	1.03:1
ReactionMinimalPerf.default	306	297	1.03:1
SegmentMinimalPerf.default	282	275	1.03:1
TableMinimalPerf.default	333	324	1.03:1
TextMinimalPerf.default	286	279	1.03:1
AttachmentSlotsPerf.default	921	907	1.02:1
DividerMinimalPerf.default	292	286	1.02:1
FormMinimalPerf.default	309	303	1.02:1
HeaderMinimalPerf.default	289	284	1.02:1
ListCommonPerf.default	514	502	1.02:1
ListMinimalPerf.default	420	413	1.02:1
StatusMinimalPerf.default	560	549	1.02:1
AttachmentMinimalPerf.default	122	121	1.01:1
BoxMinimalPerf.default	274	270	1.01:1
ChatWithPopoverPerf.default	299	297	1.01:1
DatepickerMinimalPerf.default	4791	4753	1.01:1
DropdownMinimalPerf.default	2248	2227	1.01:1
EmbedMinimalPerf.default	3046	3002	1.01:1
FlexMinimalPerf.default	236	234	1.01:1
ItemLayoutMinimalPerf.default	966	956	1.01:1
ListWith60ListItems.default	521	518	1.01:1
MenuMinimalPerf.default	697	691	1.01:1
MenuButtonMinimalPerf.default	1400	1382	1.01:1
RosterPerf.default	1761	1748	1.01:1
PopupMinimalPerf.default	523	520	1.01:1
RadioGroupMinimalPerf.default	367	362	1.01:1
RefMinimalPerf.default	180	179	1.01:1
SliderMinimalPerf.default	1318	1307	1.01:1
SplitButtonMinimalPerf.default	3661	3617	1.01:1
VideoMinimalPerf.default	603	595	1.01:1
AnimationMinimalPerf.default	439	441	1:1
InputMinimalPerf.default	935	935	1:1
ProviderMergeThemesPerf.default	1056	1053	1:1
ProviderMinimalPerf.default	336	336	1:1
TableManyItemsPerf.default	1537	1536	1:1
ToolbarMinimalPerf.default	760	757	1:1
TreeMinimalPerf.default	661	662	1:1
AvatarMinimalPerf.default	152	153	0.99:1
ButtonOverridesMissPerf.default	1066	1082	0.99:1
ChatMinimalPerf.default	592	597	0.99:1
CheckboxMinimalPerf.default	1705	1718	0.99:1
DialogMinimalPerf.default	639	643	0.99:1
DropdownManyItemsPerf.default	549	556	0.99:1
ImageMinimalPerf.default	313	316	0.99:1
LayoutMinimalPerf.default	290	292	0.99:1
LoaderMinimalPerf.default	543	549	0.99:1
IconMinimalPerf.default	551	557	0.99:1
CustomToolbarPrototype.default	2218	2240	0.99:1
ButtonSlotsPerf.default	444	452	0.98:1
SkeletonMinimalPerf.default	274	279	0.98:1
AccordionMinimalPerf.default	116	119	0.97:1
CarouselMinimalPerf.default	374	387	0.97:1
HeaderSlotsPerf.default	617	640	0.96:1
ChatDuplicateMessagesPerf.default	212	223	0.95:1
AlertMinimalPerf.default	208	224	0.93:1

fabricteam · 2022-09-22T18:44:07Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	1217	1178	5000
Breadcrumb	mount	2797	2814	1000
Checkbox	mount	2633	2600	5000
CheckboxBase	mount	2326	2366	5000
ChoiceGroup	mount	4226	4247	5000
ComboBox	mount	1159	1166	1000
CommandBar	mount	9189	9252	1000
ContextualMenu	mount	10088	10121	1000
DefaultButton	mount	1355	1353	5000
DetailsRow	mount	3379	3364	5000
DetailsRowFast	mount	3390	3369	5000
DetailsRowNoStyles	mount	3232	3208	5000
Dialog	mount	2951	2961	1000
DocumentCardTitle	mount	595	587	1000
Dropdown	mount	3159	3171	5000
FocusTrapZone	mount	1982	1957	5000
FocusZone	mount	1961	1911	5000
GroupedList	mount	47442	54086	2
GroupedList	virtual-rerender	23380	23066	2
GroupedList	virtual-rerender-with-unmount	83095	81510	2
GroupedListV2	mount	564	567	2
GroupedListV2	virtual-rerender	540	531	2
GroupedListV2	virtual-rerender-with-unmount	558	549	2
IconButton	mount	1798	1787	5000
Label	mount	756	749	5000
Layer	mount	4166	4171	5000
Link	mount	847	857	5000
MenuButton	mount	1617	1611	5000
MessageBar	mount	2371	2393	5000
Nav	mount	3079	3092	1000
OverflowSet	mount	1406	1409	5000
Panel	mount	2482	2519	1000
Persona	mount	1248	1265	1000
Pivot	mount	1522	1514	1000
PrimaryButton	mount	1486	1491	5000
Rating	mount	6975	6983	5000
SearchBox	mount	1481	1491	5000
Shimmer	mount	2924	2927	5000
Slider	mount	2102	2121	5000
SpinButton	mount	4256	4200	5000
Spinner	mount	830	817	5000
SplitButton	mount	2866	2795	5000
Stack	mount	909	891	5000
StackWithIntrinsicChildren	mount	2238	2250	5000
StackWithTextChildren	mount	4957	4928	5000
SwatchColorPicker	mount	9490	9593	5000
TagPicker	mount	2337	2339	5000
TeachingBubble	mount	73968	73601	5000
Text	mount	817	819	5000
TextField	mount	1563	1555	5000
ThemeProvider	mount	1440	1439	5000
ThemeProvider	virtual-rerender	1143	1145	5000
ThemeProvider	virtual-rerender-with-unmount	2012	1983	5000
Toggle	mount	1146	1135	5000
buttonNative	mount	538	542	5000

scripts/updateReleaseNotes/releases.ts

Hotell · 2022-09-23T09:27:52Z

scripts/package.json

    "@mdx-js/loader": "^1.5.5",
    "@microsoft/load-themed-styles": "^1.10.26",
    "@microsoft/loader-load-themed-styles": "^1.7.205",
-    "@octokit/rest": "^16.28.2",


single version policy move and pinned to actual version installed

* master: (21 commits) chore: Migrate react-avatar to use new build (microsoft#24969) applying package updates chore(react-input, react-textarea): Deprecating filled with shadow appearance variants (microsoft#24900) fix: v8 Dropdown no longer sets incorrect and unnecessary aria-activedescendant (microsoft#24593) feat: v0 Tooltip migration from v9 (microsoft#24908) chore: bump devDeps to fix critical security vulnerability (microsoft#24891) Fixing Tree chart issues (microsoft#24752) init: new package react-avatar-context (microsoft#24968) ci(.github): add issues write permisions to triage-bot worflow (microsoft#24963) applying package updates fix(Toolbar): close previous submenu when opening another submenu (microsoft#24836) fix: update non-focus-trap Popover role to be group (microsoft#24897) feat: Avatar's aria label includes 'active' or 'inactive' when using the active prop (microsoft#24901) feat(scripts): implement triage-bot module (microsoft#24911) chore: bump @octokit/rest to v18 (microsoft#24919) stress test: add "build-fixture" command (microsoft#24928) BREAKING-CHANGE: new ChatMessageContent for style caching (microsoft#24691) bugfix: fix changefile to properly update version of react-components with a patch (microsoft#24949) feat(scripts): enable strict checking for additional sub-folders(packages) (microsoft#24526) chore: exports DialogContent as unstable (microsoft#24943) ...

* feat(scripts): implement triage-bot module * ci(github): setup triage bot * chore: move octokit to single version policy, add @actions packages

msft-fluent-ui-bot assigned tomi-msft Sep 22, 2022

Hotell added the CI label Sep 22, 2022

github-actions bot added this to the September Project Cycle Q1 2022 milestone Sep 22, 2022

Hotell unassigned tomi-msft Sep 22, 2022

Hotell changed the title ~~Hotell/ci/triage bot custom~~ feat(scripts): implement triage-bot module Sep 22, 2022

Hotell marked this pull request as ready for review September 22, 2022 18:08

Hotell requested a review from a team as a code owner September 22, 2022 18:08

Hotell commented Sep 23, 2022

View reviewed changes

scripts/updateReleaseNotes/releases.ts Outdated Show resolved Hide resolved

Hotell force-pushed the hotell/ci/triage-bot-custom branch from d1e64bd to faf9ca5 Compare September 23, 2022 09:04

tudorpopams approved these changes Sep 23, 2022

View reviewed changes

Hotell force-pushed the hotell/ci/triage-bot-custom branch from faf9ca5 to 95ef824 Compare September 23, 2022 09:18

Hotell commented Sep 23, 2022

View reviewed changes

Hotell force-pushed the hotell/ci/triage-bot-custom branch from 95ef824 to 3466291 Compare September 26, 2022 15:38

Hotell added 3 commits September 26, 2022 19:21

feat(scripts): implement triage-bot module

573a16a

ci(github): setup triage bot

971121e

chore: move octokit to single version policy, add @actions packages

a16631d

Hotell force-pushed the hotell/ci/triage-bot-custom branch from 3466291 to a16631d Compare September 26, 2022 17:22

Hotell enabled auto-merge (squash) September 26, 2022 17:23

Hotell merged commit 203e5de into microsoft:master Sep 26, 2022

Hotell deleted the hotell/ci/triage-bot-custom branch September 27, 2022 09:03

Hotell mentioned this pull request Sep 27, 2022

ci(.github): add issues write permisions to triage-bot worflow #24963

Merged

Hotell mentioned this pull request Nov 16, 2022

Feat: Shield revamp #25697

Open

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(scripts): implement triage-bot module#24911

feat(scripts): implement triage-bot module#24911
Hotell merged 3 commits intomicrosoft:masterfrom
Hotell:hotell/ci/triage-bot-custom

Hotell commented Sep 22, 2022 •

edited

Loading

Uh oh!

codesandbox-ci bot commented Sep 22, 2022 •

edited

Loading

Uh oh!

size-auditor bot commented Sep 22, 2022 •

edited

Loading

Uh oh!

fabricteam commented Sep 22, 2022 •

edited

Loading

Uh oh!

fabricteam commented Sep 22, 2022 •

edited

Loading

Uh oh!

fabricteam commented Sep 22, 2022 •

edited

Loading

Uh oh!

fabricteam commented Sep 22, 2022 •

edited

Loading

Uh oh!

Uh oh!

Hotell Sep 23, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Hotell commented Sep 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current Behavior

New Behavior

Related Issue(s)

Uh oh!

codesandbox-ci bot commented Sep 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

size-auditor bot commented Sep 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Asset size changes

Uh oh!

fabricteam commented Sep 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-components)

Uh oh!

fabricteam commented Sep 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

fabricteam commented Sep 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-northstar)

Uh oh!

fabricteam commented Sep 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react)

Uh oh!

Uh oh!

Hotell Sep 23, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Hotell commented Sep 22, 2022 •

edited

Loading

codesandbox-ci bot commented Sep 22, 2022 •

edited

Loading

size-auditor bot commented Sep 22, 2022 •

edited

Loading

fabricteam commented Sep 22, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

fabricteam commented Sep 22, 2022 •

edited

Loading

fabricteam commented Sep 22, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-northstar`)

fabricteam commented Sep 22, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react`)