chore(react-input, react-textarea): Deprecating filled with shadow appearance variants#24900
Merged
sopranopillow merged 3 commits intomicrosoft:masterfrom Sep 27, 2022
Merged
Conversation
Contributor
Can you expand on the issue a bit more please? |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b4077e2:
|
Collaborator
📊 Bundle size report
Unchanged fixtures
|
Contributor
Author
I just updated it :) I'm mainly preparing this PR to discuss it next week. |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1295 | 1312 | 5000 | |
| Button | mount | 933 | 949 | 5000 | |
| FluentProvider | mount | 1604 | 1571 | 5000 | |
| FluentProviderWithTheme | mount | 622 | 633 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 591 | 585 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 630 | 625 | 10 | |
| MakeStyles | mount | 1886 | 1887 | 50000 | |
| SpinButton | mount | 2529 | 2537 | 5000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 483f160617f1037e672fe74b8e52abfee9378517 (build) |
spmonahan
approved these changes
Sep 27, 2022
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Sep 28, 2022
* master: (21 commits) chore: Migrate react-avatar to use new build (microsoft#24969) applying package updates chore(react-input, react-textarea): Deprecating filled with shadow appearance variants (microsoft#24900) fix: v8 Dropdown no longer sets incorrect and unnecessary aria-activedescendant (microsoft#24593) feat: v0 Tooltip migration from v9 (microsoft#24908) chore: bump devDeps to fix critical security vulnerability (microsoft#24891) Fixing Tree chart issues (microsoft#24752) init: new package react-avatar-context (microsoft#24968) ci(.github): add issues write permisions to triage-bot worflow (microsoft#24963) applying package updates fix(Toolbar): close previous submenu when opening another submenu (microsoft#24836) fix: update non-focus-trap Popover role to be group (microsoft#24897) feat: Avatar's aria label includes 'active' or 'inactive' when using the active prop (microsoft#24901) feat(scripts): implement triage-bot module (microsoft#24911) chore: bump @octokit/rest to v18 (microsoft#24919) stress test: add "build-fixture" command (microsoft#24928) BREAKING-CHANGE: new ChatMessageContent for style caching (microsoft#24691) bugfix: fix changefile to properly update version of react-components with a patch (microsoft#24949) feat(scripts): enable strict checking for additional sub-folders(packages) (microsoft#24526) chore: exports DialogContent as unstable (microsoft#24943) ...
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
…pearance variants (microsoft#24900) * fix: Deprecate filled with shadow appearance variants. * change files * wording
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the filled with shadow appearance variants. This is due to the shadow appearances not being visible when used on a background that meets our contrast ratio guidelines.
This is how our current docs show the variants:
To be able to see the shadow, a lighter background is required like this one:
This contradicts our guidelines on using a background with enough contrast ratio for accessibility requirements.