-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Closed
Labels
Milestone
Description
Describe the issue:
Currently when one creates new monorepo package, sometimes besides boostraping via yarn create-package, author also adds implementation or part of it. Then usually during PR review, reviewer will ask to bootstrap package in separate PR.
Now what we saw is that author of the package, manually copies newly created files to separate PR, but forgets about packages that have been modified as well (workspace.json, tsconfig.base.json)
Examples:
- vNext Combobox: add empty react-combobox package #21681
- chore: add Toolbar autogenerated files #21791
-> this breakes our monorepo/workspace 🔥
Actual behavior:
Pipeline passes
Expected behavior:
Pipeline should break as user created invalid package
Reactions are currently unavailable