vNext Combobox: add empty react-combobox package#21681
Merged
smhigley merged 8 commits intomicrosoft:masterfrom Feb 10, 2022
Merged
vNext Combobox: add empty react-combobox package#21681smhigley merged 8 commits intomicrosoft:masterfrom
smhigley merged 8 commits intomicrosoft:masterfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 131b62b:
|
Collaborator
📊 Bundle size report
🤖 This report was generated against e07cc826b280603418e2e8bc79b161e459de9741 |
behowell
approved these changes
Feb 10, 2022
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| ContextualMenu | mount | 17666 | 7305 | 1000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 758 | 772 | 5000 | |
| BaseButton | mount | 762 | 795 | 5000 | |
| Breadcrumb | mount | 2253 | 2310 | 1000 | |
| ButtonNext | mount | 413 | 412 | 5000 | |
| Checkbox | mount | 1411 | 1317 | 5000 | |
| CheckboxBase | mount | 1137 | 1009 | 5000 | |
| ChoiceGroup | mount | 3957 | 4054 | 5000 | |
| ComboBox | mount | 850 | 866 | 1000 | |
| CommandBar | mount | 8859 | 8878 | 1000 | |
| ContextualMenu | mount | 17666 | 7305 | 1000 | Possible regression |
| DefaultButton | mount | 996 | 1006 | 5000 | |
| DetailsRow | mount | 3241 | 3082 | 5000 | |
| DetailsRowFast | mount | 3235 | 3223 | 5000 | |
| DetailsRowNoStyles | mount | 3040 | 3032 | 5000 | |
| Dialog | mount | 1891 | 1884 | 1000 | |
| DocumentCardTitle | mount | 176 | 159 | 1000 | |
| Dropdown | mount | 2716 | 2782 | 5000 | |
| FluentProviderNext | mount | 1628 | 1675 | 5000 | |
| FluentProviderWithTheme | mount | 132 | 110 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 106 | 110 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 169 | 174 | 10 | |
| FocusTrapZone | mount | 1541 | 1598 | 5000 | |
| FocusZone | mount | 1501 | 1599 | 5000 | |
| IconButton | mount | 1399 | 1503 | 5000 | |
| Label | mount | 329 | 288 | 5000 | |
| Layer | mount | 2502 | 2786 | 5000 | |
| Link | mount | 423 | 432 | 5000 | |
| MakeStyles | mount | 1470 | 1464 | 50000 | |
| MenuButton | mount | 1274 | 1201 | 5000 | |
| MessageBar | mount | 1773 | 1755 | 5000 | |
| Nav | mount | 3114 | 2833 | 1000 | |
| OverflowSet | mount | 958 | 981 | 5000 | |
| Panel | mount | 1871 | 1867 | 1000 | |
| Persona | mount | 758 | 750 | 1000 | |
| Pivot | mount | 1257 | 1249 | 1000 | |
| PrimaryButton | mount | 1119 | 1137 | 5000 | |
| Rating | mount | 6513 | 6514 | 5000 | |
| SearchBox | mount | 1163 | 1184 | 5000 | |
| Shimmer | mount | 2258 | 2200 | 5000 | |
| Slider | mount | 1744 | 1737 | 5000 | |
| SpinButton | mount | 4286 | 4219 | 5000 | |
| Spinner | mount | 407 | 392 | 5000 | |
| SplitButton | mount | 2722 | 2714 | 5000 | |
| Stack | mount | 466 | 480 | 5000 | |
| StackWithIntrinsicChildren | mount | 2028 | 2003 | 5000 | |
| StackWithTextChildren | mount | 4577 | 4569 | 5000 | |
| SwatchColorPicker | mount | 9492 | 9593 | 5000 | |
| TagPicker | mount | 2174 | 2232 | 5000 | |
| TeachingBubble | mount | 11334 | 11227 | 5000 | |
| Text | mount | 379 | 403 | 5000 | |
| TextField | mount | 1219 | 1160 | 5000 | |
| ThemeProvider | mount | 1026 | 1030 | 5000 | |
| ThemeProvider | virtual-rerender | 1676 | 545 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1554 | 1608 | 5000 | |
| Toggle | mount | 717 | 722 | 5000 | |
| buttonNative | mount | 142 | 139 | 5000 |
Perf Analysis (@fluentui/react-northstar)
khmakoto
approved these changes
Feb 10, 2022
micahgodbolt
approved these changes
Feb 10, 2022
ecraig12345
approved these changes
Feb 10, 2022
Co-authored-by: Elizabeth Craig <ecraig12345@gmail.com>
11a9af7 to
b27aaf8
Compare
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: e07cc826b280603418e2e8bc79b161e459de9741 (build) |
This was referenced Feb 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #21666
Creates an empty
react-comboboxpackage with stubbed-out components. Doesn't affect thereact-componentspackage.Should make it easier to review the combobox PR :)