Skip to content

chore: add Toolbar autogenerated files#21791

Merged
chpalac merged 3 commits intomicrosoft:masterfrom
chpalac:feat/add-toolbar-autogenerated
Feb 18, 2022
Merged

chore: add Toolbar autogenerated files#21791
chpalac merged 3 commits intomicrosoft:masterfrom
chpalac:feat/add-toolbar-autogenerated

Conversation

@chpalac
Copy link
Contributor

@chpalac chpalac commented Feb 17, 2022

Overview

This is a prep PR for the #21743 adding all auto-generated files to actually highlight the changes in there.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 17, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c751ae5:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Feb 17, 2022 •
edited
Loading

📊 Bundle size report

🤖 This report was generated against 5795a9c44f6f4653b153f5b80e3fb6de6d9ba3a0

@size-auditor
Copy link

size-auditor bot commented Feb 17, 2022 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 5795a9c44f6f4653b153f5b80e3fb6de6d9ba3a0 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Feb 17, 2022 •
edited
Loading

Perf Analysis (@fluentui/react)

Scenario Render type Master Ticks PR Ticks Iterations Status
ContextualMenu mount 8917 16866 1000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 972 994 5000
BaseButton mount 1082 1083 5000
Breadcrumb mount 2764 2783 1000
ButtonNext mount 526 551 5000
Checkbox mount 1796 1805 5000
CheckboxBase mount 1522 1503 5000
ChoiceGroup mount 5419 5463 5000
ComboBox mount 1105 1061 1000
CommandBar mount 10587 10675 1000
ContextualMenu mount 8917 16866 1000 Possible regression
DefaultButton mount 1288 1271 5000
DetailsRow mount 4121 4199 5000
DetailsRowFast mount 4016 4078 5000
DetailsRowNoStyles mount 3770 3859 5000
Dialog mount 2478 2407 1000
DocumentCardTitle mount 204 230 1000
Dropdown mount 4045 3702 5000
FluentProviderNext mount 1984 1916 5000
FluentProviderWithTheme mount 198 190 10
FluentProviderWithTheme virtual-rerender 126 129 10
FluentProviderWithTheme virtual-rerender-with-unmount 222 233 10
FocusTrapZone mount 2035 2118 5000
FocusZone mount 2019 1949 5000
IconButton mount 2038 2062 5000
Label mount 408 414 5000
Layer mount 3346 3335 5000
Link mount 573 602 5000
MakeStyles mount 1782 1826 50000
MenuButton mount 1708 1708 5000
MessageBar mount 2130 2172 5000
Nav mount 3681 3657 1000
OverflowSet mount 1246 1243 5000
Panel mount 2359 2343 1000
Persona mount 971 974 1000
Pivot mount 1649 1617 1000
PrimaryButton mount 1448 1453 5000
Rating mount 8783 8655 5000
SearchBox mount 1565 1512 5000
Shimmer mount 2887 2827 5000
Slider mount 2190 2244 5000
SpinButton mount 5609 5655 5000
Spinner mount 481 478 5000
SplitButton mount 3535 3621 5000
Stack mount 632 625 5000
StackWithIntrinsicChildren mount 2731 2837 5000
StackWithTextChildren mount 6282 6353 5000
SwatchColorPicker mount 12408 12433 5000
TagPicker mount 2821 2976 5000
TeachingBubble mount 14098 13778 5000
Text mount 508 486 5000
TextField mount 1596 1631 5000
ThemeProvider mount 1296 1311 5000
ThemeProvider virtual-rerender 689 697 5000
ThemeProvider virtual-rerender-with-unmount 2181 2139 5000
Toggle mount 987 911 5000
buttonNative mount 174 179 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
FormMinimalPerf.default 499 452 1.1:1
AnimationMinimalPerf.default 611 560 1.09:1
ListCommonPerf.default 765 704 1.09:1
AvatarMinimalPerf.default 246 227 1.08:1
FlexMinimalPerf.default 338 315 1.07:1
GridMinimalPerf.default 391 367 1.07:1
AccordionMinimalPerf.default 178 168 1.06:1
ChatDuplicateMessagesPerf.default 358 339 1.06:1
ListMinimalPerf.default 596 562 1.06:1
ListNestedPerf.default 642 603 1.06:1
PortalMinimalPerf.default 198 186 1.06:1
TableManyItemsPerf.default 2226 2119 1.05:1
TextMinimalPerf.default 405 385 1.05:1
BoxMinimalPerf.default 414 399 1.04:1
ChatMinimalPerf.default 837 802 1.04:1
DropdownManyItemsPerf.default 799 771 1.04:1
RefMinimalPerf.default 268 257 1.04:1
TableMinimalPerf.default 477 458 1.04:1
TooltipMinimalPerf.default 1186 1139 1.04:1
TreeWith60ListItems.default 221 213 1.04:1
AlertMinimalPerf.default 319 311 1.03:1
AttachmentMinimalPerf.default 197 191 1.03:1
AttachmentSlotsPerf.default 1192 1159 1.03:1
ChatWithPopoverPerf.default 444 432 1.03:1
DatepickerMinimalPerf.default 6055 5902 1.03:1
DialogMinimalPerf.default 874 846 1.03:1
HeaderMinimalPerf.default 419 406 1.03:1
InputMinimalPerf.default 1445 1397 1.03:1
ItemLayoutMinimalPerf.default 1378 1339 1.03:1
LabelMinimalPerf.default 439 427 1.03:1
SegmentMinimalPerf.default 405 394 1.03:1
SkeletonMinimalPerf.default 403 390 1.03:1
IconMinimalPerf.default 694 677 1.03:1
VideoMinimalPerf.default 723 704 1.03:1
CheckboxMinimalPerf.default 2909 2858 1.02:1
RadioGroupMinimalPerf.default 503 492 1.02:1
DividerMinimalPerf.default 416 410 1.01:1
DropdownMinimalPerf.default 3281 3257 1.01:1
HeaderSlotsPerf.default 860 853 1.01:1
MenuMinimalPerf.default 941 929 1.01:1
ReactionMinimalPerf.default 437 431 1.01:1
SliderMinimalPerf.default 1828 1814 1.01:1
CarouselMinimalPerf.default 520 522 1:1
EmbedMinimalPerf.default 4574 4576 1:1
LoaderMinimalPerf.default 741 739 1:1
SplitButtonMinimalPerf.default 4718 4736 1:1
ButtonMinimalPerf.default 208 211 0.99:1
CardMinimalPerf.default 632 636 0.99:1
LayoutMinimalPerf.default 408 411 0.99:1
MenuButtonMinimalPerf.default 1822 1842 0.99:1
RosterPerf.default 1365 1382 0.99:1
PopupMinimalPerf.default 663 667 0.99:1
ProviderMergeThemesPerf.default 1791 1816 0.99:1
StatusMinimalPerf.default 760 764 0.99:1
CustomToolbarPrototype.default 4447 4507 0.99:1
ButtonOverridesMissPerf.default 1876 1909 0.98:1
ListWith60ListItems.default 723 738 0.98:1
TextAreaMinimalPerf.default 579 591 0.98:1
ToolbarMinimalPerf.default 1052 1071 0.98:1
TreeMinimalPerf.default 885 907 0.98:1
ImageMinimalPerf.default 409 423 0.97:1
ProviderMinimalPerf.default 1252 1289 0.97:1
ButtonSlotsPerf.default 591 627 0.94:1

ling1726
ling1726 reviewed Feb 17, 2022
View reviewed changes
ling1726
ling1726 approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@ling1726 ling1726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update with the changes in #21690, you'll need to modify package.json

or honestly just create the package again

layershifter
layershifter approved these changes Feb 18, 2022
View reviewed changes
Copy link
Member

@layershifter layershifter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also add new component to CODE_OWNERS file (can be done in a separate PR).

@chpalac chpalac mentioned this pull request Feb 18, 2022
Merged
@chpalac chpalac enabled auto-merge (squash) February 18, 2022 11:17
@chpalac chpalac merged commit 0d92e02 into microsoft:master Feb 18, 2022
@Hotell
Copy link
Contributor

Hotell commented Feb 18, 2022 •
edited
Loading

hi @chpalac .

Would you mind to share how did you create this boilerplate ?

It doesn't look like you've used yarn create-package thus this created broken monorepo workspace.

thx

@Hotell Hotell mentioned this pull request Feb 18, 2022
Closed
@chpalac chpalac deleted the feat/add-toolbar-autogenerated branch February 21, 2022 12:00
@chpalac
Copy link
Contributor Author

chpalac commented Feb 21, 2022

hi @chpalac .

Would you mind to share how did you create this boilerplate ?

It doesn't look like you've used yarn create-package thus this created broken monorepo workspace.

Hey @Hotell , I did use yarn create-package

@Hotell
Copy link
Contributor

Hotell commented Feb 21, 2022

Hey @Hotell , I did use yarn create-package

interesting, this PR was missing updated workspace.json and tsconfig.base.json - those are updated during create-package run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@layershifter layershifter layershifter approved these changes

+1 more reviewer

@ling1726 ling1726 ling1726 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tomi-msft tomi-msft

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@chpalac @fabricteam @Hotell @layershifter @ling1726 @tomi-msft