chore: Force bump all v9 packages to release correct source maps#21690
Merged
ling1726 merged 7 commits intomicrosoft:masterfrom Feb 17, 2022
Merged
chore: Force bump all v9 packages to release correct source maps#21690ling1726 merged 7 commits intomicrosoft:masterfrom
ling1726 merged 7 commits intomicrosoft:masterfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 093548e:
|
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: d579bbbbb8bd1457e14b03eda2bc638d89f92d56 (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 976 | 946 | 5000 | |
| BaseButton | mount | 991 | 999 | 5000 | |
| Breadcrumb | mount | 2681 | 2696 | 1000 | |
| ButtonNext | mount | 552 | 533 | 5000 | |
| Checkbox | mount | 1648 | 1659 | 5000 | |
| CheckboxBase | mount | 1437 | 1457 | 5000 | |
| ChoiceGroup | mount | 5057 | 5120 | 5000 | |
| ComboBox | mount | 1054 | 1033 | 1000 | |
| CommandBar | mount | 10487 | 10338 | 1000 | |
| ContextualMenu | mount | 8623 | 8601 | 1000 | |
| DefaultButton | mount | 1262 | 1256 | 5000 | |
| DetailsRow | mount | 3919 | 3938 | 5000 | |
| DetailsRowFast | mount | 3913 | 3905 | 5000 | |
| DetailsRowNoStyles | mount | 3780 | 3830 | 5000 | |
| Dialog | mount | 2439 | 2371 | 1000 | |
| DocumentCardTitle | mount | 183 | 204 | 1000 | |
| Dropdown | mount | 3423 | 3469 | 5000 | |
| FluentProviderNext | mount | 1850 | 1809 | 5000 | |
| FluentProviderWithTheme | mount | 164 | 166 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 119 | 117 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 203 | 219 | 10 | |
| FocusTrapZone | mount | 1922 | 1837 | 5000 | |
| FocusZone | mount | 1900 | 1870 | 5000 | |
| IconButton | mount | 1886 | 1966 | 5000 | |
| Label | mount | 374 | 393 | 5000 | |
| Layer | mount | 3107 | 3134 | 5000 | |
| Link | mount | 550 | 513 | 5000 | |
| MakeStyles | mount | 1695 | 1719 | 50000 | |
| MenuButton | mount | 1685 | 1613 | 5000 | |
| MessageBar | mount | 2037 | 2020 | 5000 | |
| Nav | mount | 3524 | 3475 | 1000 | |
| OverflowSet | mount | 1168 | 1152 | 5000 | |
| Panel | mount | 2243 | 2336 | 1000 | |
| Persona | mount | 870 | 916 | 1000 | |
| Pivot | mount | 1522 | 1571 | 1000 | |
| PrimaryButton | mount | 1432 | 1384 | 5000 | |
| Rating | mount | 8329 | 8538 | 5000 | |
| SearchBox | mount | 1489 | 1427 | 5000 | |
| Shimmer | mount | 2698 | 2729 | 5000 | |
| Slider | mount | 2104 | 2102 | 5000 | |
| SpinButton | mount | 5189 | 5198 | 5000 | |
| Spinner | mount | 462 | 463 | 5000 | |
| SplitButton | mount | 3247 | 3417 | 5000 | |
| Stack | mount | 573 | 556 | 5000 | |
| StackWithIntrinsicChildren | mount | 2607 | 2577 | 5000 | |
| StackWithTextChildren | mount | 6060 | 6182 | 5000 | |
| SwatchColorPicker | mount | 12308 | 12040 | 5000 | |
| TagPicker | mount | 2709 | 2747 | 5000 | |
| TeachingBubble | mount | 13638 | 13326 | 5000 | |
| Text | mount | 493 | 482 | 5000 | |
| TextField | mount | 1477 | 1520 | 5000 | |
| ThemeProvider | mount | 1238 | 1242 | 5000 | |
| ThemeProvider | virtual-rerender | 626 | 626 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 2029 | 2036 | 5000 | |
| Toggle | mount | 913 | 892 | 5000 | |
| buttonNative | mount | 171 | 178 | 5000 |
Perf Analysis (@fluentui/react-northstar)
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| RefMinimalPerf.default | 267 | 245 | 1.09:1 |
| ButtonMinimalPerf.default | 209 | 193 | 1.08:1 |
| TreeMinimalPerf.default | 877 | 809 | 1.08:1 |
| MenuMinimalPerf.default | 963 | 903 | 1.07:1 |
| TextMinimalPerf.default | 377 | 351 | 1.07:1 |
| AttachmentMinimalPerf.default | 193 | 182 | 1.06:1 |
| BoxMinimalPerf.default | 388 | 366 | 1.06:1 |
| ButtonSlotsPerf.default | 593 | 562 | 1.06:1 |
| IconMinimalPerf.default | 692 | 650 | 1.06:1 |
| ChatWithPopoverPerf.default | 404 | 386 | 1.05:1 |
| ListCommonPerf.default | 694 | 664 | 1.05:1 |
| SegmentMinimalPerf.default | 391 | 372 | 1.05:1 |
| AttachmentSlotsPerf.default | 1201 | 1151 | 1.04:1 |
| AvatarMinimalPerf.default | 222 | 215 | 1.03:1 |
| CardMinimalPerf.default | 605 | 586 | 1.03:1 |
| ChatDuplicateMessagesPerf.default | 320 | 310 | 1.03:1 |
| CheckboxMinimalPerf.default | 2774 | 2682 | 1.03:1 |
| DropdownManyItemsPerf.default | 751 | 730 | 1.03:1 |
| ListWith60ListItems.default | 729 | 705 | 1.03:1 |
| ProviderMinimalPerf.default | 1161 | 1129 | 1.03:1 |
| StatusMinimalPerf.default | 745 | 720 | 1.03:1 |
| TooltipMinimalPerf.default | 1104 | 1070 | 1.03:1 |
| DialogMinimalPerf.default | 790 | 776 | 1.02:1 |
| FlexMinimalPerf.default | 299 | 294 | 1.02:1 |
| FormMinimalPerf.default | 473 | 463 | 1.02:1 |
| HeaderSlotsPerf.default | 837 | 817 | 1.02:1 |
| LabelMinimalPerf.default | 415 | 406 | 1.02:1 |
| ListNestedPerf.default | 605 | 596 | 1.02:1 |
| PortalMinimalPerf.default | 189 | 185 | 1.02:1 |
| SkeletonMinimalPerf.default | 387 | 381 | 1.02:1 |
| SplitButtonMinimalPerf.default | 4579 | 4506 | 1.02:1 |
| TextAreaMinimalPerf.default | 541 | 530 | 1.02:1 |
| TreeWith60ListItems.default | 197 | 193 | 1.02:1 |
| AccordionMinimalPerf.default | 166 | 165 | 1.01:1 |
| AnimationMinimalPerf.default | 572 | 565 | 1.01:1 |
| ButtonOverridesMissPerf.default | 1781 | 1765 | 1.01:1 |
| CarouselMinimalPerf.default | 496 | 489 | 1.01:1 |
| ChatMinimalPerf.default | 775 | 765 | 1.01:1 |
| ImageMinimalPerf.default | 418 | 413 | 1.01:1 |
| ListMinimalPerf.default | 534 | 527 | 1.01:1 |
| PopupMinimalPerf.default | 646 | 640 | 1.01:1 |
| ProviderMergeThemesPerf.default | 1688 | 1679 | 1.01:1 |
| DatepickerMinimalPerf.default | 5762 | 5775 | 1:1 |
| EmbedMinimalPerf.default | 4345 | 4363 | 1:1 |
| ItemLayoutMinimalPerf.default | 1247 | 1242 | 1:1 |
| MenuButtonMinimalPerf.default | 1790 | 1782 | 1:1 |
| RosterPerf.default | 1327 | 1326 | 1:1 |
| ReactionMinimalPerf.default | 431 | 429 | 1:1 |
| TableMinimalPerf.default | 442 | 444 | 1:1 |
| AlertMinimalPerf.default | 294 | 298 | 0.99:1 |
| DropdownMinimalPerf.default | 3041 | 3069 | 0.99:1 |
| HeaderMinimalPerf.default | 384 | 388 | 0.99:1 |
| InputMinimalPerf.default | 1321 | 1333 | 0.99:1 |
| LoaderMinimalPerf.default | 729 | 734 | 0.99:1 |
| TableManyItemsPerf.default | 2090 | 2113 | 0.99:1 |
| CustomToolbarPrototype.default | 4175 | 4198 | 0.99:1 |
| ToolbarMinimalPerf.default | 972 | 981 | 0.99:1 |
| VideoMinimalPerf.default | 650 | 657 | 0.99:1 |
| RadioGroupMinimalPerf.default | 470 | 479 | 0.98:1 |
| SliderMinimalPerf.default | 1732 | 1762 | 0.98:1 |
| LayoutMinimalPerf.default | 388 | 399 | 0.97:1 |
| GridMinimalPerf.default | 350 | 364 | 0.96:1 |
| DividerMinimalPerf.default | 393 | 422 | 0.93:1 |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
khmakoto
approved these changes
Feb 10, 2022
layershifter
approved these changes
Feb 11, 2022
Hotell
approved these changes
Feb 11, 2022
GeoffCoxMSFT
approved these changes
Feb 14, 2022
Collaborator
Contributor
Author
The issue is already fixed (but in #21788). This PR just force bumps every package to make sure beachball publishes all of the packages to get that fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
Source maps do not have correct source code
New Behavior
Source maps have correct source code
Related Issue(s)
Fixes #21686