Skip to content

fix: Run v9 production build before publish#21788

Merged
ling1726 merged 1 commit intomicrosoft:masterfrom
ling1726:fix/v9-release-sourcemaps
Feb 17, 2022
Merged

fix: Run v9 production build before publish#21788
ling1726 merged 1 commit intomicrosoft:masterfrom
ling1726:fix/v9-release-sourcemaps

Conversation

@ling1726
Copy link
Contributor

@ling1726 ling1726 commented Feb 17, 2022 •
edited
Loading

Current Behavior

yarn lage run --only does not work it still triggers build -> triggered an issue with Lage microsoft/lage#220

New Behavior

Run production build before publish step so source maps are correctly generated.

Related Issue(s)

Fixes #21686

@ling1726 ling1726 marked this pull request as ready for review February 17, 2022 10:53
@ling1726 ling1726 requested a review from a team as a code owner February 17, 2022 10:53
@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 17, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7ee5c1a:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Feb 17, 2022

Asset size changes

Project Bundle Baseline Size New Size Difference
office-ui-fabric-react fluentui-react-northstar-Dropdown 210.974 kB 211.097 kB ExceedsBaseline     123 bytes

ExceedsTolerance Over Tolerance (1024 B) ExceedsBaseline Over Baseline BelowBaseline Below Baseline New New Deleted  Removed 1 kB = 1000 B

Baseline commit: ac791cdd030b81a10df2a2ab76ad11b69fe06740 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Feb 17, 2022

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-accordion
Accordion (including children components)		 72.819 kB
22.036 kB
react-avatar
Avatar		 44.89 kB
13.02 kB
react-badge
Badge		 20.831 kB
6.533 kB
react-badge
CounterBadge		 21.699 kB
6.827 kB
react-badge
PresenceBadge		 21.785 kB
6.507 kB
react-button
Button		 27.942 kB
8.029 kB
react-button
CompoundButton		 33.206 kB
8.991 kB
react-button
MenuButton		 29.594 kB
8.601 kB
react-button
SplitButton		 36.085 kB
9.813 kB
react-button
ToggleButton		 37.24 kB
8.633 kB
react-card
Card - All		 47.867 kB
14.195 kB
react-card
Card		 43.56 kB
13.004 kB
react-card
CardFooter		 7.615 kB
3.23 kB
react-card
CardHeader		 8.893 kB
3.675 kB
react-card
CardPreview		 7.588 kB
3.255 kB
react-combobox
Combobox		 23.741 kB
9.039 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 171.167 kB
47.915 kB
react-components
react-components: FluentProvider & webLightTheme		 32.479 kB
10.625 kB
react-divider
Divider		 15.256 kB
5.511 kB
react-image
Image		 10.067 kB
3.934 kB
react-input
Input		 21.5 kB
7.116 kB
react-label
Label		 8.303 kB
3.472 kB
react-link
Link		 11.064 kB
4.487 kB
react-menu
Menu (including children components)		 102.914 kB
31.69 kB
react-menu
Menu (including selectable components)		 105.269 kB
32.056 kB
react-popover
Popover		 95.841 kB
29.229 kB
react-portal
Portal		 6.249 kB
2.163 kB
react-positioning
usePopper		 22.828 kB
7.951 kB
react-provider
FluentProvider		 13.962 kB
5.231 kB
react-select
Select		 7.716 kB
3.24 kB
react-slider
Slider		 22.928 kB
7.747 kB
react-spinner
Spinner		 6.773 kB
2.879 kB
react-switch
Switch		 25.381 kB
8.201 kB
react-text
Text - Default		 10.755 kB
4.212 kB
react-text
Text - Wrappers		 14.067 kB
4.558 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 29.426 kB
6.551 kB
react-theme
Teams: Light theme		 18.42 kB
5.27 kB
react-tooltip
Tooltip		 42.352 kB
14.569 kB
react-utilities
SSRProvider		 189 B
161 B
🤖 This report was generated against ac791cdd030b81a10df2a2ab76ad11b69fe06740

@fabricteam
Copy link
Collaborator

fabricteam commented Feb 17, 2022

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 911 933 5000
BaseButton mount 981 980 5000
Breadcrumb mount 2708 2727 1000
ButtonNext mount 493 498 5000
Checkbox mount 1606 1546 5000
CheckboxBase mount 1355 1354 5000
ChoiceGroup mount 4927 4885 5000
ComboBox mount 980 1062 1000
CommandBar mount 10475 10413 1000
ContextualMenu mount 16740 16823 1000
DefaultButton mount 1186 1182 5000
DetailsRow mount 3821 3834 5000
DetailsRowFast mount 3821 3808 5000
DetailsRowNoStyles mount 3583 3709 5000
Dialog mount 2291 2299 1000
DocumentCardTitle mount 187 209 1000
Dropdown mount 3288 3352 5000
FluentProviderNext mount 1927 1918 5000
FluentProviderWithTheme mount 158 177 10
FluentProviderWithTheme virtual-rerender 115 117 10
FluentProviderWithTheme virtual-rerender-with-unmount 185 214 10
FocusTrapZone mount 1883 1853 5000
FocusZone mount 1872 1891 5000
IconButton mount 1807 1800 5000
Label mount 395 379 5000
Layer mount 3040 3059 5000
Link mount 503 511 5000
MakeStyles mount 1773 1743 50000
MenuButton mount 1555 1539 5000
MessageBar mount 2093 2103 5000
Nav mount 3363 3319 1000
OverflowSet mount 1151 1164 5000
Panel mount 2237 2206 1000
Persona mount 880 869 1000
Pivot mount 1470 1508 1000
PrimaryButton mount 1347 1344 5000
Rating mount 7839 7836 5000
SearchBox mount 1419 1348 5000
Shimmer mount 2627 2627 5000
Slider mount 1971 2029 5000
SpinButton mount 5077 5114 5000
Spinner mount 461 475 5000
SplitButton mount 3252 3241 5000
Stack mount 553 561 5000
StackWithIntrinsicChildren mount 2348 2337 5000
StackWithTextChildren mount 5395 5396 5000
SwatchColorPicker mount 11613 11680 5000
TagPicker mount 2626 2637 5000
TeachingBubble mount 13430 13339 5000
Text mount 470 473 5000
TextField mount 1433 1452 5000
ThemeProvider mount 1222 1213 5000
ThemeProvider virtual-rerender 638 676 5000
ThemeProvider virtual-rerender-with-unmount 1930 1968 5000
Toggle mount 852 865 5000
buttonNative mount 155 143 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AttachmentMinimalPerf.default 163 150 1.09:1
ReactionMinimalPerf.default 416 381 1.09:1
HeaderMinimalPerf.default 389 365 1.07:1
StatusMinimalPerf.default 734 685 1.07:1
AvatarMinimalPerf.default 201 189 1.06:1
ImageMinimalPerf.default 393 372 1.06:1
ToolbarMinimalPerf.default 985 932 1.06:1
VideoMinimalPerf.default 645 609 1.06:1
LabelMinimalPerf.default 406 386 1.05:1
TableMinimalPerf.default 433 413 1.05:1
TextAreaMinimalPerf.default 526 501 1.05:1
RosterPerf.default 1220 1175 1.04:1
AttachmentSlotsPerf.default 1090 1058 1.03:1
CardMinimalPerf.default 564 550 1.03:1
ChatDuplicateMessagesPerf.default 297 289 1.03:1
DividerMinimalPerf.default 365 354 1.03:1
GridMinimalPerf.default 355 343 1.03:1
ListCommonPerf.default 651 629 1.03:1
PortalMinimalPerf.default 187 181 1.03:1
AnimationMinimalPerf.default 540 527 1.02:1
ButtonSlotsPerf.default 556 545 1.02:1
CarouselMinimalPerf.default 469 461 1.02:1
DialogMinimalPerf.default 767 752 1.02:1
ListMinimalPerf.default 524 514 1.02:1
LoaderMinimalPerf.default 705 693 1.02:1
MenuButtonMinimalPerf.default 1755 1722 1.02:1
PopupMinimalPerf.default 639 626 1.02:1
SplitButtonMinimalPerf.default 4413 4332 1.02:1
IconMinimalPerf.default 647 634 1.02:1
TextMinimalPerf.default 368 361 1.02:1
TreeMinimalPerf.default 818 802 1.02:1
AccordionMinimalPerf.default 162 160 1.01:1
BoxMinimalPerf.default 354 351 1.01:1
DatepickerMinimalPerf.default 5496 5462 1.01:1
EmbedMinimalPerf.default 4235 4194 1.01:1
ItemLayoutMinimalPerf.default 1215 1203 1.01:1
RadioGroupMinimalPerf.default 465 459 1.01:1
SegmentMinimalPerf.default 357 355 1.01:1
CustomToolbarPrototype.default 4175 4151 1.01:1
ButtonMinimalPerf.default 173 173 1:1
ButtonOverridesMissPerf.default 1681 1686 1:1
CheckboxMinimalPerf.default 2700 2700 1:1
InputMinimalPerf.default 1294 1292 1:1
ProviderMergeThemesPerf.default 1745 1744 1:1
RefMinimalPerf.default 248 249 1:1
AlertMinimalPerf.default 271 274 0.99:1
ChatMinimalPerf.default 728 738 0.99:1
ChatWithPopoverPerf.default 361 365 0.99:1
DropdownManyItemsPerf.default 686 691 0.99:1
HeaderSlotsPerf.default 789 798 0.99:1
ProviderMinimalPerf.default 1123 1137 0.99:1
SliderMinimalPerf.default 1702 1724 0.99:1
TableManyItemsPerf.default 1963 1985 0.99:1
TooltipMinimalPerf.default 1036 1046 0.99:1
ListNestedPerf.default 555 564 0.98:1
SkeletonMinimalPerf.default 370 376 0.98:1
DropdownMinimalPerf.default 3003 3102 0.97:1
FormMinimalPerf.default 405 416 0.97:1
MenuMinimalPerf.default 875 899 0.97:1
TreeWith60ListItems.default 176 181 0.97:1
FlexMinimalPerf.default 295 306 0.96:1
ListWith60ListItems.default 635 663 0.96:1
LayoutMinimalPerf.default 361 379 0.95:1

@Hotell Hotell added this to the February Project Cycle Q1 2022 milestone Feb 17, 2022
@ling1726 ling1726 merged commit ff78d1e into microsoft:master Feb 17, 2022
@ling1726 ling1726 mentioned this pull request Feb 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hotell Hotell Hotell approved these changes

Assignees

@tomi-msft tomi-msft

Labels

None yet

Projects

None yet

Milestone

February Project Cycle Q1 2022

Development

Successfully merging this pull request may close these issues.

create-react-app logs warnings for source maps with react-components

4 participants

@ling1726 @fabricteam @Hotell @tomi-msft