Current Behavior

• invalid packages bootstrap breaking CI ( exposed with new nx as they fixed workspace-lint vNext Combobox: add empty react-combobox package #21681 )
• wrong dep graph resolution:

graph TD;
  A["@fluentui/nx-workspace-tools"] --> B["@fluentui/react-button"]
  A --> C["@fluentui/react-text"]

New Behavior

• pipeline works (react-combobox, react-toolbar is bootstrapped properly)
• Fixed dep graph resolution:

graph TD;
  A["@fluentui/nx-workspace-tools"]
  B["@fluentui/react-button"]
  C["@fluentui/react-text"]

• added CI check to mitigate this in the future

Related Issue(s)

nrwl/nx#8938

Fixes #21811

NOTE 🚨 (Solved):

the TypeScript parsing issue underneath is even more tricky as the behaviour between CI and Local is non deterministic ( I was getting different AST parsing results between CI and Local 💣 - but in the end it looks like CI was correct )

Update: I turned off nx daemon on local machine as I thought that might be the root cause of different results between local and CI. Unfortunately the non deterministic behaviour is still present even after turning deamon off.

Update 2: I was able to correctly reproduce it on local, so now we can be assured it is deterministic on both CI and Local. Issue was in the end with daemon being turned on and myself running into weird state of cache graph during consecutive test runs. As an extended check, the node script that I added to CI will always remove the cache so one can have consistent repro on Local machine.

Update 3: So after additional debugging it turns out the root cause was yarn workspace 🍿.

• when I run node tools/check-dep-graph.js the output will be consistent with CI
• when I run yarn workspace @fluentui/nx-workspace-tools check-graph I will get inconsistent output ( no errors with repro 😶‍🌫️)

yarn workspaces changes cwd, I did that with nx executor as well - with nx changing cwd works as expected, not with yarn workspace

⬇⬇⬇

for reasons described I moved the check to nx workspace.json target so we have deterministic check