[nodejs] Update NodeJs version - add native support for lookbehind #1069

dfavretto · 2018-12-18T17:32:38Z

Depends on #1064 and #1065

Proposed Changes

Update NodeJS version reference:

In version 10.3.0, the NodeJS RegExp engine starts supporting Lookbehind Assertions and Named Capture Groups, enabling us to remove the code for pre & post processing the RegExp which contain Lookbehinds (unfortunately, the Named Capture Groups logic cannot be removed as repetead names still won't work properly).

Also, the update improves the performance in the tests, as there's less logic to execute for every test, making the execution time to drop.

iMicknl · 2018-12-28T22:09:15Z

Is Node 10.30.0 required after this PR or is it optional? If yes, this would be a breaking change and can also potential break a lot of BotBuilder-js bots, since they use Recognizers-Text in the botbuilder-dialogs package.

I would also suggest to add a engines property to the package.json, where you specifiy the minimum Nodejs version.

gasper-az · 2019-01-02T21:12:47Z

Is Node 10.30.0 required after this PR or is it optional? If yes, this would be a breaking change and can also potential break a lot of BotBuilder-js bots, since they use Recognizers-Text in the botbuilder-dialogs package.

I would also suggest to add a engines property to the package.json, where you specifiy the minimum Nodejs version.

Hi @iMicknl. The NodeJS v10.3.0 is required due to it being the first version which supports lookbehinds assertions and named groups natively.

Regarding the possible breaking changes, we have tested the botbuilder-dialogs package with a reference to a local package of recognizers-text with the actual PR's changes by referencing them through the package.json file in botbuilder-dialogs:

Then, we verified that these changes didn't break the project by running the tests cases as these screenshots show:
After running npm run build command:

Test results after running npm run test command:

Also, we created a PR (#709) which includes the NodeJS version update to v10.3.0 in BotBuilder-JS.

iMicknl · 2019-01-02T21:43:33Z

@GasparAcevedoZainSouthworks thanks! Most of the samples for botbuilder-js target Node.js version 8.5 or higher. In my opinion targeting 10.3.0, which is higher than the current Node.js LTS version (10.15.0), is too high for compatibility with botbuilder-dialogs. Or it should be a major version update due to breaking changes (semver).

@stevengum any thoughts? Which Node.js version is botbuilder-js actively targeting + what are people running nowadays in production.

gasper-az · 2019-01-03T18:12:26Z

@GasparAcevedoZainSouthworks thanks! Most of the samples for botbuilder-js target Node.js version 8.5 or higher. In my opinion targeting 10.3.0, which is higher than the current Node.js LTS version (10.15.0), is too high for compatibility with botbuilder-dialogs. Or it should be a major version update due to breaking changes (semver).

@stevengum any thoughts? Which Node.js version is botbuilder-js actively targeting + what are people running nowadays in production.

Hi @iMicknl. It seems that there is a misunderstanding regarding the targeting NodeJS version in this PR, because the actual one is not the v10.30.0 version, but it's the NodeJS v10.3.0, a lower version than the v10.15.0 (current LTS). However, it’s a good idea to use the current LTS version instead of the PR's one, so we are applying the necessary changes to accomplish this.

gasper-az · 2019-01-03T21:09:27Z

@iMicknl, we have tested the NodeJS version v10.15.0 (and the latest typescript version, v10.12.18) and this is the result of the tests execution in the Recognizers-text/JavaScript package:

These are the changes we applied (but didn't commit yet):
The engines property section in package.json file:

The @types/node version, also in package.json file:

If you agree with this, we will commit these changes.

Note: It's important to mention that in case the v.10.15.0 is applied, this PR will depend on the PR #1118, because of the exception explained there (Allocation Fail Error).

iMicknl · 2019-01-03T22:50:39Z

@GasparAcevedoZainSouthworks my apologies, you are right. I misread 10.3.0 for 10.30.0, however my point stays the same. I understand that the tests are running fine on the newer Node.js version and it is great that performance is improving, however we should keep current users in mind running a lower version of Node.js.

If we bump the minimum required Node.js version from 8.x to 10.x, it is a breaking change for current users of the package. According to semver the package version should also receive a major version bump (1.1.4 to 2.x at least).

botbuilder-dialogs has the package version pinned on 1.1.2, after the issues with 1.1.1. It won't affect the botbuilder-js package at the moment, however merging this PR without a major version bump can't affect other users of the package.

tellarin · 2019-01-07T04:06:34Z

@GasparAcevedoZainSouthworks, I think this is Ok to merge with the package.json you mentioned.
Can you also confirm that the SampleConsole works fine in multiple cultures in #1118? If it does, I'll merge that one first, then this PR with the updated package files.

Next release of the npm packages will follow a major version bump, as suggested by @iMicknl.

If there's no other concern, we can merge soon. Thanks.

tellarin · 2019-01-08T05:29:26Z

@GasparAcevedoZainSouthworks #1118 is merged. We can go ahead with this one after conflicts are resolved.

gasper-az · 2019-01-08T13:51:42Z

@tellarin The conflicts have been solved. Also, I updated the package.json file with the nodeJS v10.15.0.

stevengum · 2019-01-11T22:22:00Z

@iMicknl, we're going to keep targeting 8.x in botbuilder-js out of embedded scenario support and some cloud providers not yet supporting the active LTS. At the bare minimum I expect we'll drop 8.x support after it's maintenance period ends, which is Jan 2020.

@sgellock or @Stevenic if i'm wrong on any of the above please correct me.

stevengum · 2019-01-14T21:33:21Z

@iMicknl, @tellarin discussions are ongoing, so disregard my earlier statements. More to follow soon

stevengum · 2019-01-14T22:44:59Z

@iMicknl, @tellarin, we're moving to 10.3.0 with 4.3, which will drop in 1 month's time.

Add resources files

tellarin · 2019-02-02T08:19:38Z

@GasparAcevedoZainSouthworks I see that in one of the latest commit the node version is bumped to 10.12, but @stevengum mentioned 10.3 as the BotFramework target. How can we reach common ground here?

gasper-az · 2019-02-04T15:42:50Z

@tellarin the reason why we updated to v10.12.18 was that, at the moment when we created this PR, this was the latest version of @types/node which has native support for lookbehind assertions and named groups.

Also, if you check the Version History you'll see that when we created this PR, there were only two versions of @types/node v10.x.x: 10.12.17 & 10.12.18.

tellarin · 2019-02-19T08:43:38Z

@GasparAcevedoZainSouthworks I get the version changes in the PR history, my question was about syncing the final dependency to the node version that BotFramework 4.3 will target (referenced above in this PR's discussion).
Does everything work fine if we update this PR to depend on 10.3.0? If so, we can remove the [DO NOT MERGE] tag and prepare to merge soon.

gasper-az · 2019-02-19T13:37:24Z

@tellarin The PR now depends on 10.3.0.

commit 5a9e0c7 Author: Sanxing Chen <mestayinloves@gmail.com> Date: Wed Mar 27 15:57:46 2019 +0800 Enforce "week $num" to use ISO standard (microsoft#1509) * Enforce "week $num" to use ISO standard * Revise JS build process commit 0dc1abd Author: Börje Karlsson <tellarin@gmail.com> Date: Wed Mar 27 14:41:42 2019 +0800 Small code readability change in BaseNumberParser (microsoft#1510) commit 154ee9c Author: Börje Karlsson <tellarin@gmail.com> Date: Tue Mar 26 14:07:46 2019 +0800 Address vulnerability alert on jackson-databind > 2.9.6 (microsoft#1508) commit 3ac301c Author: Börje Karlsson <tellarin@gmail.com> Date: Mon Mar 25 15:58:07 2019 +0800 Minor renames, header adds, and warning fixes (microsoft#1505) * Fixing minor warnings to shorten build log. Current log is too long and gets truncated. * Fixing extra warnings to shorten build log. * Making static classes static. * Minor renames, adding headers. commit bf2e3c6 Author: Justin Wilaby <juwilaby@microsoft.com> Date: Thu Mar 21 01:46:41 2019 -0700 Fixes validation error in several yaml files (microsoft#1500) * Fixes validation error in several YAML files * Correcting YAML definition merge & regen resources. commit 9c1d78e Author: Börje Karlsson <tellarin@gmail.com> Date: Thu Mar 21 15:13:40 2019 +0800 Fixing JavaScript security issues flagged by GitHub (microsoft#1502) * Updating and testing lodash bump due to potential security issue in prototype pollution. * Updating handlebars package. Same sec issue. * Updating braces package. Potential regex DOS. commit b6e0447 Author: Cecilia Avila <44245136+ceciliaavila@users.noreply.github.com> Date: Wed Mar 20 22:34:04 2019 -0300 [DotNet][Samples] Update BotBuilderRecognizerBot sample to BotBuilder v4 (microsoft#1491) * Add new sample using BotBuilder v4 and Recognizers. * Add prompt for delivery date * Refactor code to improve readability * Clean the code and update README file commit e6edd5b Author: Börje Karlsson <tellarin@gmail.com> Date: Wed Mar 20 17:35:23 2019 +0800 Moving nuget package definitions to use <license> tag (microsoft#1499) * Moving nuget package definitions to use <license> tag. <licenseUrl> will be deprecated - https://docs.microsoft.com/en-us/nuget/consume-packages/finding-and-choosing-packages#license-url-deprecation * Updating nuget.exe to 4.9 * Removing unnecessary second nuget dependency. commit bdbc82a Author: Börje Karlsson <tellarin@gmail.com> Date: Tue Mar 19 18:59:44 2019 +0800 Fix build script for code signing (indentation now causes build break) (microsoft#1498) commit 9390de8 Author: Börje Karlsson <tellarin@gmail.com> Date: Tue Mar 19 12:05:11 2019 +0800 Minor cleanup (microsoft#1497) commit 1306b01 Author: Sanxing Chen <mestayinloves@gmail.com> Date: Tue Mar 19 10:59:07 2019 +0800 Revise French DateTimeExtractor (microsoft#1495) * Revise French DateTimeExtractor commit 7196d77 Author: Börje Karlsson <tellarin@gmail.com> Date: Wed Mar 13 15:31:28 2019 +0800 Update README.md commit 0931b3c Author: Börje Karlsson <tellarin@gmail.com> Date: Wed Mar 13 15:31:04 2019 +0800 Update README.md commit 8b7562c Author: Gwait <306414383@qq.com> Date: Tue Mar 12 16:15:05 2019 +0800 Support Sequence Recognizer for Email in Python (microsoft#1489) * Support Sequence Recognizer for Email in Python (microsoft#1023) commit f6df78c Author: Yuying Zhu <yuyzhu@outlook.com> Date: Mon Mar 11 17:38:39 2019 +0800 Matching US phone number without area code (microsoft#1170) (microsoft#1487) commit ed54e44 Author: Börje Karlsson <tellarin@gmail.com> Date: Mon Mar 11 16:58:10 2019 +0800 Update README.md commit 902deb3 Author: Yuying Zhu <yuyzhu@outlook.com> Date: Fri Mar 1 17:42:01 2019 +0800 Fix regression in time span extraction (microsoft#1484) * Fix the .Net and add test specs * Support other platforms commit 8a1b31a Author: Ali <mica.andini@gmail.com> Date: Fri Mar 1 01:33:19 2019 -0300 Modify .NET build script (change & to &&) (microsoft#1483) commit dec16d5 Author: Mu Guo <guom08@gmail.com> Date: Fri Mar 1 12:02:33 2019 +0800 Fix wrongly extracted DateRange in dash-separated sequence (microsoft#1477) * Fix wrongly extracted cases like "2100" in "Tel: 000 111 82-2100" * Remove duplicate test cases commit 274d020 Author: Sanxing Chen <mestayinloves@gmail.com> Date: Thu Feb 28 18:02:47 2019 +0800 Fix number thousand mark escape issue in Python (microsoft#1468) (microsoft#1480) commit 6ef2f52 Author: Mu Guo <guom08@gmail.com> Date: Thu Feb 28 16:09:21 2019 +0800 Fix bug related to wrong recognition when there are more than one time phrases present (microsoft#1479) * Fix the .Net and add test specs * Add fix in other languages and update resources commit 31bd36f Author: Mu Guo <guom08@gmail.com> Date: Wed Feb 27 13:51:21 2019 +0800 Fix Calendar.Mode regression in cases like "Tuesday, Jan 15, 1:00 PM - 1:15 PM" (microsoft#1476) * Fix Calendar.Mode regression in cases like "Tuesday, Jan 15, 1:00 PM - 1:15 PM" commit 8b836db Author: Mu Guo <guom08@gmail.com> Date: Wed Feb 27 11:32:16 2019 +0800 Fix wrong resolution regression in cases like "Monday 21 between 9:30 to 11:30" (microsoft#1474) * Fix cases like "Monday 21 between 9:30 to 11:30" commit ad20976 Author: Mu Guo <guom08@gmail.com> Date: Wed Feb 27 08:01:21 2019 +0800 Support cases like "between 0730-0930" (microsoft#1472) * Support cases like "between 0730-0930" commit a487f71 Author: Jin Wang <810256009@qq.com> Date: Wed Feb 27 07:58:58 2019 +0800 Support cases like "000 111 82-2100". (microsoft#1465) commit de04203 Author: Jin Wang <810256009@qq.com> Date: Tue Feb 26 18:54:57 2019 +0800 Support cases like "04th Jan 2019" (microsoft#1469) * Support cases like "04th Jan 2019" * Simplify the Regex. commit ec98484 Author: ya liu <401619741@qq.com> Date: Tue Feb 26 13:59:51 2019 +0800 Fix Spanish date period regex cases (microsoft#1460) * Fix Spanish DatePeriod Regex * Move Spanish cases to the right specs commit ba4f732 Author: HaoYangMS <45840378+HaoYangMS@users.noreply.github.com> Date: Thu Feb 21 18:42:15 2019 +0800 Modify "PeriodTimeOfDayWithDateRegex" and two test cases according to corresponding test cases in English. (microsoft#1466) * Modify "PeriodTimeOfDayWithDateRegex" and two test cases according to corresponding test cases in English. commit d39a8a4 Author: Börje Karlsson <tellarin@gmail.com> Date: Wed Feb 20 13:47:39 2019 +0800 Adding missing ACT timezones and remove duplicate entry in Spanish-Numbers.yaml (microsoft#1464) commit de47dc6 Author: Gaspar Acevedo Zain <43762887+GasparAcevedoZainSouthworks@users.noreply.github.com> Date: Wed Feb 20 01:22:39 2019 -0300 Fix regular expressions in .yaml files (microsoft#1065) * Fixed regular expressions and re-gen resources commit 199ffbc Author: Cecilia Avila <44245136+ceciliaavila@users.noreply.github.com> Date: Wed Feb 20 00:16:14 2019 -0300 [StyleCop] Make Build process fail on Stylecop issues (microsoft#1425) * Changed actions to error instead of warning * Make build process fail on StyleCop issues. * Fixed ruleset reference in Definitions.csproj * Add rule CS8019, unnecesary using directives. * [StyleCop] Fix all the warnings left - Reorder methods - Reorder usings - Create new files for classes - Reorder usings - Fix encoding * Solve remaining issues commit a7ee42f Author: David Favretto <david.favretto@southworks.com> Date: Tue Feb 19 22:38:45 2019 -0300 [nodejs] Update NodeJs version - add native support for lookbehind (microsoft#1069) * Fixed regular expressions in french/Italian * Applied changes to support new NodeJS v10.3.0 features * Updated node.js version * Add engines property to package.json file commit 5dbf26d Author: HaoYangMS <45840378+HaoYangMS@users.noreply.github.com> Date: Wed Feb 20 09:36:20 2019 +0800 Modify "PeriodTimeOfDayWithDateRegex" in Spanish to follow reference in English (microsoft#1463) commit 3dfc2d1 Author: HaoYangMS <45840378+HaoYangMS@users.noreply.github.com> Date: Tue Feb 19 15:26:46 2019 +0800 Implement "SpecificTimeFromTo" and "SpecificTimeBetweenAnd" in Spanish (microsoft#1459) * Implement "SpecificTimeFromTo" and "SpecificTimeBetweenAnd" in Spanish * Fix JavaScript test fail commit 63cb075 Author: Denise Scollo <dens.scollo@gmail.com> Date: Thu Feb 14 04:52:16 2019 -0300 [StyleCop] Fix all remaining warnings in all C# projects (microsoft#1458) * [StyleCop] Fix all warnings left - Reorder methods - Reorder usings - Create new files for classes - Reorder usings - Fix encoding commit 10fbe23 Author: Mick Vleeshouwer <mick@imick.nl> Date: Wed Feb 13 23:18:26 2019 -0800 [NL .NET] Improve first version of DateTimeV2 model (microsoft#1443) * Translate missing keys and update DateParser * Remove duplicate case * Update translations * Update patterns+ cases * Fix 2 more cases commit b3b5699 Author: HaoYangMS <45840378+HaoYangMS@users.noreply.github.com> Date: Thu Feb 14 11:49:51 2019 +0800 Fill in the blank of RestOfDateTimeRegex and add a new Unit "jornada" (microsoft#1453) commit 537c2ba Author: HaoYangMS <45840378+HaoYangMS@users.noreply.github.com> Date: Thu Feb 14 11:29:11 2019 +0800 fix "Ocurrirá 1/1/2015 entre las 10 h y las 11.30 h" and "Ocurrirá desde las 10.30 h hasta las 15 h de 1/1/15" (microsoft#1456) commit 0e5e528 Author: ya liu <401619741@qq.com> Date: Thu Feb 14 11:27:11 2019 +0800 Fix spanish dateperiod cases (microsoft#1457) * Fix spanish dateperiod cases * Fix Spanish dateperiod test cases * Fix Regex about Spanish DatePeriod commit 3b96774 Author: ya liu <401619741@qq.com> Date: Wed Feb 13 13:55:56 2019 +0800 Fix Spanish dateperiod cases (microsoft#1454) * Fix spanish dateperiod cases * Fix Spanish dateperiod test cases commit 36eab27 Author: HaoYangMS <45840378+HaoYangMS@users.noreply.github.com> Date: Wed Feb 13 13:50:49 2019 +0800 Fix TimeUnitRegex and RelativeTimeUnitRegex (microsoft#1455) commit 1e1cae9 Author: Gaspar Acevedo Zain <43762887+GasparAcevedoZainSouthworks@users.noreply.github.com> Date: Tue Feb 12 05:01:47 2019 -0300 [dotnet] Remove unused code from MergedDateTimeParser (microsoft#1450) * Update Japanese MergeDateTimeParser - Remove unused if statement * Update Japanese MergeDateTimeParser - Remove unused if statement commit 6b1812d Author: Denise Scollo <dens.scollo@gmail.com> Date: Tue Feb 12 05:01:08 2019 -0300 [StyleCop] Fix all the warnings in Dutch Parsers (microsoft#1446) - Reorder fields, properties, methods and constructors - Add and remove spaces when needed - Remove unnecessary parenthesis - Reorder using statements commit 1136dc2 Author: Denise Scollo <dens.scollo@gmail.com> Date: Tue Feb 12 04:59:12 2019 -0300 [StyleCop] Fix all the warnings in Dutch Extractors (microsoft#1445) - Reorder fields, properties, methods and constructors - Add and remove spaces when needed - Remove unnecessary parenthesis commit e5f0792 Author: Denise Scollo <dens.scollo@gmail.com> Date: Tue Feb 12 04:57:25 2019 -0300 [StyleCop]Fix all the remaining warnings in Number Project (microsoft#1444) - Rename local variable - Reorder methods - Remove regions - Add spacing commit 4af1e01 Author: Gaspar Acevedo Zain <43762887+GasparAcevedoZainSouthworks@users.noreply.github.com> Date: Tue Feb 12 04:56:17 2019 -0300 [StyleCop] Fix new warnings in Test TestHelpers (microsoft#1396) * [StyleCop] Fix new warnings in Test TestHelpers - Add files for classes: RecognizerExtensions, TestModelExtensions, TestResources, TestResourcesExtensions, TestUtils - Add ruleset to the project - Document enums - Add trailing comma - Add and remove spacing when needed * Fixed spacing in RecognizerExtensions file * Fixed remaining warnings in files. - Replaced "" for string.Empty in TestUtils commit 3bd0226 Author: ya liu <401619741@qq.com> Date: Tue Feb 12 15:54:36 2019 +0800 Fix spanish dateperiod cases (microsoft#1449) commit 215f2af Author: HaoYangMS <45840378+HaoYangMS@users.noreply.github.com> Date: Tue Feb 12 15:53:30 2019 +0800 fix a test spec. "de" means "from" here. (microsoft#1448) commit deaf3ce Author: HaoYangMS <45840378+HaoYangMS@users.noreply.github.com> Date: Tue Feb 12 15:51:52 2019 +0800 fix "Estaré afuera desde las 16 h de 1 de ene de 2016 hasta hoy a las 17 h" (microsoft#1451) * fix "Estaré afuera desde las 16 h de 1 de ene de 2016 hasta hoy a las 17 h" by adding "h" in AtRegex and * fix "Estaré afuera desde las 16 h de 1 de ene de 2016 hasta hoy a las 17 h" iteration 2. Modify the comments commit bfdd324 Author: Börje Karlsson <tellarin@gmail.com> Date: Sat Feb 2 16:02:17 2019 +0800 Removing unnecessary properties from SimpleConsole project. (microsoft#1441) commit a063aaa Author: Mu Guo <guom08@gmail.com> Date: Sat Feb 2 15:21:38 2019 +0800 Correct behaviour for "upcoming/past + weekday" (microsoft#1437) * Extend behaviour * Rename and reorganize regexes * Adjust the behavior of "following + weekday" commit 58f040c Author: JuanAr <juan.arguello@southworks.com> Date: Sat Feb 2 03:01:42 2019 -0300 [DotNet][DateTime] Fix extractors and parsers name in Japanese and Chinese languages (microsoft#1431) * Fix extractors and parsers class name in Chinese language * Fix extractors and parsers class name in Japanese language commit 0b2a0be Author: Mu Guo <guom08@gmail.com> Date: Sat Feb 2 13:59:07 2019 +0800 Support combination of modifiers (microsoft#1439) * Enable combination of modifiers * Fix the parsing of "modifier + daterange" commit 051eb9c Author: Mu Guo <guom08@gmail.com> Date: Sat Feb 2 12:25:08 2019 +0800 Filter out the wrong extraction for "may differ" (microsoft#1435) * Filter out "may differ" and update resources commit 3792a99 Author: Mick Vleeshouwer <mick@imick.nl> Date: Sat Feb 2 04:56:46 2019 +0100 [.NET DateTime] Enable NL DateParser tests + remove 2 tests (microsoft#1440) * Enable DateParser + remove 2 tests * Mark 2 cases as NotSupported for now * Remove duplicate case commit 050d1d0 Author: ya liu <401619741@qq.com> Date: Sat Feb 2 09:20:41 2019 +0800 Fix Spanish DatePeriod cases (microsoft#1438) * Fix Spanish DatePeriod cases * fix Spanish DatePeriod case and modify the error cases to right answer commit 938c9b9 Author: JuanAr <juan.arguello@southworks.com> Date: Tue Jan 29 23:30:39 2019 -0300 Refactor nested if-else, changed to a switch-case (microsoft#1433) commit 90d258d Author: JuanAr <juan.arguello@southworks.com> Date: Tue Jan 29 23:29:31 2019 -0300 Fix IDateTimeExtractor type to IDateExtractor in English and Spanish languages (microsoft#1432) commit 5ee2f38 Author: Nanhan Huang <38458025+Sothan@users.noreply.github.com> Date: Wed Jan 30 09:51:55 2019 +0800 Support WeekDayAndDay in DateTime model (microsoft#1416) * Support WeekDayAndDay, e.g., Monday 21 * Add a few comments and minor fix * Fixes according to the comments commit c11cde1 Author: Jin Wang <810256009@qq.com> Date: Tue Jan 29 19:41:29 2019 +0800 Support case “next” (microsoft#1400) * Support relative references like "last", "next one", "previous one" * Add specs * Regen python. * Regen JavaScript. * Support relative references like "last", "next one", "previous one" * Support "the second to last", "the one before the last one", etc. * Add base class. * Revise base class. * Support case "next". * Optimize the regex . * Add a EnablePreview option. * Fix bug. * Fix a bug. commit 935d186 Author: Gaspar Acevedo Zain <43762887+GasparAcevedoZainSouthworks@users.noreply.github.com> Date: Mon Jan 28 21:30:06 2019 -0300 [DotNet][DateTime] Rename YearAfterRegex as DateAfterRegex (microsoft#1417) * Renamed YearAfterRegex to DateAfterRegex. * Include of the modified DateTimeDefinitions files commit d892e38 Author: Gaspar Acevedo Zain <43762887+GasparAcevedoZainSouthworks@users.noreply.github.com> Date: Mon Jan 28 00:44:05 2019 -0300 Move EnglishDatetimeUtilityConfiguration class to utilities folder (microsoft#1423) commit 78cc381 Author: Gaspar Acevedo Zain <43762887+GasparAcevedoZainSouthworks@users.noreply.github.com> Date: Mon Jan 28 00:43:41 2019 -0300 [Java] Rename DinoComparer to StringComparer and update implementation (microsoft#1422) * Refactor DinoComparer - Change name to StringComparer - Polish implementation to make it more expressive commit df94960 Author: Gaspar Acevedo Zain <43762887+GasparAcevedoZainSouthworks@users.noreply.github.com> Date: Mon Jan 28 00:42:08 2019 -0300 [StyleCop] Add warning fixes generating Breaking Changes (microsoft#1420) * Fix all StyleCop's warnings in TextMatchers files - Reorder properties, fields and methods - Remove trailing whitespace - Add trailing comma - Reformat setters and getters * Fix all the StyleCop warnings in Parsers Files: -BaseMergedUnitParser.cs -INumberWithUnitParserConfiguration.cs Warnings: -SA1400 Class should declare an access modifier -SA1401 Field should be private -SA1122 Use string.Empty for empty strings * Fix all the StyleCop warnings in NumberWithUnitParser Warnings: -SA1401 Field should be private -SA1122 Use string.Empty for empty strings -SA1124 Do not use regions -Add file with the class UnitValue commit 78c6b58 Author: JuanAr <juan.arguello@southworks.com> Date: Mon Jan 28 00:41:08 2019 -0300 [StyleCop] Fix warnings in Text.Number Project (microsoft#1419) * Fix StyleCop warnings in SpanishNumberRangeParserConfiguration -Move constructor before properties -Move constructor initializers on their own line -Add class access modifier * Fix StyleCop warnings in Text.Number project -XML comment analysis warning * Fix StyleCop warning in NumberMode -Update comment to fix CS1570 XML comment on 'variable' has badly formed * Fix StyleCop warnings in BasePercentageExtractor -Reorder properties an fields -Set field to property to keep the variable name with upper-case -Add retuns comments in methods -Add trailing coma in multi-line initializers -Use String.Empty instead empty strings commit 8659d6e Author: Gaspar Acevedo Zain <43762887+GasparAcevedoZainSouthworks@users.noreply.github.com> Date: Mon Jan 28 00:38:50 2019 -0300 Fixed rangeConnectorRegex Pattern to public static (microsoft#1418) commit eb01e59 Author: JuanAr <juan.arguello@southworks.com> Date: Mon Jan 28 00:37:10 2019 -0300 [CI][DotNet] Add Code Analysis as part of build process (microsoft#1405) * Update install FxCopAnalyzers NuGet package in all projects of the solution * Add code analysis rules in the Recognizers-Text.ruleset * Add rule CA1021 (avoid out parameters) to Code Analysis ruleset commit 4442516 Author: JuanAr <juan.arguello@southworks.com> Date: Mon Jan 28 00:36:15 2019 -0300 [JavaScript] Rename DinoComparer to StringComparer and update implementation (microsoft#1404) * Rename DinoComparer to StringComparer and update implementation commit e0c9867 Author: Gaspar Acevedo Zain <43762887+GasparAcevedoZainSouthworks@users.noreply.github.com> Date: Thu Jan 24 23:38:37 2019 -0300 [StyleCop] Fix all the warnings in Definitions (microsoft#1409) * Fix StyleCop warnings in Definition csproj -Add rulset reference * Fix StyleCop's warnings in AssemblyInfo. - Added header to the file * Fix all the warnings in DefinitionLoader - Fixed spacing commit f9272ff Author: JuanAr <juan.arguello@southworks.com> Date: Thu Jan 24 23:24:59 2019 -0300 [StyleCop] Fix warnings in English and German TimeParser (microsoft#1411) * Fix StyleCop warnings in EnglishTimeParser -move constructor initializers on their own line * Fix StyleCop warnings in GermanTimeParser -move constructor initializers on their own line commit e3a7b4f Author: JuanAr <juan.arguello@southworks.com> Date: Thu Jan 24 23:24:39 2019 -0300 [StyleCop] Fix all the warnings in AssemblyInfo (microsoft#1412) - Remove trailing whitespace commit d111517 Author: JuanAr <juan.arguello@southworks.com> Date: Thu Jan 24 23:24:18 2019 -0300 Renamed variable for clarity in BaseDateParser (microsoft#1410) commit acd4323 Author: Gaspar Acevedo Zain <43762887+GasparAcevedoZainSouthworks@users.noreply.github.com> Date: Thu Jan 24 23:19:51 2019 -0300 Refactor DinoComparer to StringComparer (microsoft#1406) - Change DinoComparer to StringComparer for more clarity, refactored it's method for a better implementation - Fix NumberWithUnitExtractor to make it work with the new comparer commit ec19509 Author: Gaspar Acevedo Zain <43762887+GasparAcevedoZainSouthworks@users.noreply.github.com> Date: Thu Jan 24 23:17:51 2019 -0300 - Import and update the methods from `DateTimeFormatUtil` to `FormatUtil` class keeping them with the proper implementation. (microsoft#1403) - Remove duplicated `DateTimeFormatUtil` class - Refactor `FormatUtil` class name to `DateTimeFormatUtil` to keep the same pattern used in other languages commit 2ba1ab6 Author: JuanAr <juan.arguello@southworks.com> Date: Thu Jan 24 23:16:55 2019 -0300 Renamed regex variable 'AndRegex' to match used regex 'RangeConnectorRegex' (microsoft#1402) commit bea4527 Author: JuanAr <juan.arguello@southworks.com> Date: Thu Jan 24 23:16:11 2019 -0300 [DotNet][DateTime] Refactor GetModAndDate method since it has too many parameters (microsoft#1401) * Refactor BaseDatePeriodParser - GetModAndDate method since it has too many out/ref parameters - Created new class GetModAndDateResult containing the properties we need to return in the method GetModAndDate - Redesigned GetModAndDate method to remove the out/ref parameters and return an instance of a GetModAndDateResult object. * Renamed class 'GetModAndDateResult' to 'ModAndDateResult'

…icrosoft#1069) * Fixed regular expressions in french/Italian * Applied changes to support new NodeJS v10.3.0 features * Updated node.js version * Add engines property to package.json file

dfavretto force-pushed the southworks/implement-nodejs-v10-regex branch 2 times, most recently from 8a643fd to 830cb16 Compare December 18, 2018 20:15

guom08 mentioned this pull request Jan 3, 2019

Fix regular expressions in .yaml files #1065

Merged

gasper-az force-pushed the southworks/implement-nodejs-v10-regex branch from 54e10bc to d3f9c6e Compare January 8, 2019 13:12

tellarin self-assigned this Jan 15, 2019

gasper-az force-pushed the southworks/implement-nodejs-v10-regex branch from f7ce883 to 945ea24 Compare January 15, 2019 14:03

This was referenced Jan 15, 2019

Update @Types/Node to v10.12.18 southworks/botbuilder-js#26

Closed

Update @types/node to v10.12.18 microsoft/botbuilder-js#724

Merged

gasper-az added 6 commits January 28, 2019 11:03

Fixed regular expressions.-

f6936f7

Fixed regex in Italian-Datetime.yaml

2d83cb8

Add resources files

Updated node.js version

f6e13bc

Applied changes to support new NodeJS v10.3.0 features

b9ce4f4

Add engines property to package.json file

faf31d8

Update nodeJs version

bb2a0a5

gasper-az force-pushed the southworks/implement-nodejs-v10-regex branch from 945ea24 to bb2a0a5 Compare January 28, 2019 14:32

Merge branch 'master' into southworks/implement-nodejs-v10-regex

72c3655

Use NodeJS v10.3.0

5d6e298

dfavretto changed the title ~~[DO NOT MERGE][nodejs] Update NodeJs version - add native support for lookbehind~~ [nodejs] Update NodeJs version - add native support for lookbehind Feb 19, 2019

tellarin approved these changes Feb 20, 2019

View reviewed changes

tellarin merged commit a7ee42f into microsoft:master Feb 20, 2019

ceciliaavila deleted the southworks/implement-nodejs-v10-regex branch February 20, 2019 12:09

tellarin mentioned this pull request Mar 1, 2019

[Infra] Bugs in JavaScript lookbehind implementation #549

Closed

Batta32 mentioned this pull request Feb 3, 2021

[Java] Unify fallback bindLookbehind method for all JDKs #2439

Merged

[nodejs] Update NodeJs version - add native support for lookbehind #1069

[nodejs] Update NodeJs version - add native support for lookbehind #1069

Uh oh!

Conversation

dfavretto commented Dec 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed Changes

Update NodeJS version reference:

Uh oh!

iMicknl commented Dec 28, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gasper-az commented Jan 2, 2019

Uh oh!

iMicknl commented Jan 2, 2019

Uh oh!

gasper-az commented Jan 3, 2019

Uh oh!

gasper-az commented Jan 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iMicknl commented Jan 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tellarin commented Jan 7, 2019

Uh oh!

tellarin commented Jan 8, 2019

Uh oh!

gasper-az commented Jan 8, 2019

Uh oh!

stevengum commented Jan 11, 2019

Uh oh!

stevengum commented Jan 14, 2019

Uh oh!

stevengum commented Jan 14, 2019

Uh oh!

tellarin commented Feb 2, 2019

Uh oh!

gasper-az commented Feb 4, 2019

Uh oh!

tellarin commented Feb 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gasper-az commented Feb 19, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dfavretto commented Dec 18, 2018 •

edited

Loading

iMicknl commented Dec 28, 2018 •

edited

Loading

gasper-az commented Jan 3, 2019 •

edited

Loading

iMicknl commented Jan 3, 2019 •

edited

Loading

tellarin commented Feb 19, 2019 •

edited

Loading