Fix Spanish date period regex cases #1460

acblacktea · 2019-02-14T11:02:24Z

DatePeriodExtractor: ❌(4 of 365 still unsupported)

Fix Spanish DatePeriod cases below type.
1.va de año
2.el 3º cuarto del año que viene
3.durante más de 2 días antes de aye
4.Esta tarea debió ser terminada más de tres días antes

4 cases won't fix by design
1.Ya no estaré 3/15
2.en los 70
3.los noventa
4.En mil novecientos veintiocho

.NET/Microsoft.Recognizers.Definitions.Common/Spanish/DateTimeDefinitions.cs

tellarin · 2019-02-19T02:56:16Z

Specs/DateTime/Spanish/DatePeriodExtractor.json

    "Input": "En mil novecientos veintiocho",
-    "NotSupported": "dotnet, java",
-    "NotSupportedByDesign": "javascript, python",
+    "Comment": "Won't fix, because 'mil novecientos veintiocho' has ambiguity, will be extracted as number or datetime",


This is expected. Only numbers within a certain range are marked as potential years. Please go ahead to add support.

will support thanks

tellarin · 2019-02-19T02:56:46Z

Specs/DateTime/Spanish/DateParser.json

  },
  {
    "Input": "Volveré el vigesimo segundo de Junio",
+    "Debug": true,


Be careful not to leave Debug tags when committing a spec. I'll manually remove this one if this is the only issue to merge the PR.

will remove, thanks

tellarin · 2019-02-19T02:58:08Z

Specs/DateTime/Spanish/DatePeriodExtractor.json

    ]
  },
  {
-    "Input": "Ya terminé todos los trabajos hace más de 2 semanas",


Was the "hace más de 2 semanas" case really incorrect? It seems right to me.
If it's not really incorrect, please re-add it as a separate spec. Or did it just move elsewhere and it's hard for me to see in the diff?
Your new "durante" one sounds a little weird to me, but I'm not a native Spanish speaker.

yes "hace más de 2 semanas" is not dateperiod, I want to point out that the case and below cases you give comment all translated by English cases that format like "less than/more than $1 day before/after sometime", In order to match English Case, after follow the suggestion from intern who major in Spanish, I modify these cases. And "hace más de 2 semanas" is not belong to dateperiod，my opinion is to replace this cases, thanks

surely like "Ya terminé todos los trabajos hace más de 2 semanas", and cases below "Volveré dentro de 2 semanas""Volveré dentro de menos de 2 semanas" .... are also all correct, they just not have matched English dateperiod cases.

tellarin · 2019-02-19T02:59:29Z

Specs/DateTime/Spanish/DatePeriodExtractor.json

  {
-    "Input": "Volveré dentro de 2 semanas",
-    "NotSupported": "dotnet, java",
+    "Input": "dentro de 2 semanas a partir de hoy",


Why adding "a partir de hoy"? The meaning of "dentro de 2 semanas" seems very clear to me and it should be supported by itself.

4 cases won't fix by design
1.Ya no estaré 3/15
2.en los 70
3.los noventa
4.En mil novecientos veintiocho

The last one should be fixed. The same potentially ambiguous scenario applies in other languages.

Why not fix #1? And should cases #2 and #3 be changed to "los años 70" and similar?

#1 type is date not dateperiod
#2 #3 will modify case to "los años"
#4 will support in next version

because this sentences is translated from English DatePeriod Case "I will come back within 2 weeks from today" so I add "a partir de hoy" follow Intern's suggestion who major in Spanish, and "dentro de 2 semanas" is not belong to dateperiod，my opinion is to replace this cases, thanks

because this sentences is translated from English DatePeriod Case "I will come back within 2 weeks from today" so I add "a partir de hoy" follow Intern's suggestion who major in Spanish,also
"Volveré dentro de 2 semanas" is make sense, will support it

tellarin · 2019-02-19T03:00:39Z

Specs/DateTime/Spanish/DatePeriodExtractor.json

  {
-    "Input": "Volveré dentro de menos de 2 semanas",
-    "NotSupported": "dotnet, java",
+    "Input": "dentro de menos de 2 semanas a partir de hoy",


Don't remove other pieces of the sentence. If the input is "Volveré dentro de menos de 2 semanas", the response should be correct.

Ideally all spec cases should be full sentences.

Ideally all spec cases should be full sentences.

will modfiy spec cases

Don't remove other pieces of the sentence. If the input is "Volveré dentro de menos de 2 semanas", the response should be correct.

"dentro de menos de 2 semanas" is not "dateperiod " is belong to "duration", my opinion is to remove this sentence and save the new sentence, thanks

In that case it should be the full sentence "Volveré dentro de menos de 2 semanas a partir de hoy", right? Then we should make sure the duration spec includes the other case.

tellarin · 2019-02-19T03:02:11Z

Specs/DateTime/Spanish/DatePeriodExtractor.json

  {
-    "Input": "Esta tarea debió ser terminada más de tres días antes",
-    "NotSupported": "dotnet, java",
+    "Input": "durante más de 2 días antes de ayer",


Same. Please don't modify specs unless they are really incorrect.
Feel free to add as many new ones as possible though. In this case here, both the written numbers (e.g., "tres") or the numerals (e.g., "2") should be supported.

yes both the written numbers (e.g., "tres") or the numerals (e.g., "2") can be supported now. but "más de tres días antes" is a "duration" not belong to "daterange", that is our main question,so I modify this case

tellarin · 2019-02-19T03:03:48Z

Specs/DateTime/Spanish/DatePeriodExtractor.json

  {
-    "Input": "Esta tarea debe ser terminada en menos de 4 días",
-    "NotSupported": "dotnet, java",
+    "Input": "dentro de menos de 3 días a partir de mañana",


"Dentro de menos" is not exactly the same as "en menos de". The first form sounds strange to me.
But I'm not a native Spanish speaker. Also, we need to support both Spanish from Spain and from all Latin America. Before removing some form, we need to try to confirm if it's not common in specific countries.

Get it, the "dentro de menos de 3 días a partir de mañana" is translated from English DatePeriod cases "This task will be done less than 3 days after tomorrow", I will support both two cases in next pr

tellarin · 2019-02-19T03:27:34Z

4 cases won't fix by design
1.Ya no estaré 3/15
2.en los 70
3.los noventa
4.En mil novecientos veintiocho

The last one should be fixed. The same potentially ambiguous scenario applies in other languages.

Why not fix #1? And should cases #2 and #3 be changed to "los años 70" and similar?

…x_2_14

commit 5a9e0c7 Author: Sanxing Chen <mestayinloves@gmail.com> Date: Wed Mar 27 15:57:46 2019 +0800 Enforce "week $num" to use ISO standard (microsoft#1509) * Enforce "week $num" to use ISO standard * Revise JS build process commit 0dc1abd Author: Börje Karlsson <tellarin@gmail.com> Date: Wed Mar 27 14:41:42 2019 +0800 Small code readability change in BaseNumberParser (microsoft#1510) commit 154ee9c Author: Börje Karlsson <tellarin@gmail.com> Date: Tue Mar 26 14:07:46 2019 +0800 Address vulnerability alert on jackson-databind > 2.9.6 (microsoft#1508) commit 3ac301c Author: Börje Karlsson <tellarin@gmail.com> Date: Mon Mar 25 15:58:07 2019 +0800 Minor renames, header adds, and warning fixes (microsoft#1505) * Fixing minor warnings to shorten build log. Current log is too long and gets truncated. * Fixing extra warnings to shorten build log. * Making static classes static. * Minor renames, adding headers. commit bf2e3c6 Author: Justin Wilaby <juwilaby@microsoft.com> Date: Thu Mar 21 01:46:41 2019 -0700 Fixes validation error in several yaml files (microsoft#1500) * Fixes validation error in several YAML files * Correcting YAML definition merge & regen resources. commit 9c1d78e Author: Börje Karlsson <tellarin@gmail.com> Date: Thu Mar 21 15:13:40 2019 +0800 Fixing JavaScript security issues flagged by GitHub (microsoft#1502) * Updating and testing lodash bump due to potential security issue in prototype pollution. * Updating handlebars package. Same sec issue. * Updating braces package. Potential regex DOS. commit b6e0447 Author: Cecilia Avila <44245136+ceciliaavila@users.noreply.github.com> Date: Wed Mar 20 22:34:04 2019 -0300 [DotNet][Samples] Update BotBuilderRecognizerBot sample to BotBuilder v4 (microsoft#1491) * Add new sample using BotBuilder v4 and Recognizers. * Add prompt for delivery date * Refactor code to improve readability * Clean the code and update README file commit e6edd5b Author: Börje Karlsson <tellarin@gmail.com> Date: Wed Mar 20 17:35:23 2019 +0800 Moving nuget package definitions to use <license> tag (microsoft#1499) * Moving nuget package definitions to use <license> tag. <licenseUrl> will be deprecated - https://docs.microsoft.com/en-us/nuget/consume-packages/finding-and-choosing-packages#license-url-deprecation * Updating nuget.exe to 4.9 * Removing unnecessary second nuget dependency. commit bdbc82a Author: Börje Karlsson <tellarin@gmail.com> Date: Tue Mar 19 18:59:44 2019 +0800 Fix build script for code signing (indentation now causes build break) (microsoft#1498) commit 9390de8 Author: Börje Karlsson <tellarin@gmail.com> Date: Tue Mar 19 12:05:11 2019 +0800 Minor cleanup (microsoft#1497) commit 1306b01 Author: Sanxing Chen <mestayinloves@gmail.com> Date: Tue Mar 19 10:59:07 2019 +0800 Revise French DateTimeExtractor (microsoft#1495) * Revise French DateTimeExtractor commit 7196d77 Author: Börje Karlsson <tellarin@gmail.com> Date: Wed Mar 13 15:31:28 2019 +0800 Update README.md commit 0931b3c Author: Börje Karlsson <tellarin@gmail.com> Date: Wed Mar 13 15:31:04 2019 +0800 Update README.md commit 8b7562c Author: Gwait <306414383@qq.com> Date: Tue Mar 12 16:15:05 2019 +0800 Support Sequence Recognizer for Email in Python (microsoft#1489) * Support Sequence Recognizer for Email in Python (microsoft#1023) commit f6df78c Author: Yuying Zhu <yuyzhu@outlook.com> Date: Mon Mar 11 17:38:39 2019 +0800 Matching US phone number without area code (microsoft#1170) (microsoft#1487) commit ed54e44 Author: Börje Karlsson <tellarin@gmail.com> Date: Mon Mar 11 16:58:10 2019 +0800 Update README.md commit 902deb3 Author: Yuying Zhu <yuyzhu@outlook.com> Date: Fri Mar 1 17:42:01 2019 +0800 Fix regression in time span extraction (microsoft#1484) * Fix the .Net and add test specs * Support other platforms commit 8a1b31a Author: Ali <mica.andini@gmail.com> Date: Fri Mar 1 01:33:19 2019 -0300 Modify .NET build script (change & to &&) (microsoft#1483) commit dec16d5 Author: Mu Guo <guom08@gmail.com> Date: Fri Mar 1 12:02:33 2019 +0800 Fix wrongly extracted DateRange in dash-separated sequence (microsoft#1477) * Fix wrongly extracted cases like "2100" in "Tel: 000 111 82-2100" * Remove duplicate test cases commit 274d020 Author: Sanxing Chen <mestayinloves@gmail.com> Date: Thu Feb 28 18:02:47 2019 +0800 Fix number thousand mark escape issue in Python (microsoft#1468) (microsoft#1480) commit 6ef2f52 Author: Mu Guo <guom08@gmail.com> Date: Thu Feb 28 16:09:21 2019 +0800 Fix bug related to wrong recognition when there are more than one time phrases present (microsoft#1479) * Fix the .Net and add test specs * Add fix in other languages and update resources commit 31bd36f Author: Mu Guo <guom08@gmail.com> Date: Wed Feb 27 13:51:21 2019 +0800 Fix Calendar.Mode regression in cases like "Tuesday, Jan 15, 1:00 PM - 1:15 PM" (microsoft#1476) * Fix Calendar.Mode regression in cases like "Tuesday, Jan 15, 1:00 PM - 1:15 PM" commit 8b836db Author: Mu Guo <guom08@gmail.com> Date: Wed Feb 27 11:32:16 2019 +0800 Fix wrong resolution regression in cases like "Monday 21 between 9:30 to 11:30" (microsoft#1474) * Fix cases like "Monday 21 between 9:30 to 11:30" commit ad20976 Author: Mu Guo <guom08@gmail.com> Date: Wed Feb 27 08:01:21 2019 +0800 Support cases like "between 0730-0930" (microsoft#1472) * Support cases like "between 0730-0930" commit a487f71 Author: Jin Wang <810256009@qq.com> Date: Wed Feb 27 07:58:58 2019 +0800 Support cases like "000 111 82-2100". (microsoft#1465) commit de04203 Author: Jin Wang <810256009@qq.com> Date: Tue Feb 26 18:54:57 2019 +0800 Support cases like "04th Jan 2019" (microsoft#1469) * Support cases like "04th Jan 2019" * Simplify the Regex. commit ec98484 Author: ya liu <401619741@qq.com> Date: Tue Feb 26 13:59:51 2019 +0800 Fix Spanish date period regex cases (microsoft#1460) * Fix Spanish DatePeriod Regex * Move Spanish cases to the right specs commit ba4f732 Author: HaoYangMS <45840378+HaoYangMS@users.noreply.github.com> Date: Thu Feb 21 18:42:15 2019 +0800 Modify "PeriodTimeOfDayWithDateRegex" and two test cases according to corresponding test cases in English. (microsoft#1466) * Modify "PeriodTimeOfDayWithDateRegex" and two test cases according to corresponding test cases in English. commit d39a8a4 Author: Börje Karlsson <tellarin@gmail.com> Date: Wed Feb 20 13:47:39 2019 +0800 Adding missing ACT timezones and remove duplicate entry in Spanish-Numbers.yaml (microsoft#1464) commit de47dc6 Author: Gaspar Acevedo Zain <43762887+GasparAcevedoZainSouthworks@users.noreply.github.com> Date: Wed Feb 20 01:22:39 2019 -0300 Fix regular expressions in .yaml files (microsoft#1065) * Fixed regular expressions and re-gen resources commit 199ffbc Author: Cecilia Avila <44245136+ceciliaavila@users.noreply.github.com> Date: Wed Feb 20 00:16:14 2019 -0300 [StyleCop] Make Build process fail on Stylecop issues (microsoft#1425) * Changed actions to error instead of warning * Make build process fail on StyleCop issues. * Fixed ruleset reference in Definitions.csproj * Add rule CS8019, unnecesary using directives. * [StyleCop] Fix all the warnings left - Reorder methods - Reorder usings - Create new files for classes - Reorder usings - Fix encoding * Solve remaining issues commit a7ee42f Author: David Favretto <david.favretto@southworks.com> Date: Tue Feb 19 22:38:45 2019 -0300 [nodejs] Update NodeJs version - add native support for lookbehind (microsoft#1069) * Fixed regular expressions in french/Italian * Applied changes to support new NodeJS v10.3.0 features * Updated node.js version * Add engines property to package.json file commit 5dbf26d Author: HaoYangMS <45840378+HaoYangMS@users.noreply.github.com> Date: Wed Feb 20 09:36:20 2019 +0800 Modify "PeriodTimeOfDayWithDateRegex" in Spanish to follow reference in English (microsoft#1463) commit 3dfc2d1 Author: HaoYangMS <45840378+HaoYangMS@users.noreply.github.com> Date: Tue Feb 19 15:26:46 2019 +0800 Implement "SpecificTimeFromTo" and "SpecificTimeBetweenAnd" in Spanish (microsoft#1459) * Implement "SpecificTimeFromTo" and "SpecificTimeBetweenAnd" in Spanish * Fix JavaScript test fail commit 63cb075 Author: Denise Scollo <dens.scollo@gmail.com> Date: Thu Feb 14 04:52:16 2019 -0300 [StyleCop] Fix all remaining warnings in all C# projects (microsoft#1458) * [StyleCop] Fix all warnings left - Reorder methods - Reorder usings - Create new files for classes - Reorder usings - Fix encoding commit 10fbe23 Author: Mick Vleeshouwer <mick@imick.nl> Date: Wed Feb 13 23:18:26 2019 -0800 [NL .NET] Improve first version of DateTimeV2 model (microsoft#1443) * Translate missing keys and update DateParser * Remove duplicate case * Update translations * Update patterns+ cases * Fix 2 more cases commit b3b5699 Author: HaoYangMS <45840378+HaoYangMS@users.noreply.github.com> Date: Thu Feb 14 11:49:51 2019 +0800 Fill in the blank of RestOfDateTimeRegex and add a new Unit "jornada" (microsoft#1453) commit 537c2ba Author: HaoYangMS <45840378+HaoYangMS@users.noreply.github.com> Date: Thu Feb 14 11:29:11 2019 +0800 fix "Ocurrirá 1/1/2015 entre las 10 h y las 11.30 h" and "Ocurrirá desde las 10.30 h hasta las 15 h de 1/1/15" (microsoft#1456) commit 0e5e528 Author: ya liu <401619741@qq.com> Date: Thu Feb 14 11:27:11 2019 +0800 Fix spanish dateperiod cases (microsoft#1457) * Fix spanish dateperiod cases * Fix Spanish dateperiod test cases * Fix Regex about Spanish DatePeriod commit 3b96774 Author: ya liu <401619741@qq.com> Date: Wed Feb 13 13:55:56 2019 +0800 Fix Spanish dateperiod cases (microsoft#1454) * Fix spanish dateperiod cases * Fix Spanish dateperiod test cases commit 36eab27 Author: HaoYangMS <45840378+HaoYangMS@users.noreply.github.com> Date: Wed Feb 13 13:50:49 2019 +0800 Fix TimeUnitRegex and RelativeTimeUnitRegex (microsoft#1455) commit 1e1cae9 Author: Gaspar Acevedo Zain <43762887+GasparAcevedoZainSouthworks@users.noreply.github.com> Date: Tue Feb 12 05:01:47 2019 -0300 [dotnet] Remove unused code from MergedDateTimeParser (microsoft#1450) * Update Japanese MergeDateTimeParser - Remove unused if statement * Update Japanese MergeDateTimeParser - Remove unused if statement commit 6b1812d Author: Denise Scollo <dens.scollo@gmail.com> Date: Tue Feb 12 05:01:08 2019 -0300 [StyleCop] Fix all the warnings in Dutch Parsers (microsoft#1446) - Reorder fields, properties, methods and constructors - Add and remove spaces when needed - Remove unnecessary parenthesis - Reorder using statements commit 1136dc2 Author: Denise Scollo <dens.scollo@gmail.com> Date: Tue Feb 12 04:59:12 2019 -0300 [StyleCop] Fix all the warnings in Dutch Extractors (microsoft#1445) - Reorder fields, properties, methods and constructors - Add and remove spaces when needed - Remove unnecessary parenthesis commit e5f0792 Author: Denise Scollo <dens.scollo@gmail.com> Date: Tue Feb 12 04:57:25 2019 -0300 [StyleCop]Fix all the remaining warnings in Number Project (microsoft#1444) - Rename local variable - Reorder methods - Remove regions - Add spacing commit 4af1e01 Author: Gaspar Acevedo Zain <43762887+GasparAcevedoZainSouthworks@users.noreply.github.com> Date: Tue Feb 12 04:56:17 2019 -0300 [StyleCop] Fix new warnings in Test TestHelpers (microsoft#1396) * [StyleCop] Fix new warnings in Test TestHelpers - Add files for classes: RecognizerExtensions, TestModelExtensions, TestResources, TestResourcesExtensions, TestUtils - Add ruleset to the project - Document enums - Add trailing comma - Add and remove spacing when needed * Fixed spacing in RecognizerExtensions file * Fixed remaining warnings in files. - Replaced "" for string.Empty in TestUtils commit 3bd0226 Author: ya liu <401619741@qq.com> Date: Tue Feb 12 15:54:36 2019 +0800 Fix spanish dateperiod cases (microsoft#1449) commit 215f2af Author: HaoYangMS <45840378+HaoYangMS@users.noreply.github.com> Date: Tue Feb 12 15:53:30 2019 +0800 fix a test spec. "de" means "from" here. (microsoft#1448) commit deaf3ce Author: HaoYangMS <45840378+HaoYangMS@users.noreply.github.com> Date: Tue Feb 12 15:51:52 2019 +0800 fix "Estaré afuera desde las 16 h de 1 de ene de 2016 hasta hoy a las 17 h" (microsoft#1451) * fix "Estaré afuera desde las 16 h de 1 de ene de 2016 hasta hoy a las 17 h" by adding "h" in AtRegex and * fix "Estaré afuera desde las 16 h de 1 de ene de 2016 hasta hoy a las 17 h" iteration 2. Modify the comments commit bfdd324 Author: Börje Karlsson <tellarin@gmail.com> Date: Sat Feb 2 16:02:17 2019 +0800 Removing unnecessary properties from SimpleConsole project. (microsoft#1441) commit a063aaa Author: Mu Guo <guom08@gmail.com> Date: Sat Feb 2 15:21:38 2019 +0800 Correct behaviour for "upcoming/past + weekday" (microsoft#1437) * Extend behaviour * Rename and reorganize regexes * Adjust the behavior of "following + weekday" commit 58f040c Author: JuanAr <juan.arguello@southworks.com> Date: Sat Feb 2 03:01:42 2019 -0300 [DotNet][DateTime] Fix extractors and parsers name in Japanese and Chinese languages (microsoft#1431) * Fix extractors and parsers class name in Chinese language * Fix extractors and parsers class name in Japanese language commit 0b2a0be Author: Mu Guo <guom08@gmail.com> Date: Sat Feb 2 13:59:07 2019 +0800 Support combination of modifiers (microsoft#1439) * Enable combination of modifiers * Fix the parsing of "modifier + daterange" commit 051eb9c Author: Mu Guo <guom08@gmail.com> Date: Sat Feb 2 12:25:08 2019 +0800 Filter out the wrong extraction for "may differ" (microsoft#1435) * Filter out "may differ" and update resources commit 3792a99 Author: Mick Vleeshouwer <mick@imick.nl> Date: Sat Feb 2 04:56:46 2019 +0100 [.NET DateTime] Enable NL DateParser tests + remove 2 tests (microsoft#1440) * Enable DateParser + remove 2 tests * Mark 2 cases as NotSupported for now * Remove duplicate case commit 050d1d0 Author: ya liu <401619741@qq.com> Date: Sat Feb 2 09:20:41 2019 +0800 Fix Spanish DatePeriod cases (microsoft#1438) * Fix Spanish DatePeriod cases * fix Spanish DatePeriod case and modify the error cases to right answer commit 938c9b9 Author: JuanAr <juan.arguello@southworks.com> Date: Tue Jan 29 23:30:39 2019 -0300 Refactor nested if-else, changed to a switch-case (microsoft#1433) commit 90d258d Author: JuanAr <juan.arguello@southworks.com> Date: Tue Jan 29 23:29:31 2019 -0300 Fix IDateTimeExtractor type to IDateExtractor in English and Spanish languages (microsoft#1432) commit 5ee2f38 Author: Nanhan Huang <38458025+Sothan@users.noreply.github.com> Date: Wed Jan 30 09:51:55 2019 +0800 Support WeekDayAndDay in DateTime model (microsoft#1416) * Support WeekDayAndDay, e.g., Monday 21 * Add a few comments and minor fix * Fixes according to the comments commit c11cde1 Author: Jin Wang <810256009@qq.com> Date: Tue Jan 29 19:41:29 2019 +0800 Support case “next” (microsoft#1400) * Support relative references like "last", "next one", "previous one" * Add specs * Regen python. * Regen JavaScript. * Support relative references like "last", "next one", "previous one" * Support "the second to last", "the one before the last one", etc. * Add base class. * Revise base class. * Support case "next". * Optimize the regex . * Add a EnablePreview option. * Fix bug. * Fix a bug. commit 935d186 Author: Gaspar Acevedo Zain <43762887+GasparAcevedoZainSouthworks@users.noreply.github.com> Date: Mon Jan 28 21:30:06 2019 -0300 [DotNet][DateTime] Rename YearAfterRegex as DateAfterRegex (microsoft#1417) * Renamed YearAfterRegex to DateAfterRegex. * Include of the modified DateTimeDefinitions files commit d892e38 Author: Gaspar Acevedo Zain <43762887+GasparAcevedoZainSouthworks@users.noreply.github.com> Date: Mon Jan 28 00:44:05 2019 -0300 Move EnglishDatetimeUtilityConfiguration class to utilities folder (microsoft#1423) commit 78cc381 Author: Gaspar Acevedo Zain <43762887+GasparAcevedoZainSouthworks@users.noreply.github.com> Date: Mon Jan 28 00:43:41 2019 -0300 [Java] Rename DinoComparer to StringComparer and update implementation (microsoft#1422) * Refactor DinoComparer - Change name to StringComparer - Polish implementation to make it more expressive commit df94960 Author: Gaspar Acevedo Zain <43762887+GasparAcevedoZainSouthworks@users.noreply.github.com> Date: Mon Jan 28 00:42:08 2019 -0300 [StyleCop] Add warning fixes generating Breaking Changes (microsoft#1420) * Fix all StyleCop's warnings in TextMatchers files - Reorder properties, fields and methods - Remove trailing whitespace - Add trailing comma - Reformat setters and getters * Fix all the StyleCop warnings in Parsers Files: -BaseMergedUnitParser.cs -INumberWithUnitParserConfiguration.cs Warnings: -SA1400 Class should declare an access modifier -SA1401 Field should be private -SA1122 Use string.Empty for empty strings * Fix all the StyleCop warnings in NumberWithUnitParser Warnings: -SA1401 Field should be private -SA1122 Use string.Empty for empty strings -SA1124 Do not use regions -Add file with the class UnitValue commit 78c6b58 Author: JuanAr <juan.arguello@southworks.com> Date: Mon Jan 28 00:41:08 2019 -0300 [StyleCop] Fix warnings in Text.Number Project (microsoft#1419) * Fix StyleCop warnings in SpanishNumberRangeParserConfiguration -Move constructor before properties -Move constructor initializers on their own line -Add class access modifier * Fix StyleCop warnings in Text.Number project -XML comment analysis warning * Fix StyleCop warning in NumberMode -Update comment to fix CS1570 XML comment on 'variable' has badly formed * Fix StyleCop warnings in BasePercentageExtractor -Reorder properties an fields -Set field to property to keep the variable name with upper-case -Add retuns comments in methods -Add trailing coma in multi-line initializers -Use String.Empty instead empty strings commit 8659d6e Author: Gaspar Acevedo Zain <43762887+GasparAcevedoZainSouthworks@users.noreply.github.com> Date: Mon Jan 28 00:38:50 2019 -0300 Fixed rangeConnectorRegex Pattern to public static (microsoft#1418) commit eb01e59 Author: JuanAr <juan.arguello@southworks.com> Date: Mon Jan 28 00:37:10 2019 -0300 [CI][DotNet] Add Code Analysis as part of build process (microsoft#1405) * Update install FxCopAnalyzers NuGet package in all projects of the solution * Add code analysis rules in the Recognizers-Text.ruleset * Add rule CA1021 (avoid out parameters) to Code Analysis ruleset commit 4442516 Author: JuanAr <juan.arguello@southworks.com> Date: Mon Jan 28 00:36:15 2019 -0300 [JavaScript] Rename DinoComparer to StringComparer and update implementation (microsoft#1404) * Rename DinoComparer to StringComparer and update implementation commit e0c9867 Author: Gaspar Acevedo Zain <43762887+GasparAcevedoZainSouthworks@users.noreply.github.com> Date: Thu Jan 24 23:38:37 2019 -0300 [StyleCop] Fix all the warnings in Definitions (microsoft#1409) * Fix StyleCop warnings in Definition csproj -Add rulset reference * Fix StyleCop's warnings in AssemblyInfo. - Added header to the file * Fix all the warnings in DefinitionLoader - Fixed spacing commit f9272ff Author: JuanAr <juan.arguello@southworks.com> Date: Thu Jan 24 23:24:59 2019 -0300 [StyleCop] Fix warnings in English and German TimeParser (microsoft#1411) * Fix StyleCop warnings in EnglishTimeParser -move constructor initializers on their own line * Fix StyleCop warnings in GermanTimeParser -move constructor initializers on their own line commit e3a7b4f Author: JuanAr <juan.arguello@southworks.com> Date: Thu Jan 24 23:24:39 2019 -0300 [StyleCop] Fix all the warnings in AssemblyInfo (microsoft#1412) - Remove trailing whitespace commit d111517 Author: JuanAr <juan.arguello@southworks.com> Date: Thu Jan 24 23:24:18 2019 -0300 Renamed variable for clarity in BaseDateParser (microsoft#1410) commit acd4323 Author: Gaspar Acevedo Zain <43762887+GasparAcevedoZainSouthworks@users.noreply.github.com> Date: Thu Jan 24 23:19:51 2019 -0300 Refactor DinoComparer to StringComparer (microsoft#1406) - Change DinoComparer to StringComparer for more clarity, refactored it's method for a better implementation - Fix NumberWithUnitExtractor to make it work with the new comparer commit ec19509 Author: Gaspar Acevedo Zain <43762887+GasparAcevedoZainSouthworks@users.noreply.github.com> Date: Thu Jan 24 23:17:51 2019 -0300 - Import and update the methods from `DateTimeFormatUtil` to `FormatUtil` class keeping them with the proper implementation. (microsoft#1403) - Remove duplicated `DateTimeFormatUtil` class - Refactor `FormatUtil` class name to `DateTimeFormatUtil` to keep the same pattern used in other languages commit 2ba1ab6 Author: JuanAr <juan.arguello@southworks.com> Date: Thu Jan 24 23:16:55 2019 -0300 Renamed regex variable 'AndRegex' to match used regex 'RangeConnectorRegex' (microsoft#1402) commit bea4527 Author: JuanAr <juan.arguello@southworks.com> Date: Thu Jan 24 23:16:11 2019 -0300 [DotNet][DateTime] Refactor GetModAndDate method since it has too many parameters (microsoft#1401) * Refactor BaseDatePeriodParser - GetModAndDate method since it has too many out/ref parameters - Created new class GetModAndDateResult containing the properties we need to return in the method GetModAndDate - Redesigned GetModAndDate method to remove the out/ref parameters and return an instance of a GetModAndDateResult object. * Renamed class 'GetModAndDateResult' to 'ModAndDateResult'

* Fix Spanish DatePeriod Regex * Move Spanish cases to the right specs

Yang Liu added 2 commits February 14, 2019 18:49

Fix Spanish DatePeriod Regex

8175f5c

Fix Spanish DatePeriod Regex

18c2772

guom08 reviewed Feb 15, 2019

View reviewed changes

.NET/Microsoft.Recognizers.Definitions.Common/Spanish/DateTimeDefinitions.cs Outdated Show resolved Hide resolved

Yang Liu added 2 commits February 15, 2019 19:21

Fix Spanish DatePeriod Regex

3b6cab6

Fix Spanish DatePeriod Regex

5721f4a

tellarin requested changes Feb 19, 2019

View reviewed changes

tellarin changed the title ~~Fix Spanish date period regex~~ Fix Spanish date period regex cases Feb 19, 2019

Yang Liu added 2 commits February 22, 2019 14:37

Merge remote-tracking branch 'upstream/master' into FixDatePeriodRege…

900c211

…x_2_14

move Spanish Cases to the right position

13cd4a2

tellarin approved these changes Feb 26, 2019

View reviewed changes

tellarin merged commit ec98484 into microsoft:master Feb 26, 2019

aduqueanguera pushed a commit to Telefonica/Recognizers-Text that referenced this pull request May 20, 2020

Fix Spanish date period regex cases (microsoft#1460)

d36efae

* Fix Spanish DatePeriod Regex * Move Spanish cases to the right specs

Fix Spanish date period regex cases #1460

Fix Spanish date period regex cases #1460

Uh oh!

Conversation

acblacktea commented Feb 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

acblacktea Feb 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

acblacktea Feb 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

acblacktea Feb 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

acblacktea Feb 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

acblacktea Feb 21, 2019 • edited by tellarin Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

acblacktea Feb 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tellarin commented Feb 19, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

acblacktea commented Feb 14, 2019 •

edited

Loading

acblacktea Feb 19, 2019 •

edited

Loading

acblacktea Feb 19, 2019 •

edited

Loading

acblacktea Feb 19, 2019 •

edited

Loading

acblacktea Feb 19, 2019 •

edited

Loading

acblacktea Feb 21, 2019 •

edited by tellarin

Loading

acblacktea Feb 19, 2019 •

edited

Loading