This repository was archived by the owner on Jan 5, 2026. It is now read-only.
Update NodeJS v10.3.0 #709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build #1778
💛 - Coveralls |
cleemullins
reviewed
Jan 8, 2019
Contributor
cleemullins
left a comment
There was a problem hiding this comment.
Could you add the reason for the update to the Pull Request description?
I believe it's to pickup the newer RegEx libraries which support the look-ahead features and give parity with C# / Java / Python, which in turn cleans up the Recognizer library...
Contributor
|
Since we are supporting node 10 with this PR, we should update the tsconfig.json to target |
justinwilaby
suggested changes
Jan 9, 2019
Contributor
justinwilaby
left a comment
There was a problem hiding this comment.
Consider updating tsconfig files to target esnext
justinwilaby
approved these changes
Jan 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update NodeJS version to 10.3.0.
Specific Changes
libraries/botbuilder-ai/package.json@types/nodeto ^10.3.0.libraries/botbuilder-azure/package.json@types/nodeto ^10.3.0.libraries/botbuilder-dialogs/package.json@types/nodeto ^10.3.0.libraries/botbuilder/package.json@types/nodeto ^10.3.0.libraries/botbuilder-connector/package.json@types/nodeto ^10.3.0.libraries/botbuilder-schema/package.json@types/nodeto ^10.3.0.transcript/package.json@types/nodeto ^10.3.0.package-lock.json.