Rename and complete the entries for focus({preventScroll}) parameters#11328
Merged
queengooborg merged 1 commit intomdn:mainfrom Jun 30, 2021
Merged
Rename and complete the entries for focus({preventScroll}) parameters#11328queengooborg merged 1 commit intomdn:mainfrom
queengooborg merged 1 commit intomdn:mainfrom
Conversation
The naming now matches the guideline: https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines.md#parameters-and-parameter-object-features Chromium support for this parameter for SVGElement came when the focus() methods of HTMLElement and SVGElement were consolidated into HTMLOrForeignElement. Before that only the HTMLElement variant had the FocusOptions dictionary as an argument: https://chromium.googlesource.com/chromium/src/+/5f506297541b9c0a041701401eeb133a16619bf9 https://storage.googleapis.com/chromium-find-releases-static/5f5.html#5f506297541b9c0a041701401eeb133a16619bf9 The other data is mirrored and IE is just assumed to be false.
queengooborg
approved these changes
Jun 30, 2021
Contributor
queengooborg
left a comment
There was a problem hiding this comment.
Thanks @foolip, this is looking good to me!
ddbeck
added a commit
to ddbeck/browser-compat-data
that referenced
this pull request
Jul 1, 2021
ddbeck
added a commit
that referenced
this pull request
Jul 1, 2021
* Bump version to v3.3.10 * Add release note for #10958 * Add release note for #11061 * Add release note for #11062 * Add release note for #11266 * Add release note for #11276 * Add release note for #11307 * Add release note for #11317 * Add release note for #11323 * Add release note for #11328 * Add release note for #11334 * Fix formatting * Set release date * Add stats
queengooborg
pushed a commit
that referenced
this pull request
Oct 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The naming now matches the guideline:
https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines.md#parameters-and-parameter-object-features
Chromium support for this parameter for SVGElement came when the focus()
methods of HTMLElement and SVGElement were consolidated into
HTMLOrForeignElement. Before that only the HTMLElement variant had the
FocusOptions dictionary as an argument:
https://chromium.googlesource.com/chromium/src/+/5f506297541b9c0a041701401eeb133a16619bf9
https://storage.googleapis.com/chromium-find-releases-static/5f5.html#5f506297541b9c0a041701401eeb133a16619bf9
The other data is mirrored and IE is just assumed to be false.