Conversation
|
Pasting what @vinyldarkscratch said on chat since it covers what was spot checked:
|
| "version_added": "3.1" | ||
| }, | ||
| "safari_ios": { | ||
| "version_added": "3.2" |
There was a problem hiding this comment.
This was probably wrong, just 3.2 in both Safaris. iOS 2 is more likely. Since it will look like someone tried to convey "iOS support came after macOS" with these changes, is there any way to check if iOS 3.2 is correct?
There was a problem hiding this comment.
I actually think we should probably just get rid of this entry altogether, maybe? Taking a look at mask-border, it specifies -webkit-mask-box-image as an alternative name. (The data in mask-border also says Safari 3.1 / iOS 3, which leads me to believe iOS 3.2 is incorrect.)
I'll still be correcting the data before we consider removal though!
There was a problem hiding this comment.
This was just the first entry with iOS 3.2, there are a bunch and it would be good to look at all of them to see if the iOS data is likely to be wrong. (If left unchanged, it's more likely to look like a deliberate differences when the versions don't align.)
There was a problem hiding this comment.
I've gone through and updated all of the entries where both iOS and macOS are set to 3.2, and adjusted them! I've spot checked a few of the entries to confirm they're supposed to be in Safari 3.1, and none of them are entries that should vary in between iOS and macOS editions.
|
Gotta love it when you are deleting your local branch and accidentally select the remote... |
* Bump version to v3.3.10 * Add release note for #10958 * Add release note for #11061 * Add release note for #11062 * Add release note for #11266 * Add release note for #11276 * Add release note for #11307 * Add release note for #11317 * Add release note for #11323 * Add release note for #11328 * Add release note for #11334 * Fix formatting * Set release date * Add stats
This PR removes Safari 3.2 from BCD. After comparing the results collected from the mdn-bcd-collector project for both 3.1 and 3.2, I had only found one difference between them: the User Agent string. On top of that, I've spot checked a number of the entries reported as Safari 3.2 that the collector doesn't check, and found pretty much everything to be supported in Safari 3.1, so there is no need to track Safari 3.2 separately.