Conversation
- auto-deploy from beta branch instead, so that breaking changes on staging don't break the beta env
I'm using this in multiple PRs so I wanted to push it up.
Add AssignMessageSenderID helper function
(VDB-1459) Add msg.sender for maker.deal
(VDB-1464) Add msg.sender to Cat file vow
…-sender (VDB-1462) Add msg.sender to Cat file chop lump
(VDB-1533) Don't auto-deploy on merge to staging
Kind of wondering about its name since it also has expectations.
Vdb 1465 vow flog
vdb 1417 sender tend
* Add msg sender to dent table * Add msg.sender to dent events in query, repository and component tests * Remove MsgSender from DentCreationInput * Address PR feedback * Use AssignMessageSenderID for dent tests
* Add msg.sender to jug_file_base * Add msg.sender to jug_file_ilk * Add msg_sender to jug_file_vow * Use GetChecksumAddress to get msg sender * Reformatting jug_file test data * Use AssignMessageSenderID helper for jug file tests * Address PR feedback
- Fix all ilk file events query test, this re-adds the CreateTestLogFromEventLog function I used elsewhere.
Even I miss this
Vdb 1463 Flip
Adds address_id to log_value
- remove Oasis tables from schema - remove Oasis transformer code + config - remove Oasis test data + integration tests
So that execute will now check it, instead of the public.headers table.
This version has the CheckedHeadersRepository that respects a schema name. It meant updating the integration tests, which is a good thing, as it shows the repository works.
It's an integration test because it "integrates" with vulcanizedb and there's no repository on the plugin side.
Use the provided helper method from vulcanizedb, and update to the "latest" one in the branch so that it is present.
This is needed, primarily for compose command.
This removes the hanging execute problem we've been having. This meant a slight modification to startup_script - to make sure it is run as bash not sh. Otherwise source doesn't work.
This is required for make execute, not sure why it wasn't required. Also make sure the PORT is used for the PORT mapping too.
Meant making sure the script file was bash.
Buster is the newer Debian release and allows us to use 15.2
Busybox is used by the wait-for-it script and was already present on alpine.
I didn't rename all references since the process is still named execute, it's just the docker image that is namespaced.
- also update vdb to use version with updated go
- required to build when vendor directory is present, as happens in current execute dockerfile
* Use test_config.SetTestConfig() in 0.go * Remove testing.toml and mcdTransformers.toml config files And instead use the docker.toml file and merge in test specific database specifics for testing. For local development this means we'll need to pass in docker.toml, and then set db params via env vars. * Add COMP * Add LINK * Add LRC * Clarify test config setup in integration tests * Rename docker.toml -> mcdTransformers.toml since it's now being used for testing and local development in addition to docker now * Update README to account for new config file setup * Update backfill config files * Address PR feedback
(VDB-1526) Remove remaining references to Oasis
…#335) * Use test_config file to setup a test blockchain for integration tests * Remove returning error from getBlockChain test helper * Removed now unused testing.toml file
elizabethengelman
approved these changes
Oct 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.