VDB-1443 msg sender for jug file#229
Merged
elizabethengelman merged 7 commits intobreaking-changesfrom Jul 22, 2020
Merged
Conversation
ffcbb30 to
9558e67
Compare
9558e67 to
fa9f811
Compare
paytonrules
reviewed
Jul 21, 2020
paytonrules
reviewed
Jul 21, 2020
| ) | ||
|
|
||
| BeforeEach(func() { | ||
| test_config.CleanTestDB(db) |
Contributor
There was a problem hiding this comment.
🎉 - although now I think I may need to add this to some of my tests.....
paytonrules
reviewed
Jul 21, 2020
| } | ||
|
|
||
| msgSender := shared.GetChecksumAddressString(log.Log.Topics[1].Hex()) | ||
| msgSenderId, msgSenderErr := shared.GetOrCreateAddress(msgSender, db) |
Contributor
There was a problem hiding this comment.
Probably want msgSenderID - the linter will get it eventually. Not a blocker.
paytonrules
approved these changes
Jul 21, 2020
| Expect(err).NotTo(HaveOccurred()) | ||
|
|
||
| var ilkID int64 | ||
| ilkErr := db.Get(&ilkID, `SELECT id FROM maker.ilks where ilk = $1`, test_data.JugFileIlkEventLog.Log.Topics[2].Hex()) |
Contributor
There was a problem hiding this comment.
Not technically your code - but you could replace this with
ilkID, ilkIDErr := shared.GetOrCreateIlk(test_data.JugFileIlkEventLog.Log.Topics[2].Hex(), db)
Expect(ilkIDErr).NotTo(HaveOccurred())
752ff24 to
1ee5bee
Compare
1ee5bee to
23ffdb4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.