Skip to content

Adds address_id to log_value#222

Merged
yaoandrew merged 2 commits intobreaking-changesfrom
vdb-1428-addressId-log-value
Jul 23, 2020
Merged

Adds address_id to log_value#222
yaoandrew merged 2 commits intobreaking-changesfrom
vdb-1428-addressId-log-value

Conversation

@yaoandrew
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@rmulhol rmulhol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this temporarily since it's a breaking change

@paytonrules
Copy link
Copy Markdown
Contributor

@yaoandrew - mostly so it doesn't get lost, I bet you could rebase this to breaking-changes.

@yaoandrew yaoandrew changed the base branch from staging to breaking-changes July 20, 2020 19:32
@yaoandrew yaoandrew requested review from paytonrules and rmulhol July 20, 2020 19:33
Copy link
Copy Markdown
Contributor

@rmulhol rmulhol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Comment thread transformers/events/log_value/transformer.go Outdated
Comment thread transformers/events/log_value/transformer.go
Comment thread transformers/events/log_value/transformer.go Outdated
Comment thread transformers/events/log_value/transformer.go Outdated
Comment thread db/migrations/20191118031513_create_log_value.sql Outdated
@yaoandrew yaoandrew force-pushed the vdb-1428-addressId-log-value branch from 5ce7e5f to efbb605 Compare July 23, 2020 19:02
@yaoandrew yaoandrew merged commit 77f3d71 into breaking-changes Jul 23, 2020
@yaoandrew yaoandrew deleted the vdb-1428-addressId-log-value branch July 23, 2020 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants