Merged
Conversation
8c8ccc5 to
e580591
Compare
elizabethengelman
approved these changes
Jul 21, 2020
Contributor
elizabethengelman
left a comment
There was a problem hiding this comment.
This LGTM once the build passes. I looked at it briefly, and it seems like it could be failing on an integration test that times out because the build in general seems to be slow today.
250120f to
ebae3c2
Compare
ebae3c2 to
b0491b6
Compare
- Fix all ilk file events query test, this re-adds the CreateTestLogFromEventLog function I used elsewhere.
Even I miss this
b0491b6 to
0e80fa5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.