Conversation
LocalStack integration with Pro 1 files - 2 1 suites - 2 1h 7m 29s ⏱️ - 25m 55s For more details on these failures, see this check. Results for commit b0af983. ± Comparison against base commit 6e81652. ♻️ This comment has been updated with latest results. |
efa44f5 to
c7e3574
Compare
Contributor
|
Note: we have 53 failed tests for now, to keep track of progress. |
95f7015 to
ee6e477
Compare
ee6e477 to
d63f96e
Compare
Contributor
|
We are at 92 tests failing for this branch before merging any functionality. |
d63f96e to
b20cb40
Compare
b20cb40 to
aa63747
Compare
b26243f to
61fd406
Compare
61fd406 to
3fd44cc
Compare
3fd44cc to
c68804b
Compare
c68804b to
65c59e7
Compare
ac57d07 to
0b64b70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR should remain minimal in terms of code changes, and is mostly used for keeping track of the PRs regarding the new s3 provider going directly into master and for tracking test failure rates against the new provider.
PRs
The following PRs have been created to fully implement the new s3 provider:
Tasks
Migrate all s3 tests to pytest and validates them against AWS
Create the new ASF provider
Allow patching of botocore specs to match actual AWS behaviour
Reroute virtual host addressed requests as path addressed ones to take advantage of the builtin ASF routing
Implement major S3 features:
Fix ongoing issues with current provider not tackled in above major features
Implement the Pro provider
Implement S3 ASF test job for CircleCI