deactivate VirtualHostRewriter for s3 ASF#7065
Merged
Conversation
21 tasks
9244134 to
c1f66b1
Compare
c1f66b1 to
880cecd
Compare
Member
Author
|
Remaining test failures are flaky tests, addressed in #7070. Edit: run tests once more with |
880cecd to
ed4608d
Compare
ed4608d to
a61dbdc
Compare
a61dbdc to
fae1634
Compare
alexrashed
approved these changes
Nov 11, 2022
Member
alexrashed
left a comment
There was a problem hiding this comment.
Nice! This PR removes code from the parser, which shouldn't have been there in the first place.
I think in the long run, this will become a pattern for more services (at this point it might make sense to introduce a specific lifecycle hook or something similar). 🚀
fcff535 to
6b9a98e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deactivates the
VirtualHostRewriterif the ASF provider for S3 is activated.S3 virtual host routes are registered
on_infra_readyto ensure the hosts are resolved correctly, even if s3 is not yet loaded (this requirement was revealed by the terraform test suite).