Skip to content

remove legacy init scripts /docker-entrypoint-initaws.d#7864

Merged
thrau merged 1 commit intov2from
v2-remove-legacy-init-scripts
Mar 15, 2023
Merged

remove legacy init scripts /docker-entrypoint-initaws.d#7864
thrau merged 1 commit intov2from
v2-remove-legacy-init-scripts

Conversation

@thrau
Copy link
Member

@thrau thrau commented Mar 14, 2023

This PR removes the legacy /docker-entrypoint-initaws.d in favor of the modern Init hooks according to our deprecation notice of v1.3.

@thrau thrau requested a review from alexrashed March 14, 2023 15:45
@thrau thrau marked this pull request as ready for review March 14, 2023 15:45
@thrau thrau temporarily deployed to localstack-ext-tests March 14, 2023 15:45 — with GitHub Actions Inactive
@thrau thrau changed the base branch from master to v2 March 14, 2023 15:45
@coveralls
Copy link

Coverage Status

Coverage: 85.152% (+0.03%) from 85.127% when pulling d620545 on v2-remove-legacy-init-scripts into 863d750 on v2.

@github-actions
Copy link

github-actions bot commented Mar 14, 2023

LocalStack integration with Pro

       3 files  ±0         3 suites  ±0   1h 40m 27s ⏱️ - 5m 21s
1 798 tests ±0  1 416 ✔️ ±0  382 💤 ±0  0 ±0 
2 524 runs  ±0  1 790 ✔️ ±0  734 💤 ±0  0 ±0 

Results for commit d620545. ± Comparison against base commit fd25513.

♻️ This comment has been updated with latest results.

Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 Great to finally see the end of the deprecation path 😜

@thrau thrau temporarily deployed to localstack-ext-tests March 15, 2023 13:30 — with GitHub Actions Inactive
@thrau thrau merged commit 3c8cae6 into v2 Mar 15, 2023
@thrau thrau deleted the v2-remove-legacy-init-scripts branch March 15, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants