Merged
Conversation
21 tasks
LocalStack integration with Pro 1 files - 2 1 suites - 2 50m 19s ⏱️ - 33m 12s Results for commit 2a78b26. ± Comparison against base commit 472f457. ♻️ This comment has been updated with latest results. |
93cecbf to
2a78b26
Compare
thrau
approved these changes
Oct 10, 2022
Member
thrau
left a comment
There was a problem hiding this comment.
Great set of changes! 🚀 so close now!!
dominikschubert
approved these changes
Oct 10, 2022
Member
dominikschubert
left a comment
There was a problem hiding this comment.
Regarding test_cloudformation_legacy.py. They are as the name implies legacy tests that don't have a specific purpose right now. They'll either be rewritten or dropped fairly soon, so just making sure they're still green is fine in this instance 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the last small fixes to get the tests green in community.
S3Storeto beCrossRegionAttribute, as a bucket can only be created in one region, and its configuration can be accessed from anywhere.Locationheader inCompleteMultipartUploadresponseGetObjectAttributesoperation, which is not implemented at all in moto (a mix ofHeadObjectandListPartstest_edge.pythat were related to S3 and the old proxy listener behaviour.test_cloudformation_legacy.py: for s3 notifications configuration, when you set a target for notifications, S3 will check that the target exists by default. The provided ARN was computed using the region of the S3 bucket, but the actual queue was created inus-east-1by CFn. Not sure what the expected behaviour was, but computing the ARN to match the actual created queue's ARN fixed the test.