Skip to content

🐛 fix(hetero): stop cross-message text duplication in server-ingest mode#15585

Merged
arvinxx merged 1 commit into
canaryfrom
fix/lobe-10157-remote-cc-execution-records
Jun 9, 2026
Merged

🐛 fix(hetero): stop cross-message text duplication in server-ingest mode#15585
arvinxx merged 1 commit into
canaryfrom
fix/lobe-10157-remote-cc-execution-records

Conversation

@arvinxx

@arvinxx arvinxx commented Jun 9, 2026

Copy link
Copy Markdown
Member

💻 Change Type

  • 🐛 fix

🔗 Related Issue

Part of LOBE-10157 (Bug 3 of 3). Bug 1 (no agent_operations / trace snapshot) and Bug 2 (empty tool result) are tracked separately in the same issue.

🔀 Description of Change

Remote-device Claude Code and cloud-sandbox CC both run through lh hetero exec (spawnLhHeteroExec for devices, spawnHeteroSandbox on the server) and share the producer-side SerialServerIngester.

Bug: SerialServerIngester.accumulatedText is a per-message text accumulator that coalesces a message's text deltas into one snapshotMode: 'replace' snapshot. But it was never reset across assistant-message boundaries, so it spanned the whole run. Each new message's snapshot therefore re-emitted all prior messages' text verbatim, and the server persisted that into the new DB message — producing the cross-message text duplication seen in topic tpc_IkEBRHI18qdY (a later assistant message containing an earlier one's full text + its own).

Fix: reset accumulatedText on stream_start / stream_end boundary events (emitted by the adapter's openMainMessage), after flushing the just-ended message's pending snapshot. Each message now snapshots only its own text. One fix covers both the device and sandbox paths.

Verified against raw claude stream-json: the upstream CC output is clean (each assistant message carries only its own text), confirming the duplication is introduced in lobehub's ingest pipeline, not by Claude Code.

🧪 How to Test

  • Added/updated tests

Added a regression test in hetero.test.ts: two assistant messages separated by a stream_end/stream_start boundary must each snapshot only their own text (['first message', 'second message'], not ['first message', 'first messagesecond message']). Confirmed the test fails without the fix and passes with it. Full hetero.test.ts suite (20 tests) green.

📝 Additional Information

Scope note: this is the highest-confidence, reproducible part of LOBE-10157. The remaining two bugs need separate work — Bug 1 is a server-side operation/trace gap in the heterogeneous ingest path; Bug 2 (empty tool result) was shown not to be an adapter extraction bug and needs the actual failing run's raw stream to root-cause.

In server-ingest mode (remote-device CC and cloud sandbox both run
`lh hetero exec`), SerialServerIngester's `accumulatedText` spanned the
whole run and never reset across assistant-message boundaries. Combined
with `snapshotMode: 'replace'`, every later message's snapshot re-emitted
all prior messages' text verbatim, which the server persisted into the
new DB message — producing cross-message text duplication.

Reset `accumulatedText` on `stream_start` / `stream_end` (emitted by the
adapter's `openMainMessage`) after flushing the just-ended message's
snapshot, so each message snapshots only its own text.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jun 9, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @arvinxx, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@vercel

vercel Bot commented Jun 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
lobehub Building Building Preview, Comment Jun 9, 2026 9:34am

Request Review

@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.42%. Comparing base (77dbe4b) to head (1e6fb11).
⚠️ Report is 5 commits behind head on canary.

Additional details and impacted files
@@             Coverage Diff             @@
##           canary   #15585       +/-   ##
===========================================
- Coverage   88.76%   70.42%   -18.34%     
===========================================
  Files         905     3327     +2422     
  Lines      110729   333604   +222875     
  Branches    10961    30357    +19396     
===========================================
+ Hits        98285   234935   +136650     
- Misses      12261    98486    +86225     
  Partials      183      183               
Flag Coverage Δ
app 61.31% <ø> (?)
database 89.90% <ø> (ø)
packages/agent-manager-runtime 49.69% <ø> (ø)
packages/agent-runtime 81.06% <ø> (ø)
packages/builtin-tool-lobe-agent 18.52% <ø> (ø)
packages/context-engine 84.12% <ø> (ø)
packages/conversation-flow 91.29% <ø> (ø)
packages/device-gateway-client 90.18% <ø> (ø)
packages/eval-dataset-parser 95.15% <ø> (ø)
packages/eval-rubric 76.11% <ø> (ø)
packages/fetch-sse 85.57% <ø> (-1.72%) ⬇️
packages/file-loaders 87.89% <ø> (ø)
packages/memory-user-memory 74.99% <ø> (ø)
packages/model-bank 99.99% <ø> (ø)
packages/model-runtime 84.19% <ø> (ø)
packages/prompts 72.51% <ø> (ø)
packages/python-interpreter 92.90% <ø> (ø)
packages/ssrf-safe-fetch 0.00% <ø> (ø)
packages/types 35.23% <ø> (ø)
packages/utils 85.06% <ø> (ø)
packages/web-crawler 88.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Store 68.23% <ø> (∅)
Services 54.21% <ø> (∅)
Server 70.65% <ø> (∅)
Libs 55.89% <ø> (∅)
Utils 82.08% <ø> (-17.92%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arvinxx arvinxx merged commit b295265 into canary Jun 9, 2026
39 of 40 checks passed
@arvinxx arvinxx deleted the fix/lobe-10157-remote-cc-execution-records branch June 9, 2026 10:27
arvinxx added a commit that referenced this pull request Jun 10, 2026
# 🚀 LobeHub Release (20260610)

**Release Date:** June 10, 2026  
**Since v2.2.2:** 131 merged PRs · 13 contributors

> This weekly release strengthens agent collaboration across cloud,
desktop, CLI, and workspace flows, with steadier runtime behavior and a
broader foundation for workspace-scoped data.

---

## ✨ Highlights

- **Agent execution across devices** — Unifies per-device working
directories, project skill discovery, and sub-agent suspend/resume
behavior across server, QStash, and device RPC flows. (#15543, #15566,
#15481, #15620, #15591)
- **Connector and sandbox platform** — Expands connector permissions,
custom OAuth MCP connector onboarding, sandbox provider support, and
user-uploaded file sync into cloud sandbox runs. (#15463, #15546,
#15184, #15550)
- **Desktop and CLI reliability** — Fixes desktop cold-start,
auto-update, Windows build, CLI skill discovery, and `lh connect` agent
dispatch paths. (#15547, #15525, #15527, #15562, #15632, #15634)
- **Pages and sharing** — Refreshes topic sharing, improves Page Editor
layout behavior, and routes Page Agent tool execution through the
server-side editor path. (#15581, #15556, #15588, #15023, #15610)
- **Model availability and provider updates** — Adds user-scoped LobeHub
model availability, Claude Fable 5, Qwen thinking preservation, and
MiniMax M3 updates. (#15590, #15639, #13494, #15376)

---

## 🏗️ Core Product & Architecture

### Agent Runtime & Heterogeneous Agents

- Improves sub-agent lifecycle handling, including async suspend/resume,
queue-mode QStash resume delivery, and blocking nested sub-agent calls.
(#15481, #15620, #15575)
- Stabilizes heterogeneous agent ingestion and streaming with raw stream
dumps, per-turn usage, image forwarding on regenerate, and
duplicate-text fixes. (#15602, #15577, #15592, #15585)
- Adds execution-device and working-directory controls across device
RPC, legacy defaults, and remote-spawned Claude Code sessions. (#15543,
#15566, #15591, #15572)
- Improves runtime diagnostics and compatibility, including Gemini
multimodal output capture, abort stream semantics, and trace quality
analysis. (#15535, #13677, #15508)

---

## 📱 Platforms, Integrations & UX

### Connectors, Sandbox & Tools

- Ships API-level connector tool permissions, custom OAuth MCP connector
onboarding, and connector-first runtime execution. (#15463, #15546)
- Adds sandbox provider support, cloud sandbox file sync, and safer
external URL file input handling with SSRF validation. (#15184, #15550,
#12657)
- Improves tool visibility and execution with pinned app-fixed tools,
ANSI output rendering, gateway-tunneled MCP calls, and automatic
headless tool runs. (#15509, #15516, #15469, #15492)

### Desktop, CLI & Web UX

- Restores desktop startup and reload behavior, preserves IPC error
causes, and keeps the tab bar new-tab action visible across routes.
(#15547, #15597, #15638)
- Fixes desktop update and build stability for browser quit guards,
macOS update signing, and Windows Visual Studio detection. (#15525,
#15527, #15562)
- Shows the plan-limit upgrade UI on desktop builds. (#15628)
- Adds the Agent Run delivery checker and fixes CLI device dispatch plus
skill list/search output. (#15489, #15634, #15632)
- Refreshes onboarding, auth source preservation, topic UI states,
referral/Fable campaign copy, and chat-input control bar behavior.
(#15629, #15544, #15573, #15614, #15616, #15617, #15622, #15643)

---

## 🔒 Security, Reliability & Rollout Notes

- External URL file input now includes SSRF validation for safer Google
file handling. (#12657)
- Database workspace-scope migrations are part of this release;
self-hosted operators should run the normal migration path before
serving the updated app. (#15446, #15465, #15468, #15472)
- The release branch was re-cut from `canary` and includes the latest
`main` release-version commit so `v2.2.2` is the verified compare base.

---

## 👥 Contributors

@ONLY-yours, @sxjeru, @hardy-one, @xujingli, @hezhijie0327, @Coooolfan,
@arvinxx, @tjx666, @Innei, @rivertwilight, @rdmclin2, @cy948,
@AmAzing129

**Full Changelog**:
v2.2.2...release/weekly-20260610-recut-3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant