Skip to content

🐛 fix(desktop): skip browser beforeunload guard so auto-update can quit#15525

Merged
arvinxx merged 1 commit into
canaryfrom
fix/desktop-skip-beforeunload-guard
Jun 7, 2026
Merged

🐛 fix(desktop): skip browser beforeunload guard so auto-update can quit#15525
arvinxx merged 1 commit into
canaryfrom
fix/desktop-skip-beforeunload-guard

Conversation

@arvinxx

@arvinxx arvinxx commented Jun 7, 2026

Copy link
Copy Markdown
Member

💡 Description of Change

On desktop, clicking "install update" sometimes fails to quit & relaunch the app.

Root cause: while a chat message is generating, the renderer registers a browser beforeunload guard (preventLeavingFn) — the web "are you sure you want to leave?" prompt. In Electron this fires will-prevent-unload, which by default cancels window.close(), so autoUpdater.quitAndInstall() can't tear the window down and the app stays open.

On desktop this guard is unnecessary: window close / app quit is already managed by the main process via keepAlive + isQuiting. So we short-circuit preventLeavingFn on desktop.

The fix lives in preventLeavingFn itself (one place) rather than the add/remove listener call sites, so every caller is covered and the listener becomes a no-op on desktop.

🔗 Related

Reported internally: auto-update doesn't quit/relaunch on desktop while a generation is in progress.

✅ Change Type

  • 🐛 fix: A bug fix

🧪 How to Test

  1. On the desktop build, start a chat generation (so the beforeunload guard is registered).
  2. Trigger an available update → click install.
  3. App should quit and relaunch to install the update (previously it could hang with the window open).

🤖 Generated with Claude Code

On desktop the chat-loading beforeunload guard (preventLeavingFn) blocks
window.close() during quitAndInstall, so the app fails to quit & install
the update. The main process already manages close/quit via keepAlive +
isQuiting, so short-circuit the guard on desktop.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 7, 2026
@vercel

vercel Bot commented Jun 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
lobehub Ready Ready Preview, Comment Jun 7, 2026 9:26am

Request Review

@dosubot dosubot Bot added platform:desktop Desktop client trigger:build-desktop Trigger Desktop build labels Jun 7, 2026
@codecov

codecov Bot commented Jun 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 70.64%. Comparing base (6f5a633) to head (17a7b09).
⚠️ Report is 11 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary   #15525      +/-   ##
==========================================
- Coverage   70.64%   70.64%   -0.01%     
==========================================
  Files        3274     3274              
  Lines      322959   322961       +2     
  Branches    29419    34149    +4730     
==========================================
- Hits       228155   228153       -2     
- Misses      94621    94625       +4     
  Partials      183      183              
Flag Coverage Δ
app 61.30% <50.00%> (+<0.01%) ⬆️
database 92.54% <ø> (ø)
packages/agent-manager-runtime 49.69% <ø> (ø)
packages/agent-runtime 81.04% <ø> (ø)
packages/builtin-tool-lobe-agent 18.52% <ø> (ø)
packages/context-engine 84.19% <ø> (ø)
packages/conversation-flow 91.29% <ø> (ø)
packages/device-gateway-client 90.51% <ø> (ø)
packages/eval-dataset-parser 95.15% <ø> (ø)
packages/eval-rubric 76.11% <ø> (ø)
packages/fetch-sse 85.57% <ø> (-1.72%) ⬇️
packages/file-loaders 87.89% <ø> (ø)
packages/memory-user-memory 74.99% <ø> (ø)
packages/model-bank 99.99% <ø> (ø)
packages/model-runtime 84.22% <ø> (ø)
packages/prompts 72.51% <ø> (ø)
packages/python-interpreter 92.90% <ø> (ø)
packages/ssrf-safe-fetch 0.00% <ø> (ø)
packages/types 35.38% <ø> (ø)
packages/utils 84.98% <ø> (ø)
packages/web-crawler 88.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Store 68.39% <50.00%> (-0.01%) ⬇️
Services 54.77% <ø> (ø)
Server 71.82% <ø> (-0.01%) ⬇️
Libs 54.34% <ø> (+0.13%) ⬆️
Utils 81.71% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine

@arvinxx arvinxx merged commit 2453fc3 into canary Jun 7, 2026
51 of 57 checks passed
@arvinxx arvinxx deleted the fix/desktop-skip-beforeunload-guard branch June 7, 2026 09:42
@github-actions

github-actions Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Desktop App Build Completed!

Version: 0.0.0-nightly.pr15525.15309
Build Time: 2026-06-07T10:11:00.395Z

📦 Release Download · 📥 Actions Artifacts

Build Artifacts

Platform File Size
macOS (Apple Silicon) LobeHub-Nightly-0.0.0-nightly.pr15525.15309-arm64-mac.zip 334.66 MB
macOS (Apple Silicon) LobeHub-Nightly-0.0.0-nightly.pr15525.15309-arm64.dmg 140.43 MB
macOS (Intel) LobeHub-Nightly-0.0.0-nightly.pr15525.15309-mac.zip 356.56 MB
macOS (Intel) LobeHub-Nightly-0.0.0-nightly.pr15525.15309-x64.dmg 147.57 MB
Windows LobeHub-Nightly-0.0.0-nightly.pr15525.15309-setup.exe 132.50 MB
Linux LobeHub-Nightly-0.0.0-nightly.pr15525.15309.AppImage 165.20 MB

Warning

Note: This is a temporary build for testing purposes only.

arvinxx added a commit that referenced this pull request Jun 10, 2026
# 🚀 LobeHub Release (20260610)

**Release Date:** June 10, 2026  
**Since v2.2.2:** 131 merged PRs · 13 contributors

> This weekly release strengthens agent collaboration across cloud,
desktop, CLI, and workspace flows, with steadier runtime behavior and a
broader foundation for workspace-scoped data.

---

## ✨ Highlights

- **Agent execution across devices** — Unifies per-device working
directories, project skill discovery, and sub-agent suspend/resume
behavior across server, QStash, and device RPC flows. (#15543, #15566,
#15481, #15620, #15591)
- **Connector and sandbox platform** — Expands connector permissions,
custom OAuth MCP connector onboarding, sandbox provider support, and
user-uploaded file sync into cloud sandbox runs. (#15463, #15546,
#15184, #15550)
- **Desktop and CLI reliability** — Fixes desktop cold-start,
auto-update, Windows build, CLI skill discovery, and `lh connect` agent
dispatch paths. (#15547, #15525, #15527, #15562, #15632, #15634)
- **Pages and sharing** — Refreshes topic sharing, improves Page Editor
layout behavior, and routes Page Agent tool execution through the
server-side editor path. (#15581, #15556, #15588, #15023, #15610)
- **Model availability and provider updates** — Adds user-scoped LobeHub
model availability, Claude Fable 5, Qwen thinking preservation, and
MiniMax M3 updates. (#15590, #15639, #13494, #15376)

---

## 🏗️ Core Product & Architecture

### Agent Runtime & Heterogeneous Agents

- Improves sub-agent lifecycle handling, including async suspend/resume,
queue-mode QStash resume delivery, and blocking nested sub-agent calls.
(#15481, #15620, #15575)
- Stabilizes heterogeneous agent ingestion and streaming with raw stream
dumps, per-turn usage, image forwarding on regenerate, and
duplicate-text fixes. (#15602, #15577, #15592, #15585)
- Adds execution-device and working-directory controls across device
RPC, legacy defaults, and remote-spawned Claude Code sessions. (#15543,
#15566, #15591, #15572)
- Improves runtime diagnostics and compatibility, including Gemini
multimodal output capture, abort stream semantics, and trace quality
analysis. (#15535, #13677, #15508)

---

## 📱 Platforms, Integrations & UX

### Connectors, Sandbox & Tools

- Ships API-level connector tool permissions, custom OAuth MCP connector
onboarding, and connector-first runtime execution. (#15463, #15546)
- Adds sandbox provider support, cloud sandbox file sync, and safer
external URL file input handling with SSRF validation. (#15184, #15550,
#12657)
- Improves tool visibility and execution with pinned app-fixed tools,
ANSI output rendering, gateway-tunneled MCP calls, and automatic
headless tool runs. (#15509, #15516, #15469, #15492)

### Desktop, CLI & Web UX

- Restores desktop startup and reload behavior, preserves IPC error
causes, and keeps the tab bar new-tab action visible across routes.
(#15547, #15597, #15638)
- Fixes desktop update and build stability for browser quit guards,
macOS update signing, and Windows Visual Studio detection. (#15525,
#15527, #15562)
- Shows the plan-limit upgrade UI on desktop builds. (#15628)
- Adds the Agent Run delivery checker and fixes CLI device dispatch plus
skill list/search output. (#15489, #15634, #15632)
- Refreshes onboarding, auth source preservation, topic UI states,
referral/Fable campaign copy, and chat-input control bar behavior.
(#15629, #15544, #15573, #15614, #15616, #15617, #15622, #15643)

---

## 🔒 Security, Reliability & Rollout Notes

- External URL file input now includes SSRF validation for safer Google
file handling. (#12657)
- Database workspace-scope migrations are part of this release;
self-hosted operators should run the normal migration path before
serving the updated app. (#15446, #15465, #15468, #15472)
- The release branch was re-cut from `canary` and includes the latest
`main` release-version commit so `v2.2.2` is the verified compare base.

---

## 👥 Contributors

@ONLY-yours, @sxjeru, @hardy-one, @xujingli, @hezhijie0327, @Coooolfan,
@arvinxx, @tjx666, @Innei, @rivertwilight, @rdmclin2, @cy948,
@AmAzing129

**Full Changelog**:
v2.2.2...release/weekly-20260610-recut-3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

platform:desktop Desktop client size:XS This PR changes 0-9 lines, ignoring generated files. trigger:build-desktop Trigger Desktop build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant