Skip to content

πŸ› fix(desktop): bump node-gyp to 12.x so Windows build finds Visual Studio 2026#15562

Merged
arvinxx merged 1 commit into
canaryfrom
fix/desktop-node-gyp-vs2026
Jun 8, 2026
Merged

πŸ› fix(desktop): bump node-gyp to 12.x so Windows build finds Visual Studio 2026#15562
arvinxx merged 1 commit into
canaryfrom
fix/desktop-node-gyp-vs2026

Conversation

@arvinxx

@arvinxx arvinxx commented Jun 8, 2026

Copy link
Copy Markdown
Member

πŸ’» ε˜ζ›΄η±»εž‹ | Change Type

  • πŸ› fix

πŸ”€ ε˜ζ›΄θ―΄ζ˜Ž | Description of Change

The Release Desktop Canary Windows job started failing at Setup build environment (example run):

Error: Could not find any Visual Studio installation to use
    at VisualStudioFinder.fail (.../node-gyp@11.5.0/lib/find-visualstudio.js:118:11)
β¨― node-gyp failed to rebuild '.../get-windows@9.3.0'

Root cause: GitHub now redirects the windows-2025 runner to the new windows-2025-vs2026 image (annotated in the run: "windows-2025 requests are being redirected to windows-2025-vs2026 by June 15, 2026"), which ships Visual Studio 2026. The pinned node-gyp@11.5.0 only recognizes VS 2019/2022, so electron-builder install-app-deps β†’ @electron/rebuild can't compile the native get-windows module.

node-gyp 12.x adds VS 2026 to its detection list (find-visualstudio.js: [2019, 2022, 2026]). This PR overrides node-gyp to ^12.4.0 in both the root workspace and the isolated apps/desktop install (the latter is where the failing rebuild runs).

This is an environment-side regression β€” it affects every commit landing on canary, not a specific feature.

πŸ“ θ‘₯充俑息 | Additional Information

Verified locally (macOS): the isolated install + native rebuild now passes, and pnpm why node-gyp in apps/desktop collapses to a single node-gyp@12.4.0. The VS 2026 detection itself can only be confirmed on the Windows runner once this build runs.

πŸ€– Generated with Claude Code

…tudio 2026

GitHub redirects the `windows-2025` runner to the new `windows-2025-vs2026`
image, which ships Visual Studio 2026. node-gyp 11.5.0 only recognizes VS
2019/2022, so `electron-builder install-app-deps` fails to rebuild the native
`get-windows` module with "Could not find any Visual Studio installation".
node-gyp 12.x adds VS 2026 detection. Override it in both the root workspace
and the isolated apps/desktop install.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@vercel

vercel Bot commented Jun 8, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
lobehub Building Building Preview, Comment Jun 8, 2026 6:34pm

Request Review

@arvinxx arvinxx merged commit dfdf844 into canary Jun 8, 2026
18 of 19 checks passed
@arvinxx arvinxx deleted the fix/desktop-node-gyp-vs2026 branch June 8, 2026 18:36
arvinxx added a commit that referenced this pull request Jun 10, 2026
# πŸš€ LobeHub Release (20260610)

**Release Date:** June 10, 2026  
**Since v2.2.2:** 131 merged PRs Β· 13 contributors

> This weekly release strengthens agent collaboration across cloud,
desktop, CLI, and workspace flows, with steadier runtime behavior and a
broader foundation for workspace-scoped data.

---

## ✨ Highlights

- **Agent execution across devices** β€” Unifies per-device working
directories, project skill discovery, and sub-agent suspend/resume
behavior across server, QStash, and device RPC flows. (#15543, #15566,
#15481, #15620, #15591)
- **Connector and sandbox platform** β€” Expands connector permissions,
custom OAuth MCP connector onboarding, sandbox provider support, and
user-uploaded file sync into cloud sandbox runs. (#15463, #15546,
#15184, #15550)
- **Desktop and CLI reliability** β€” Fixes desktop cold-start,
auto-update, Windows build, CLI skill discovery, and `lh connect` agent
dispatch paths. (#15547, #15525, #15527, #15562, #15632, #15634)
- **Pages and sharing** β€” Refreshes topic sharing, improves Page Editor
layout behavior, and routes Page Agent tool execution through the
server-side editor path. (#15581, #15556, #15588, #15023, #15610)
- **Model availability and provider updates** β€” Adds user-scoped LobeHub
model availability, Claude Fable 5, Qwen thinking preservation, and
MiniMax M3 updates. (#15590, #15639, #13494, #15376)

---

## πŸ—οΈ Core Product & Architecture

### Agent Runtime & Heterogeneous Agents

- Improves sub-agent lifecycle handling, including async suspend/resume,
queue-mode QStash resume delivery, and blocking nested sub-agent calls.
(#15481, #15620, #15575)
- Stabilizes heterogeneous agent ingestion and streaming with raw stream
dumps, per-turn usage, image forwarding on regenerate, and
duplicate-text fixes. (#15602, #15577, #15592, #15585)
- Adds execution-device and working-directory controls across device
RPC, legacy defaults, and remote-spawned Claude Code sessions. (#15543,
#15566, #15591, #15572)
- Improves runtime diagnostics and compatibility, including Gemini
multimodal output capture, abort stream semantics, and trace quality
analysis. (#15535, #13677, #15508)

---

## πŸ“± Platforms, Integrations & UX

### Connectors, Sandbox & Tools

- Ships API-level connector tool permissions, custom OAuth MCP connector
onboarding, and connector-first runtime execution. (#15463, #15546)
- Adds sandbox provider support, cloud sandbox file sync, and safer
external URL file input handling with SSRF validation. (#15184, #15550,
#12657)
- Improves tool visibility and execution with pinned app-fixed tools,
ANSI output rendering, gateway-tunneled MCP calls, and automatic
headless tool runs. (#15509, #15516, #15469, #15492)

### Desktop, CLI & Web UX

- Restores desktop startup and reload behavior, preserves IPC error
causes, and keeps the tab bar new-tab action visible across routes.
(#15547, #15597, #15638)
- Fixes desktop update and build stability for browser quit guards,
macOS update signing, and Windows Visual Studio detection. (#15525,
#15527, #15562)
- Shows the plan-limit upgrade UI on desktop builds. (#15628)
- Adds the Agent Run delivery checker and fixes CLI device dispatch plus
skill list/search output. (#15489, #15634, #15632)
- Refreshes onboarding, auth source preservation, topic UI states,
referral/Fable campaign copy, and chat-input control bar behavior.
(#15629, #15544, #15573, #15614, #15616, #15617, #15622, #15643)

---

## πŸ”’ Security, Reliability & Rollout Notes

- External URL file input now includes SSRF validation for safer Google
file handling. (#12657)
- Database workspace-scope migrations are part of this release;
self-hosted operators should run the normal migration path before
serving the updated app. (#15446, #15465, #15468, #15472)
- The release branch was re-cut from `canary` and includes the latest
`main` release-version commit so `v2.2.2` is the verified compare base.

---

## πŸ‘₯ Contributors

@ONLY-yours, @sxjeru, @hardy-one, @xujingli, @hezhijie0327, @Coooolfan,
@arvinxx, @tjx666, @Innei, @rivertwilight, @rdmclin2, @cy948,
@AmAzing129

**Full Changelog**:
v2.2.2...release/weekly-20260610-recut-3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant