🐛 fix(desktop): focus onboarding auth success state#14694
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## canary #14694 +/- ##
===========================================
- Coverage 84.39% 66.12% -18.28%
===========================================
Files 738 2907 +2169
Lines 59933 255647 +195714
Branches 8534 30253 +21719
===========================================
+ Hits 50580 169037 +118457
- Misses 9200 86457 +77257
Partials 153 153
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ec5593c5ba
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| : (statusSuccessLoginMethod ?? | ||
| (!hasLocalLoginResult && !pendingLoginMethod ? authorizedLoginMethod : null)); |
There was a problem hiding this comment.
Reset pending login state after failed auth flows
The success fallback is now gated by !pendingLoginMethod, so once an auth attempt sets pendingLoginMethod this component will hide the existing authorized success state until that flag is cleared. In failure paths (remoteServerSyncError / authorizationFailed), pendingLoginMethod is never reset, which can leave users stuck on the login-method UI without a "Get Started" path even when a prior authorization is still valid (for example, when connectRemoteServer throws before config changes). Clearing pendingLoginMethod on failed/cancelled attempts avoids this dead-end state.
Useful? React with 👍 / 👎.
# 🚀 LobeHub Release (20260513) **Hotfix Scope:** Ship the canary backlog (111 PRs) onto main as a fast-tracked patch — operator-focused, no weekly-style write-up. > Brings the accumulated canary work into main: agent/task improvements, hetero-agent fixes, desktop & onboarding polish, and several reliability caps. ## ✨ What's Included - **Agent & tasks** — Self-review proposal-to-action automation, sub-agent dispatch consolidated to `lobe-agent`, AskUserQuestion wiring for Claude Code, scheduler/hotkey/TodoList polish. (#14583, #14657, #14715, #14639, #14732, #14707, #14713) - **Home & onboarding** — Daily brief with linkable welcome + paired input hint, inline skill auth in recommended task templates, cleanup of captcha-on-signin and marketplace early-exit. (#14589, #14676, #14573, #14598) - **Bots & integrations** — Slack MPIM support, Discord DM fix, slash-command + connect-error fixes, gateway client-tool plugin state. (#14733, #14591, #14596) - **Desktop & CLI** — Windows `.cmd` shim detection for `claude` / `codex` CLIs, auth focus & pending-login reset fixes. (#14720, #14694, #14695) - **Reliability** — Cap web-crawler body size and image binary at safe limits, attach error listeners to Neon/Node pools, reject inactive OIDC access. (#14660, #14711, #14606, #14674) - **Database** — `agent_operations` table + persist agent operations from the runtime; switch user memory search to `paradedb.match(...)`. (#14416, #14736, #14590) ## ⚙️ Upgrade - **Self-hosted:** pull the latest image and restart. Drizzle migrations (including the new `agent_operations` table) run automatically on boot.
💻 Change Type
🔗 Related Issue
No related issue found.
🔀 Description of Change
🧪 How to Test
Validation run:
📸 Screenshots / Videos
Not attached. UI change is covered by the focused component test.
📝 Additional Information
The success screen now treats the Electron remote sync config as the durable authorization source while using local component state only to control whether the focused success view has been dismissed.