[LI-HOTFIX] Adding flag to control whether to turn on the async replica fetcher threads#144
Merged
gitlw merged 7 commits intoApr 28, 2021
Conversation
|
Should we bring back JBOD-related tests/changes with the new flag? |
Author
|
@xiowu0 Thanks for the review. I'm a bit reluctant to bring them back since they don't work when the flag is turned on anyway. |
xiowu0
reviewed
Apr 27, 2021
f580c01 to
1e4b67c
Compare
1e4b67c to
c0b1c23
Compare
ambroff
reviewed
Apr 28, 2021
ambroff
approved these changes
Apr 28, 2021
Author
|
The test testIllegalRequiredAcks is failing, but the root cause is not related to the changes in this PR. |
gitlw
added a commit
that referenced
this pull request
Feb 25, 2022
…ca fetcher threads (#143) (#144) TICKET = N/A LI_DESCRIPTION = This PR adds a new config li.async.fetcher.enable to control whether the event-based fetcher threads should be used. It chooses either the asyncReplicaFetcherManager or the replicaFetcherManager based on the new config li.async.fetcher.enable EXIT_CRITERIA = N/A
lmr3796
added a commit
that referenced
this pull request
Mar 15, 2022
lmr3796
pushed a commit
to lmr3796/kafka
that referenced
this pull request
Mar 25, 2022
…ca fetcher threads (linkedin#143) (linkedin#144) TICKET = N/A LI_DESCRIPTION = This PR adds a new config li.async.fetcher.enable to control whether the event-based fetcher threads should be used. It chooses either the asyncReplicaFetcherManager or the replicaFetcherManager based on the new config li.async.fetcher.enable EXIT_CRITERIA = N/A
lmr3796
pushed a commit
to lmr3796/kafka
that referenced
this pull request
Jun 2, 2022
…fetcher threads (linkedin#143) (linkedin#144) TICKET = N/A LI_DESCRIPTION = This PR adds a new config li.async.fetcher.enable to control whether the event-based fetcher threads should be used. It chooses either the asyncReplicaFetcherManager or the replicaFetcherManager based on the new config li.async.fetcher.enable EXIT_CRITERIA = N/A
earlcoder
added a commit
that referenced
this pull request
Apr 28, 2026
The async/event-based replica fetcher series (TransferLeaderManager, AbstractAsyncFetcher, AsyncReplicaFetcher, FetcherEventBus, FetcherEventManager — PRs #121/#123/#124/#143/#144/#403/#406) was removed in the PR #538 squash. The li.async.fetcher.enable config key was left behind in KafkaConfig as dead surface area: it parsed and validated, but had no consumers. Going with audit P1 #6 option (a): retire the feature, remove the dead config key. Operators with li.async.fetcher.enable=<anything> in their server.properties may see an 'Unknown configuration' warning at broker startup; this is harmless — the broker still starts and the value would have been a no-op anyway. Removes: - Defaults.LiAsyncFetcherEnabled - KafkaConfig.LiAsyncFetcherEnableProp - The brokerConfigDef.define(...) registration - KafkaConfig.liAsyncFetcherEnable accessor Audit option (b) — porting the entire async fetcher series forward into 3.6-li — was deferred. If the optimization is needed in the future, it would need to be reimplemented from scratch on top of upstream's current ReplicaFetcherThread / ReplicaFetcherManager.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TICKET = N/A
LI_DESCRIPTION =
This PR adds a new config li.async.fetcher.enable to control whether the event-based fetcher threads should be used.
It includes the following changes
EXIT_CRITERIA = N/A
Committer Checklist (excluded from commit message)