HOTFIX - LIKAFKA-21968: Add broker-side auditor interface and NoOpAuditor implementation#6
Merged
Merged
Conversation
smccauliff
reviewed
Mar 25, 2019
hzxa21
reviewed
Mar 25, 2019
radai-rosenblatt
approved these changes
Mar 25, 2019
Lincong
pushed a commit
that referenced
this pull request
Mar 26, 2019
…server implementation (#6) Reviewers: Radai Rosenblatt
xiowu0
pushed a commit
that referenced
this pull request
Jun 11, 2019
…pObserver implementation (#6) TICKET = LI_DESCRIPTION = Reviewers: Radai Rosenblatt EXIT_CRITERIA = MANUAL ["describe exit criteria"]
xiowu0
pushed a commit
that referenced
this pull request
Jul 17, 2019
…pObserver implementation (#6) TICKET = LI_DESCRIPTION = Reviewers: Radai Rosenblatt EXIT_CRITERIA = MANUAL [""]
xiowu0
pushed a commit
that referenced
this pull request
Aug 22, 2019
…pObserver implementation (#6) TICKET = LI_DESCRIPTION = The observer interface lets us provide implementation which provides the usage accounting data unit for the C2S V3 service. Reviewers: Radai Rosenblatt EXIT_CRITERIA = MANUAL [""]
gitlw
pushed a commit
that referenced
this pull request
May 18, 2020
…pObserver implementation (#6) TICKET = LI_DESCRIPTION = The observer interface lets us provide implementation which provides the usage accounting data unit for the C2S V3 service. Reviewers: Radai Rosenblatt EXIT_CRITERIA = MANUAL [""]
gitlw
pushed a commit
that referenced
this pull request
May 26, 2020
…pObserver implementation (#6) TICKET = LI_DESCRIPTION = The observer interface lets us provide implementation which provides the usage accounting data unit for the C2S V3 service. Reviewers: Radai Rosenblatt EXIT_CRITERIA = MANUAL [""]
gitlw
pushed a commit
that referenced
this pull request
Jun 12, 2020
…pObserver implementation (#6) TICKET = LI_DESCRIPTION = The observer interface lets us provide implementation which provides the usage accounting data unit for the C2S V3 service. Reviewers: Radai Rosenblatt EXIT_CRITERIA = MANUAL [""]
gitlw
pushed a commit
that referenced
this pull request
Jun 13, 2020
…pObserver implementation (#6) TICKET = LI_DESCRIPTION = The observer interface lets us provide implementation which provides the usage accounting data unit for the C2S V3 service. Reviewers: Radai Rosenblatt EXIT_CRITERIA = MANUAL [""]
earlcoder
added a commit
that referenced
this pull request
Apr 28, 2026
The async/event-based replica fetcher series (TransferLeaderManager, AbstractAsyncFetcher, AsyncReplicaFetcher, FetcherEventBus, FetcherEventManager — PRs #121/#123/#124/#143/#144/#403/#406) was removed in the PR #538 squash. The li.async.fetcher.enable config key was left behind in KafkaConfig as dead surface area: it parsed and validated, but had no consumers. Going with audit P1 #6 option (a): retire the feature, remove the dead config key. Operators with li.async.fetcher.enable=<anything> in their server.properties may see an 'Unknown configuration' warning at broker startup; this is harmless — the broker still starts and the value would have been a no-op anyway. Removes: - Defaults.LiAsyncFetcherEnabled - KafkaConfig.LiAsyncFetcherEnableProp - The brokerConfigDef.define(...) registration - KafkaConfig.liAsyncFetcherEnable accessor Audit option (b) — porting the entire async fetcher series forward into 3.6-li — was deferred. If the optimization is needed in the future, it would need to be reimplemented from scratch on top of upstream's current ReplicaFetcherThread / ReplicaFetcherManager.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an auditor interface and a no-op implementation. The auditor is used in KafkaApi and every request/response pair is routed to some function of this auditor. The motivation of this PR is described in the LIKAFKA ticket or KIP388.
No new test is added and all existing tests pass. Tests will be added to the kafka-server MP when a non-trivial implementation of this auditor interface is added from Kafka-server MP.