[LI-HOTFIX] Cleaning up fetcher threads in ReplicaManagerTest#149
Closed
gitlw wants to merge 6 commits into
Closed
[LI-HOTFIX] Cleaning up fetcher threads in ReplicaManagerTest#149gitlw wants to merge 6 commits into
gitlw wants to merge 6 commits into
Conversation
3 tasks
60b840d to
c346cb2
Compare
TICKET = N/A LI_DESCRIPTION = At the end of the ReplicaManagerTest.testIllegalRequiredAcks test, there is logic to verify that there are no non-daemon threads with TestUtils.assertNoNonDaemonThreads(this.getClass.getName) However, some other test in the same class could have left some non-daemon threads running, which will case the test above to fail. This PR ensures that each test method closes the fetcher threads it may have created. Also a validation is added to the tearDown method to ensure no non-daemon threads are running. EXIT_CRITERIA = N/A
8b73000 to
150b9d2
Compare
ambroff
reviewed
May 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TICKET = N/A
LI_DESCRIPTION =
At the end of the ReplicaManagerTest.testIllegalRequiredAcks test,
there is logic to verify that there are no non-daemon threads with
TestUtils.assertNoNonDaemonThreads(this.getClass.getName)
However, some other test in the same class could have left some
non-daemon threads running, which will cause the test above to fail.
This PR ensures that each test method closes the fetcher threads
it may have created. Also, validation is added to the tearDown
method to ensure no non-daemon threads are left running by each test method.
EXIT_CRITERIA = N/A
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)