Add payment secret feature to Bolt 11 test vectors by t-bast · Pull Request #898 · lightning/bolts

t-bast · 2021-08-23T12:45:47Z

Bolt 11 invoices must contain a payment_secret, which means that the features field must set the payment_secret feature (and its dependency, var_onion_optin).

Fixes #897

Bolt 11 invoices must contain a `payment_secret`, which means that the `features` field must set the `payment_secret` feature (and its dependency, `var_onion_optin`). Fixes #897

Add feature bits, as indicated by lightning/bolts#898

We now match the spec once lightning/bolts#898 is merged.

TheBlueMatt

At least the "Signature is not recoverable." and "Invalid sub-millisatoshi precision." failure cases also need a feature flag, likely others as well but those are just the two that our implementation complains about as missing feature.

This pulls the BOLT 11 test vectors from lightning/bolts#898, tweaking our tests to properly handle them.

TheBlueMatt

The changes here LGTM, verified they pass our own tests, though the error cases could use the feature flag as well.

TheBlueMatt · 2021-08-24T22:07:44Z

11-payment-encoding.md


 > ### On mainnet, with fallback address 1RustyRX2oai4EYYDpQGWvEL62BBGqN9T with extra routing info to go via nodes 029e03a901b85534ff1e92c43c74431f7ce72046060fcf7a95c37e148f78c77255 then 039e03a901b85534ff1e92c43c74431f7ce72046060fcf7a95c37e148f78c77255
-> lnbc20m1pvjluezsp5zyg3zyg3zyg3zyg3zyg3zyg3zyg3zyg3zyg3zyg3zyg3zyg3zygspp5qqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqypqhp58yjmdan79s6qqdhdzgynm4zwqd5d7xmw5fk98klysy043l2ahrqsfpp3qjmp7lwpagxun9pygexvgpjdc4jdj85fr9yq20q82gphp2nflc7jtzrcazrra7wwgzxqc8u7754cdlpfrmccae92qgzqvzq2ps8pqqqqqqpqqqqq9qqqvpeuqafqxu92d8lr6fvg0r5gv0heeeqgcrqlnm6jhphu9y00rrhy4grqszsvpcgpy9qqqqqqgqqqqq7qqzqg042ea62q6wnxh909rfuu4x2amxc59mj99mrhr32kvqhytrm04us8edg0syy9n0ukgam0ud20jcxwskphv3rzpnengjsf8m3w9u5w8cqzrhtg2
+> lnbc20m1pvjluezsp5zyg3zyg3zyg3zyg3zyg3zyg3zyg3zyg3zyg3zyg3zyg3zyg3zygspp5qqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqypqhp58yjmdan79s6qqdhdzgynm4zwqd5d7xmw5fk98klysy043l2ahrqsfpp3qjmp7lwpagxun9pygexvgpjdc4jdj85fr9yq20q82gphp2nflc7jtzrcazrra7wwgzxqc8u7754cdlpfrmccae92qgzqvzq2ps8pqqqqqqpqqqqq9qqqvpeuqafqxu92d8lr6fvg0r5gv0heeeqgcrqlnm6jhphu9y00rrhy4grqszsvpcgpy9qqqqqqgqqqqq7qqzq9qrsgqdfjcdk6w3ak5pca9hwfwfh63zrrz06wwfya0ydlzpgzxkn5xagsqz7x9j4jwe7yj7vaf2k9lqsdk45kts2fd0fkr28am0u4w95tt2nsq76cqw0


While you're tweaking this, can you add an "0x" prefix on the short_channel_id fields a few lines down?

I changed to the friendlier short_channel_id notation that uses blockheight in 45222fb

t-bast · 2021-08-25T07:03:50Z

At least the "Signature is not recoverable." and "Invalid sub-millisatoshi precision." failure cases also need a feature flag, likely others as well but those are just the two that our implementation complains about as missing feature.

Thanks, I wondered where that would be verified in each implementation, in eclair this is verified last, but there's no reason other implementations do the same. I'll update all failure cases that make sense.

t-bast · 2021-08-25T07:49:42Z

As you pointed out, only the last two failure test vectors need to be updated, the others have a completely invalid format which should always be checked before the actual contents. I updated them in c32d06a

We now match the spec once lightning/bolts#898 is merged.

TheBlueMatt · 2021-08-27T02:20:23Z

LDK still reports this failure case as "NoPaymentSecret":

"Signature is not recoverable.
lnbc2500u1pvjluezpp5qqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqypqdq5xysxxatsyp3k7enxv4jsxqzpuaxtrnwngzn3kdzw5hydlzf03qdgm2hdq27cqv3agm2awhz5se903vruatfhq77w3ls4evs3ch9zw97j25emudupq63nyw24cg27h2rspk28uwq"

This pulls the BOLT 11 test vectors from lightning/bolts#898, tweaking our tests to properly handle them.

This test vector was generated by creating a valid invoice, then flipping the recoveryId to be 2 instead of 0 or 1.

t-bast · 2021-08-27T08:21:50Z

LDK still reports this failure case as "NoPaymentSecret":

Right, there's no reason to assume recovering the pubkey from the sig should be done before validating the invoice's contents.
I updated this test vector in 6435025 (I generated the correct signature then flipped the recovery ID to be 0x02, that does the trick with libsecp256k1, let me know if that works for LDK).

This pulls the BOLT 11 test vectors from lightning/bolts#898, tweaking our tests to properly handle them.

TheBlueMatt · 2021-08-27T17:41:21Z

Thanks! Tested the latest and it all passes/fails with expected errors.

We now match the spec once lightning/bolts#898 is merged.

This pulls the BOLT 11 test vectors from lightning/bolts#898, tweaking our tests to properly handle them.

Add feature bits, as indicated by lightning/bolts#898

t-bast · 2021-09-14T07:11:32Z

Merging as per yesterday's spec meeting.

Add payment secrets (see lightning/bolts#887) Add feature bits (see lightning/bolts#898)

We now match the spec once lightning/bolts#898 is merged.

Bolt 11 invoices must contain a `payment_secret`, which means that the `features` field must set the `payment_secret` feature (and its dependency, `var_onion_optin`). Fixes lightning#897

we now require payment_secret both for sending and for receiving (previously was optional for both) see lightning/bolts#898 ACINQ/eclair#1810 ElementsProject/lightning#4646 note: payment_secret depends on var_onion_optin, so that becomes mandatory as well, however this commit does not yet remove the ability of creating legacy onions

We now match the spec once lightning/bolts#898 is merged.

Add payment secret feature to Bolt 11 test vectors

89a5da4

Bolt 11 invoices must contain a `payment_secret`, which means that the `features` field must set the `payment_secret` feature (and its dependency, `var_onion_optin`). Fixes #897

t-bast requested review from TheBlueMatt and rustyrussell August 23, 2021 12:45

t-bast added a commit to ACINQ/eclair that referenced this pull request Aug 23, 2021

Update test vectors

16dc917

Add feature bits, as indicated by lightning/bolts#898

t-bast added a commit to ACINQ/lightning-kmp that referenced this pull request Aug 23, 2021

Update Bolt11 test vectors

c1ae78d

We now match the spec once lightning/bolts#898 is merged.

t-bast mentioned this pull request Aug 23, 2021

Update Bolt11 test vectors ACINQ/lightning-kmp#293

Merged

TheBlueMatt reviewed Aug 24, 2021

View reviewed changes

TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this pull request Aug 24, 2021

Use new BOLT 11 test vectors with payment_secrets and feature flags

b52195e

This pulls the BOLT 11 test vectors from lightning/bolts#898, tweaking our tests to properly handle them.

TheBlueMatt approved these changes Aug 24, 2021

View reviewed changes

t-bast added 2 commits August 25, 2021 09:22

Use friendly shortChannelId notation

45222fb

Update some failure test vectors

c32d06a

t-bast added a commit to ACINQ/lightning-kmp that referenced this pull request Aug 25, 2021

Update Bolt11 test vectors

b8a2b15

We now match the spec once lightning/bolts#898 is merged.

TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this pull request Aug 27, 2021

Use new BOLT 11 test vectors with payment_secrets and feature flags

52468bf

This pulls the BOLT 11 test vectors from lightning/bolts#898, tweaking our tests to properly handle them.

TheBlueMatt mentioned this pull request Aug 27, 2021

Fix and modernize lightning-invoice API lightningdevkit/rust-lightning#1057

Merged

Update non-recoverable sig test vector

6435025

This test vector was generated by creating a valid invoice, then flipping the recoveryId to be 2 instead of 0 or 1.

sstone mentioned this pull request Aug 27, 2021

Update Bolt 11 official test vectors ACINQ/eclair#1870

Merged

TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this pull request Aug 27, 2021

Use new BOLT 11 test vectors with payment_secrets and feature flags

2735cea

This pulls the BOLT 11 test vectors from lightning/bolts#898, tweaking our tests to properly handle them.

TheBlueMatt approved these changes Aug 27, 2021

View reviewed changes

t-bast added a commit to ACINQ/lightning-kmp that referenced this pull request Aug 30, 2021

Update Bolt11 test vectors

3cbcd7a

We now match the spec once lightning/bolts#898 is merged.

TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this pull request Aug 31, 2021

Use new BOLT 11 test vectors with payment_secrets and feature flags

a901927

This pulls the BOLT 11 test vectors from lightning/bolts#898, tweaking our tests to properly handle them.

TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this pull request Aug 31, 2021

Use new BOLT 11 test vectors with payment_secrets and feature flags

a906c49

This pulls the BOLT 11 test vectors from lightning/bolts#898, tweaking our tests to properly handle them.

t-bast mentioned this pull request Sep 8, 2021

Lightning Specification Meeting 2021/09/13 #909

Closed

19 tasks

t-bast added a commit to ACINQ/eclair that referenced this pull request Sep 9, 2021

Update test vectors

db60ccd

Add feature bits, as indicated by lightning/bolts#898

t-bast merged commit c876dac into master Sep 14, 2021

t-bast deleted the bolt11-test-vectors-features branch September 14, 2021 07:11

t-bast added a commit to ACINQ/eclair that referenced this pull request Sep 14, 2021

Update Bolt 11 official test vectors (#1870)

fb0199c

Add payment secrets (see lightning/bolts#887) Add feature bits (see lightning/bolts#898)

t-bast added a commit to ACINQ/lightning-kmp that referenced this pull request Sep 22, 2021

Update Bolt11 test vectors

07a8947

We now match the spec once lightning/bolts#898 is merged.

t-bast added a commit to ACINQ/lightning-kmp that referenced this pull request Sep 22, 2021

Update Bolt11 test vectors (#293)

da7b603

We now match the spec once lightning/bolts#898 is merged.

docker-lordvf6ik added a commit to docker-lordvf6ik/lightning-kmp that referenced this pull request Sep 28, 2025

Update Bolt11 test vectors (#293)

d12cc01

We now match the spec once lightning/bolts#898 is merged.

ebonyschneider462359 added a commit to ebonyschneider462359/lightning-kmp that referenced this pull request Oct 10, 2025

Update Bolt11 test vectors (#293)

d950509

We now match the spec once lightning/bolts#898 is merged.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add payment secret feature to Bolt 11 test vectors#898

Add payment secret feature to Bolt 11 test vectors#898
t-bast merged 4 commits intomasterfrom
bolt11-test-vectors-features

t-bast commented Aug 23, 2021

Uh oh!

TheBlueMatt left a comment

Uh oh!

TheBlueMatt left a comment

Uh oh!

TheBlueMatt Aug 24, 2021

Uh oh!

t-bast Aug 25, 2021

Uh oh!

t-bast commented Aug 25, 2021

Uh oh!

t-bast commented Aug 25, 2021

Uh oh!

TheBlueMatt commented Aug 27, 2021

Uh oh!

t-bast commented Aug 27, 2021

Uh oh!

TheBlueMatt commented Aug 27, 2021

Uh oh!

t-bast commented Sep 14, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

t-bast commented Aug 23, 2021

Uh oh!

TheBlueMatt left a comment

Choose a reason for hiding this comment

Uh oh!

TheBlueMatt left a comment

Choose a reason for hiding this comment

Uh oh!

TheBlueMatt Aug 24, 2021

Choose a reason for hiding this comment

Uh oh!

t-bast Aug 25, 2021

Choose a reason for hiding this comment

Uh oh!

t-bast commented Aug 25, 2021

Uh oh!

t-bast commented Aug 25, 2021

Uh oh!

TheBlueMatt commented Aug 27, 2021

Uh oh!

t-bast commented Aug 27, 2021

Uh oh!

TheBlueMatt commented Aug 27, 2021

Uh oh!

t-bast commented Sep 14, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants