Skip to content

Update Bolt 11 official test vectors#1870

Merged
t-bast merged 5 commits intomasterfrom
bolt11-test-vectors-payment-secret
Sep 14, 2021
Merged

Update Bolt 11 official test vectors#1870
t-bast merged 5 commits intomasterfrom
bolt11-test-vectors-payment-secret

Conversation

@t-bast
Copy link
Copy Markdown
Member

@t-bast t-bast commented Jul 12, 2021 •
edited
Loading

Add payment secrets (see lightning/bolts#887)
We'll wait for the next release, and then change the payment_secret field to be non-optional

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 12, 2021 •
edited
Loading

Codecov Report

Merging #1870 (8d42235) into master (663094e) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@          Coverage Diff           @@
##           master   #1870   +/-   ##
======================================
  Coverage    8.96%   8.96%           
======================================
  Files         158     158           
  Lines       12330   12335    +5     
  Branches      530     515   -15     
======================================
+ Hits         1105    1106    +1     
- Misses      11225   11229    +4
Impacted Files Coverage Δ
...scala/fr/acinq/eclair/payment/PaymentRequest.scala 51.91% <0.00%> (-0.87%) ⬇️
...re/src/main/scala/fr/acinq/eclair/NodeParams.scala 2.57% <0.00%> (-0.02%) ⬇️
...r-core/src/main/scala/fr/acinq/eclair/Eclair.scala 0.00% <0.00%> (ø)
...n/scala/fr/acinq/eclair/transactions/Scripts.scala 41.37% <0.00%> (+1.72%) ⬆️

@t-bast t-bast marked this pull request as ready for review August 17, 2021 06:50
@t-bast t-bast requested a review from pm47 August 17, 2021 06:50
@t-bast t-bast force-pushed the bolt11-test-vectors-payment-secret branch from 0012da3 to b3feeff Compare August 17, 2021 06:53
@t-bast t-bast requested a review from sstone August 17, 2021 08:09
@sstone
Copy link
Copy Markdown
Member

sstone commented Aug 18, 2021

it seems that the On mainnet, please send 0.00967878534 BTC for a list of items within one week, amount in pico-BTC test has not been updated, and we're missing the Invalid sub-millisatoshi precision test (it was missing before)

@t-bast
Copy link
Copy Markdown
Member Author

t-bast commented Aug 18, 2021

we're missing the Invalid sub-millisatoshi precision test (it was missing before)

Good catch, it was missing because we actually didn't implement that check!
Done in 716a22e

sstone
sstone previously approved these changes Aug 24, 2021
View reviewed changes
@sstone
Copy link
Copy Markdown
Member

sstone commented Aug 27, 2021

LGTM, but we probably should wait until lightning/bolts#898 has been merged ?

@t-bast
Copy link
Copy Markdown
Member Author

t-bast commented Aug 30, 2021

Yes sure, let's wait for the spec PR to be accepted before merging here.

@t-bast t-bast force-pushed the bolt11-test-vectors-payment-secret branch from cd65bbe to 8d42235 Compare September 9, 2021 06:57
@t-bast t-bast requested a review from sstone September 14, 2021 07:12
@t-bast
Copy link
Copy Markdown
Member Author

t-bast commented Sep 14, 2021

lightning/bolts#898 has just been merged, so we can merge this PR now.

@t-bast t-bast merged commit fb0199c into master Sep 14, 2021
@t-bast t-bast deleted the bolt11-test-vectors-payment-secret branch September 14, 2021 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sstone sstone sstone approved these changes

@pm47 pm47 Awaiting requested review from pm47

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@t-bast @codecov-commenter @sstone