Make payment secret mandatory and update Bolt 11 test vectors#887
Merged
Make payment secret mandatory and update Bolt 11 test vectors#887
Conversation
t-bast
added a commit
to ACINQ/eclair
that referenced
this pull request
Jul 12, 2021
Add payment secrets (see lightning/bolts#887)
Collaborator
rustyrussell
left a comment
There was a problem hiding this comment.
Seems OK, but the checksums and signatures in the breakdowns are incorrect.
Let me write a tool to generate these, and I can create another diff...
Collaborator
Author
Right, good catch. Don't worry, I'll fix these today! |
Collaborator
|
Already done, might as well take my changes! Also, validated the vectors, thanks! See the guilt/pr-887 branch for three more commits: https://github.com/lightningnetwork/lightning-rfc/tree/guilt/pr-887 |
fe4a664 to
02b8026
Compare
Collaborator
Author
|
Great, I had done it in parallel and I just checked your commits, we find the same results so we should be good to go ;) |
Update Bolt 11 test vectors to always include a payment secret. We want to make it mandatory in invoices which would make the existing test vectors invalid.
424898a to
42bd71d
Compare
Collaborator
|
Ack 42bd71d |
This was referenced Aug 10, 2021
TheBlueMatt
approved these changes
Aug 12, 2021
Collaborator
TheBlueMatt
left a comment
There was a problem hiding this comment.
Didn't check the new vectors, but text changes look good.
t-bast
added a commit
to ACINQ/eclair
that referenced
this pull request
Aug 17, 2021
Add payment secrets (see lightning/bolts#887)
t-bast
added a commit
to ACINQ/eclair
that referenced
this pull request
Sep 9, 2021
Add payment secrets (see lightning/bolts#887)
t-bast
added a commit
to ACINQ/eclair
that referenced
this pull request
Sep 14, 2021
Add payment secrets (see lightning/bolts#887) Add feature bits (see lightning/bolts#898)
This was referenced Mar 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Bolt 11 test vectors to always include a payment secret.
We want to make it mandatory in invoices which would make the existing test vectors invalid.