BOLT-04: replace quotation marks used in math expressions#1158
Closed
dple wants to merge 2 commits intolightning:masterfrom
Closed
BOLT-04: replace quotation marks used in math expressions#1158dple wants to merge 2 commits intolightning:masterfrom
dple wants to merge 2 commits intolightning:masterfrom
Conversation
In this commit, we propose a change of quotation marks being used in math expression. Rather than using " (e.g., $"rho_i"$), we use $``rho''$ that will be rendered better in Latex
t-bast
reviewed
Apr 30, 2024
| - MUST set `encrypted_data_tlv[i].next_blinding_override` to $`E_{i+1}`$ | ||
| - MAY store private data in `encrypted_data_tlv[r].path_id` to verify that the route is used in the right context and was created by them | ||
| - SHOULD add padding data to ensure all `encrypted_data_tlv[i]` have the same length | ||
| - MUST encrypt each `encrypted_data_tlv[i]` with ChaCha20-Poly1305 using the corresponding `rho_i` key and an all-zero nonce to produce `encrypted_recipient_data[i]` |
Collaborator
There was a problem hiding this comment.
nit:
Suggested change
| - MUST encrypt each `encrypted_data_tlv[i]` with ChaCha20-Poly1305 using the corresponding `rho_i` key and an all-zero nonce to produce `encrypted_recipient_data[i]` | |
| - MUST encrypt each `encrypted_data_tlv[i]` with ChaCha20-Poly1305 using the corresponding $`rho_i`$ key and an all-zero nonce to produce `encrypted_recipient_data[i]` |
Collaborator
Author
There was a problem hiding this comment.
Collaborator
There was a problem hiding this comment.
@dple this comment is not for the line you're referring to in your screenshot, you're confusing it with #1158 (comment)
Can you fix line 511 (see the first part of this comment) and #1158 (comment), and then we can merge this PR?
ProofOfKeags
approved these changes
Apr 30, 2024
Contributor
ProofOfKeags
left a comment
There was a problem hiding this comment.
One suggested change but otherwise looks good.
|
|
||
| - MUST create a blinded node ID $`B_i`$ for each node using the following algorithm: | ||
| - $`e_0 /leftarrow {0;1}^256`$ ($`e_0`$ SHOULD be obtained via CSPRG) | ||
| - $`e_0 \leftarrow \{0;1\}^{256}`$ ($`e_0`$ SHOULD be obtained via CSPRG) |
25 tasks
Closed
Roasbeef
approved these changes
May 7, 2024
Collaborator
Roasbeef
left a comment
There was a problem hiding this comment.
LGTM 🏸
Base changes look good, edits from the other reviewers should also be applied.
Merged
t-bast
added a commit
to t-bast/bolts
that referenced
this pull request
Jul 11, 2024
This commit doesn't change the logic at all, it simply: - removes `realm` from onion test vector - cleans-up markdown formatting and indents - fixes typos and missing parenthesis - consistently uses `_` instead of `-` for field names - fixes math formatting (including changes from lightning#1169 and lightning#1158)
rustyrussell
pushed a commit
to rustyrussell/bolts
that referenced
this pull request
Jul 17, 2024
This commit doesn't change the logic at all, it simply: - removes `realm` from onion test vector - cleans-up markdown formatting and indents - fixes typos and missing parenthesis - consistently uses `_` instead of `-` for field names - fixes math formatting (including changes from lightning#1169 and lightning#1158)
Collaborator
|
Those fixes were included as part of #1181 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this commit, we propose a change of quotation marks being used in math expression. Rather than using " (e.g.,$"rho_i"$ ), we use $``rho''$ that will be rendered better in Latex