BOLT 11: Copy edit#502
Merged
rustyrussell merged 6 commits intolightning:masterfrom Jan 7, 2019
toadlyBroodle:copy-edit-bolt-11
Merged
BOLT 11: Copy edit#502rustyrussell merged 6 commits intolightning:masterfrom toadlyBroodle:copy-edit-bolt-11
rustyrussell merged 6 commits intolightning:masterfrom
toadlyBroodle:copy-edit-bolt-11
Conversation
rustyrussell
requested changes
Nov 26, 2018
Collaborator
rustyrussell
left a comment
There was a problem hiding this comment.
Minor changes, only; sorry for the delay due to summit!
11-payment-encoding.md
Outdated
| and MUST fail if the checksum is incorrect. | ||
| A writer: | ||
| - unless the Bech32 string MAY be longer than the 90 characters specified in BIP-0173: | ||
| - MUST encode the payment request in Bech32 (see BIP-0173). |
Collaborator
There was a problem hiding this comment.
This should read:
A writer:
- MUST encode the payment request in Bech32 (see BIP-0173)
- MAY exceed the 90-character limit specified in BIP-0173.
11-payment-encoding.md
Outdated
| - if it does not understand the `prefix`: | ||
| - MUST fail the payment. | ||
| - if the `amount` is empty: | ||
| - SHOULD indicate that amount is unspecified [FIXME: indicate where or to whom?]. |
Collaborator
There was a problem hiding this comment.
- SHOULD indicate to the payer that amount is unspecified
Collaborator
Author
There was a problem hiding this comment.
...and done. No worries, you're a busy man!
rustyrussell
approved these changes
Dec 10, 2018
cdecker
reviewed
Jan 7, 2019
| - MUST encode `prefix` using the currency required for successful payment. | ||
| - if a specific minimum `amount` is required for successful payment: | ||
| - MUST include that `amount`. | ||
| - MUST encode `amount` as a positive decimal integer with no leading 0s. |
Collaborator
There was a problem hiding this comment.
Suggested change
| - MUST encode `amount` as a positive decimal integer with no leading 0s. | |
| - MUST encode `amount` as a positive decimal integer with no leading zeoes (`0`). |
Contributor
There was a problem hiding this comment.
Suggested change
| - MUST encode `amount` as a positive decimal integer with no leading 0s. | |
| - MUST encode `amount` as a positive decimal integer with no leading zeroes. |
| `fee_base_msat`, `fee_proportional_millionths`, and `cltv_expiry_delta` are as | ||
| specified in [BOLT #7](07-routing-gossip.md#the-channel_update-message). | ||
| - MAY include more than one `r` field to provide multiple routing options. | ||
| - MUST pad field data to a multiple of 5 bits, using 0s. |
Collaborator
There was a problem hiding this comment.
Suggested change
| - MUST pad field data to a multiple of 5 bits, using 0s. | |
| - MUST pad field data to a multiple of 5 bits, using zeroes (`0`). |
| - MUST encode `prefix` using the currency required for successful payment. | ||
| - if a specific minimum `amount` is required for successful payment: | ||
| - MUST include that `amount`. | ||
| - MUST encode `amount` as a positive decimal integer with no leading 0s. |
Collaborator
There was a problem hiding this comment.
Seems we are mixing tabs and spaces here, could we make this consistent while we're here?
niftynei
reviewed
Jan 7, 2019
| # Basic checklist/stylesheet used for copy editing BOLTs | ||
|
|
||
| This checklist/stylesheet is temporarily included here for reference purposes. | ||
| Contributions should comply with this checklist/stylsheet to maintain correct, clear, consistent, and concise BOLTS. |
dple
added a commit
to dple/bolts
that referenced
this pull request
Apr 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whew...finally done editing all the BOLTs! Won't mess with them anymore, promise.